All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH] hrtimer: avoid retrigger_next_event IPI
Date: Thu, 08 Apr 2021 02:20:40 +0800	[thread overview]
Message-ID: <202104080229.6KQMRvZG-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 7284 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210407135301.GA16985@fuller.cnet>
References: <20210407135301.GA16985@fuller.cnet>
TO: Marcelo Tosatti <mtosatti@redhat.com>
TO: Thomas Gleixner <tglx@linutronix.de>
CC: linux-kernel(a)vger.kernel.org
CC: Frederic Weisbecker <frederic@kernel.org>
CC: Peter Xu <peterx@redhat.com>
CC: Nitesh Narayan Lal <nitesh@redhat.com>
CC: Alex Belits <abelits@marvell.com>

Hi Marcelo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on linux/master linus/master v5.12-rc6 next-20210407]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marcelo-Tosatti/hrtimer-avoid-retrigger_next_event-IPI/20210407-233005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git d4c7c28806616809e3baa0b7cd8c665516b2726d
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-s001-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://github.com/0day-ci/linux/commit/defd4db9d63d1f16e3e21862bd9c9105a9f6a7e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marcelo-Tosatti/hrtimer-avoid-retrigger_next_event-IPI/20210407-233005
        git checkout defd4db9d63d1f16e3e21862bd9c9105a9f6a7e9
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> kernel/time/hrtimer.c:944:1: sparse: sparse: unused label 'set_timerfd'

vim +/set_timerfd +944 kernel/time/hrtimer.c

defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  895  
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  896  /*
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  897   * Clock realtime was set
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  898   *
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  899   * Change the offset of the realtime clock vs. the monotonic
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  900   * clock.
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  901   *
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  902   * We might have to reprogram the high resolution timer interrupt. On
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  903   * SMP we call the architecture specific code to retrigger _all_ high
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  904   * resolution timer interrupts. On UP we just disable interrupts and
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  905   * call the high resolution interrupt code.
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  906   */
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  907  void clock_was_set(void)
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  908  {
90ff1f30c0f401 kernel/hrtimer.c      Thomas Gleixner 2011-05-25  909  #ifdef CONFIG_HIGH_RES_TIMERS
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  910  	cpumask_var_t mask;
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  911  	int cpu;
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  912  
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  913  	if (!tick_nohz_full_enabled()) {
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  914  		/* Retrigger the CPU local events everywhere */
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  915  		on_each_cpu(retrigger_next_event, NULL, 1);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  916  		goto set_timerfd;
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  917  	}
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  918  
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  919  	if (!zalloc_cpumask_var(&mask, GFP_KERNEL)) {
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  920  		on_each_cpu(retrigger_next_event, NULL, 1);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  921  		goto set_timerfd;
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  922  	}
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  923  
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  924  	/* Avoid interrupting nohz_full CPUs if possible */
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  925  	preempt_disable();
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  926  	for_each_online_cpu(cpu) {
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  927  		if (tick_nohz_full_cpu(cpu)) {
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  928  			unsigned long flags;
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  929  			struct hrtimer_cpu_base *cpu_base = &per_cpu(hrtimer_bases, cpu);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  930  
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  931  			raw_spin_lock_irqsave(&cpu_base->lock, flags);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  932  			if (need_reprogram_timer(cpu_base))
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  933  				cpumask_set_cpu(cpu, mask);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  934  			else
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  935  				hrtimer_update_base(cpu_base);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  936  			raw_spin_unlock_irqrestore(&cpu_base->lock, flags);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  937  		}
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  938  	}
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  939  
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  940  	smp_call_function_many(mask, retrigger_next_event, NULL, 1);
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  941  	preempt_enable();
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07  942  	free_cpumask_var(mask);
9ec2690758a546 kernel/hrtimer.c      Thomas Gleixner 2011-05-20  943  #endif
defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 @944  set_timerfd:
9ec2690758a546 kernel/hrtimer.c      Thomas Gleixner 2011-05-20  945  	timerfd_clock_was_set();
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  946  }
b12a03ce4880bd kernel/hrtimer.c      Thomas Gleixner 2011-05-02  947  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33876 bytes --]

             reply	other threads:[~2021-04-07 18:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 18:20 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-07 13:53 [PATCH] hrtimer: avoid retrigger_next_event IPI Marcelo Tosatti
2021-04-07 19:28 ` kernel test robot
2021-04-07 19:28   ` kernel test robot
2021-04-07 22:14 ` Frederic Weisbecker
2021-04-08 12:27   ` Marcelo Tosatti
2021-04-09 14:15 ` Thomas Gleixner
2021-04-09 16:51   ` Marcelo Tosatti
2021-04-10  7:53     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104080229.6KQMRvZG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.