* [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
@ 2021-04-08 6:20 ` Pu Lehui
0 siblings, 0 replies; 4+ messages in thread
From: Pu Lehui @ 2021-04-08 6:20 UTC (permalink / raw)
To: mpe, benh, paulus, joel, christophe.leroy
Cc: linuxppc-dev, linux-kernel, zhangjinhao2, yangjihong1, pulehui
Fix sparse warnings:
arch/powerpc/platforms/pseries/rtas-fadump.c:250:6: warning:
symbol 'rtas_fadump_set_regval' was not declared. Should it be static?
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
arch/powerpc/platforms/pseries/rtas-fadump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/rtas-fadump.c b/arch/powerpc/platforms/pseries/rtas-fadump.c
index 81343908ed33..f8f73b47b107 100644
--- a/arch/powerpc/platforms/pseries/rtas-fadump.c
+++ b/arch/powerpc/platforms/pseries/rtas-fadump.c
@@ -247,7 +247,7 @@ static inline int rtas_fadump_gpr_index(u64 id)
return i;
}
-void rtas_fadump_set_regval(struct pt_regs *regs, u64 reg_id, u64 reg_val)
+static void rtas_fadump_set_regval(struct pt_regs *regs, u64 reg_id, u64 reg_val)
{
int i;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
@ 2021-04-08 6:20 ` Pu Lehui
0 siblings, 0 replies; 4+ messages in thread
From: Pu Lehui @ 2021-04-08 6:20 UTC (permalink / raw)
To: mpe, benh, paulus, joel, christophe.leroy
Cc: zhangjinhao2, yangjihong1, linuxppc-dev, linux-kernel, pulehui
Fix sparse warnings:
arch/powerpc/platforms/pseries/rtas-fadump.c:250:6: warning:
symbol 'rtas_fadump_set_regval' was not declared. Should it be static?
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
arch/powerpc/platforms/pseries/rtas-fadump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/rtas-fadump.c b/arch/powerpc/platforms/pseries/rtas-fadump.c
index 81343908ed33..f8f73b47b107 100644
--- a/arch/powerpc/platforms/pseries/rtas-fadump.c
+++ b/arch/powerpc/platforms/pseries/rtas-fadump.c
@@ -247,7 +247,7 @@ static inline int rtas_fadump_gpr_index(u64 id)
return i;
}
-void rtas_fadump_set_regval(struct pt_regs *regs, u64 reg_id, u64 reg_val)
+static void rtas_fadump_set_regval(struct pt_regs *regs, u64 reg_id, u64 reg_val)
{
int i;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
2021-04-08 6:20 ` Pu Lehui
@ 2021-04-19 4:00 ` Michael Ellerman
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-04-19 4:00 UTC (permalink / raw)
To: benh, mpe, christophe.leroy, joel, paulus, Pu Lehui
Cc: yangjihong1, zhangjinhao2, linuxppc-dev, linux-kernel
On Thu, 8 Apr 2021 14:20:12 +0800, Pu Lehui wrote:
> Fix sparse warnings:
>
> arch/powerpc/platforms/pseries/rtas-fadump.c:250:6: warning:
> symbol 'rtas_fadump_set_regval' was not declared. Should it be static?
Applied to powerpc/next.
[1/1] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
https://git.kernel.org/powerpc/c/59fd366b9bef2d048af763e27cd1622ee5a1dfd4
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
@ 2021-04-19 4:00 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-04-19 4:00 UTC (permalink / raw)
To: benh, mpe, christophe.leroy, joel, paulus, Pu Lehui
Cc: zhangjinhao2, yangjihong1, linuxppc-dev, linux-kernel
On Thu, 8 Apr 2021 14:20:12 +0800, Pu Lehui wrote:
> Fix sparse warnings:
>
> arch/powerpc/platforms/pseries/rtas-fadump.c:250:6: warning:
> symbol 'rtas_fadump_set_regval' was not declared. Should it be static?
Applied to powerpc/next.
[1/1] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static
https://git.kernel.org/powerpc/c/59fd366b9bef2d048af763e27cd1622ee5a1dfd4
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-19 4:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 6:20 [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static Pu Lehui
2021-04-08 6:20 ` Pu Lehui
2021-04-19 4:00 ` Michael Ellerman
2021-04-19 4:00 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.