From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: parav@nvidia.com, elic@nvidia.com Subject: [RFC PATCH] vdpa: mandate 1.0 device Date: Thu, 8 Apr 2021 16:26:48 +0800 [thread overview] Message-ID: <20210408082648.20145-1-jasowang@redhat.com> (raw) This patch mandates 1.0 for vDPA devices. The goal is to have the semantic of normative statement in the virtio spec and eliminate the burden of transitional device for both vDPA bus and vDPA parent. uAPI seems fine since all the vDPA parent mandates VIRTIO_F_ACCESS_PLATFORM which implies 1.0 devices. For legacy guests, it can still work since Qemu will mediate when necessary (e.g doing the endian conversion). Signed-off-by: Jason Wang <jasowang@redhat.com> --- include/linux/vdpa.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 0fefeb976877..cfde4ec999b4 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -6,6 +6,7 @@ #include <linux/device.h> #include <linux/interrupt.h> #include <linux/vhost_iotlb.h> +#include <uapi/linux/virtio_config.h> /** * vDPA callback definition. @@ -317,6 +318,11 @@ static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) { const struct vdpa_config_ops *ops = vdev->config; + /* Mandating 1.0 to have semantics of normative statements in + * the spec. */ + if (!(features & BIT_ULL(VIRTIO_F_VERSION_1))) + return -EINVAL; + vdev->features_valid = true; return ops->set_features(vdev, features); } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: elic@nvidia.com Subject: [RFC PATCH] vdpa: mandate 1.0 device Date: Thu, 8 Apr 2021 16:26:48 +0800 [thread overview] Message-ID: <20210408082648.20145-1-jasowang@redhat.com> (raw) This patch mandates 1.0 for vDPA devices. The goal is to have the semantic of normative statement in the virtio spec and eliminate the burden of transitional device for both vDPA bus and vDPA parent. uAPI seems fine since all the vDPA parent mandates VIRTIO_F_ACCESS_PLATFORM which implies 1.0 devices. For legacy guests, it can still work since Qemu will mediate when necessary (e.g doing the endian conversion). Signed-off-by: Jason Wang <jasowang@redhat.com> --- include/linux/vdpa.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 0fefeb976877..cfde4ec999b4 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -6,6 +6,7 @@ #include <linux/device.h> #include <linux/interrupt.h> #include <linux/vhost_iotlb.h> +#include <uapi/linux/virtio_config.h> /** * vDPA callback definition. @@ -317,6 +318,11 @@ static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) { const struct vdpa_config_ops *ops = vdev->config; + /* Mandating 1.0 to have semantics of normative statements in + * the spec. */ + if (!(features & BIT_ULL(VIRTIO_F_VERSION_1))) + return -EINVAL; + vdev->features_valid = true; return ops->set_features(vdev, features); } -- 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next reply other threads:[~2021-04-08 8:27 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 8:26 Jason Wang [this message] 2021-04-08 8:26 ` [RFC PATCH] vdpa: mandate 1.0 device Jason Wang 2021-04-08 15:59 ` Michael S. Tsirkin 2021-04-08 15:59 ` Michael S. Tsirkin 2021-04-09 4:47 ` Jason Wang 2021-04-09 4:47 ` Jason Wang 2021-04-09 16:04 ` Michael S. Tsirkin 2021-04-09 16:04 ` Michael S. Tsirkin 2021-04-12 6:35 ` Jason Wang 2021-04-12 6:35 ` Jason Wang 2021-04-12 9:09 ` Michael S. Tsirkin 2021-04-12 9:09 ` Michael S. Tsirkin 2021-04-12 9:23 ` Jason Wang 2021-04-12 9:23 ` Jason Wang 2021-04-21 7:41 ` Jason Wang 2021-04-21 7:41 ` Jason Wang 2021-04-21 8:03 ` Michael S. Tsirkin 2021-04-21 8:03 ` Michael S. Tsirkin 2021-04-21 8:17 ` Jason Wang 2021-04-21 8:17 ` Jason Wang 2021-05-11 8:43 ` Jason Wang 2021-05-11 8:43 ` Jason Wang 2021-05-12 7:53 ` Michael S. Tsirkin 2021-05-12 7:53 ` Michael S. Tsirkin 2021-05-12 9:24 ` Jason Wang 2021-05-12 9:24 ` Jason Wang 2021-06-02 10:30 ` Eli Cohen 2021-06-03 7:14 ` Jason Wang 2021-06-03 7:14 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210408082648.20145-1-jasowang@redhat.com \ --to=jasowang@redhat.com \ --cc=elic@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=parav@nvidia.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.