All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE
@ 2021-04-08 13:55 Chen Hui
  2021-04-08 20:30 ` Stephen Boyd
  2021-04-09  6:23 ` Manivannan Sadhasivam
  0 siblings, 2 replies; 4+ messages in thread
From: Chen Hui @ 2021-04-08 13:55 UTC (permalink / raw)
  To: agross, bjorn.andersson, mturquette, sboyd
  Cc: linux-arm-msm, linux-clk, linux-kernel

Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
as these drivers can be compiled as external modules.

Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
---
 drivers/clk/qcom/a53-pll.c      | 1 +
 drivers/clk/qcom/a7-pll.c       | 1 +
 drivers/clk/qcom/apss-ipq-pll.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
index 45cfc57bff92..af6ac17c7dae 100644
--- a/drivers/clk/qcom/a53-pll.c
+++ b/drivers/clk/qcom/a53-pll.c
@@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
 	{ .compatible = "qcom,msm8916-a53pll" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);
 
 static struct platform_driver qcom_a53pll_driver = {
 	.probe = qcom_a53pll_probe,
diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
index e171d3caf2cf..c4a53e5db229 100644
--- a/drivers/clk/qcom/a7-pll.c
+++ b/drivers/clk/qcom/a7-pll.c
@@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
 	{ .compatible = "qcom,sdx55-a7pll" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
 
 static struct platform_driver qcom_a7pll_driver = {
 	.probe = qcom_a7pll_probe,
diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
index 30be87fb222a..bef7899ad0d6 100644
--- a/drivers/clk/qcom/apss-ipq-pll.c
+++ b/drivers/clk/qcom/apss-ipq-pll.c
@@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
 	{ .compatible = "qcom,ipq6018-a53pll" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);
 
 static struct platform_driver apss_ipq_pll_driver = {
 	.probe = apss_ipq_pll_probe,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE
  2021-04-08 13:55 [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE Chen Hui
@ 2021-04-08 20:30 ` Stephen Boyd
  2021-04-09  1:48   ` Chenhui (clare)
  2021-04-09  6:23 ` Manivannan Sadhasivam
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2021-04-08 20:30 UTC (permalink / raw)
  To: Chen Hui, agross, bjorn.andersson, mturquette
  Cc: linux-arm-msm, linux-clk, linux-kernel

Quoting Chen Hui (2021-04-08 06:55:09)
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
> 
> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>

Any fixes tag?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE
  2021-04-08 20:30 ` Stephen Boyd
@ 2021-04-09  1:48   ` Chenhui (clare)
  0 siblings, 0 replies; 4+ messages in thread
From: Chenhui (clare) @ 2021-04-09  1:48 UTC (permalink / raw)
  To: Stephen Boyd, agross, bjorn.andersson, mturquette
  Cc: linux-arm-msm, linux-clk, linux-kernel

在 2021/4/9 4:30, Stephen Boyd 写道:

> Quoting Chen Hui (2021-04-08 06:55:09)
>> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
>> as these drivers can be compiled as external modules.
>>
>> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
> Any fixes tag?
> .

Thanks for reviewing, fixes tags will be added in v2 patches, which I 
will send out later


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE
  2021-04-08 13:55 [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE Chen Hui
  2021-04-08 20:30 ` Stephen Boyd
@ 2021-04-09  6:23 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-09  6:23 UTC (permalink / raw)
  To: Chen Hui
  Cc: agross, bjorn.andersson, mturquette, sboyd, linux-arm-msm,
	linux-clk, linux-kernel

On Thu, Apr 08, 2021 at 09:55:09PM +0800, Chen Hui wrote:
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
> 
> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/clk/qcom/a53-pll.c      | 1 +
>  drivers/clk/qcom/a7-pll.c       | 1 +
>  drivers/clk/qcom/apss-ipq-pll.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 45cfc57bff92..af6ac17c7dae 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
>  	{ .compatible = "qcom,msm8916-a53pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);
>  
>  static struct platform_driver qcom_a53pll_driver = {
>  	.probe = qcom_a53pll_probe,
> diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
> index e171d3caf2cf..c4a53e5db229 100644
> --- a/drivers/clk/qcom/a7-pll.c
> +++ b/drivers/clk/qcom/a7-pll.c
> @@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
>  	{ .compatible = "qcom,sdx55-a7pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
>  
>  static struct platform_driver qcom_a7pll_driver = {
>  	.probe = qcom_a7pll_probe,
> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
> index 30be87fb222a..bef7899ad0d6 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
> @@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
>  	{ .compatible = "qcom,ipq6018-a53pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);
>  
>  static struct platform_driver apss_ipq_pll_driver = {
>  	.probe = apss_ipq_pll_probe,
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-09  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 13:55 [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE Chen Hui
2021-04-08 20:30 ` Stephen Boyd
2021-04-09  1:48   ` Chenhui (clare)
2021-04-09  6:23 ` Manivannan Sadhasivam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.