All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()
@ 2021-04-09  7:52 Ye Bin
  2021-04-27 19:44 ` [thermal: thermal/next] " thermal-bot for Ye Bin
  0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2021-04-09  7:52 UTC (permalink / raw)
  To: yebin10, Zhang Rui, Daniel Lezcano; +Cc: linux-pm, kernel-janitors, Hulk Robot

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/thermal/hisi_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index d902db9f267f..9a21ac0ceb11 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -572,10 +572,8 @@ static int hisi_thermal_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	data->regs = devm_ioremap_resource(dev, res);
-	if (IS_ERR(data->regs)) {
-		dev_err(dev, "failed to get io address\n");
+	if (IS_ERR(data->regs))
 		return PTR_ERR(data->regs);
-	}
 
 	ret = data->ops->probe(data);
 	if (ret)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [thermal: thermal/next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()
  2021-04-09  7:52 [PATCH -next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe() Ye Bin
@ 2021-04-27 19:44 ` thermal-bot for Ye Bin
  0 siblings, 0 replies; 2+ messages in thread
From: thermal-bot for Ye Bin @ 2021-04-27 19:44 UTC (permalink / raw)
  To: linux-pm; +Cc: Hulk Robot, Ye Bin, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     beaa41029fdea9d3e01af3a1a800538542d30869
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//beaa41029fdea9d3e01af3a1a800538542d30869
Author:        Ye Bin <yebin10@huawei.com>
AuthorDate:    Fri, 09 Apr 2021 15:52:24 +08:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 20 Apr 2021 09:18:57 +02:00

thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210409075224.2109503-1-yebin10@huawei.com
---
 drivers/thermal/hisi_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index d902db9..9a21ac0 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -572,10 +572,8 @@ static int hisi_thermal_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	data->regs = devm_ioremap_resource(dev, res);
-	if (IS_ERR(data->regs)) {
-		dev_err(dev, "failed to get io address\n");
+	if (IS_ERR(data->regs))
 		return PTR_ERR(data->regs);
-	}
 
 	ret = data->ops->probe(data);
 	if (ret)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-27 19:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09  7:52 [PATCH -next] thermal/drivers/hisi: Remove redundant dev_err call in hisi_thermal_probe() Ye Bin
2021-04-27 19:44 ` [thermal: thermal/next] " thermal-bot for Ye Bin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.