All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/4] arm64: Implement infrastructure for stack trace reliability checks
Date: Fri, 9 Apr 2021 12:57:08 +0100	[thread overview]
Message-ID: <20210409115708.GB4499@sirena.org.uk> (raw)
In-Reply-To: <eb905f70-a963-6257-c597-89e008675539@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

On Thu, Apr 08, 2021 at 06:30:22PM -0500, Madhavan T. Venkataraman wrote:
> On 4/8/21 2:30 PM, Madhavan T. Venkataraman wrote:

> > 1. Create a common section (I will have to come up with an appropriate name) and put
> >    all such functions in that one section.

> > 2. Create one section for each logical type (exception section, ftrace section and
> >    kprobe section) or some such.

> For now, I will start with idea 2. I will create a special section for each class of
> functions (EL1 exception handlers, FTRACE trampolines, KPROBE trampolines). Instead of a
> special functions array, I will implement a special_sections array. The rest of the code
> should just fall into place.

> Let me know if you prefer something different.

It might be safer to start off by just putting all SYM_CODE into a
section then pulling bits we know to be safe out of the section as
needed - we know that anything that's SYM_CODE is doing something
non-standard and needs checking to verify that the unwinder will be
happy with it and I that should cover most if not all of the cases above
as well as anything else we didn't explicitly think of.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/4] arm64: Implement infrastructure for stack trace reliability checks
Date: Fri, 9 Apr 2021 12:57:08 +0100	[thread overview]
Message-ID: <20210409115708.GB4499@sirena.org.uk> (raw)
In-Reply-To: <eb905f70-a963-6257-c597-89e008675539@linux.microsoft.com>


[-- Attachment #1.1: Type: text/plain, Size: 1138 bytes --]

On Thu, Apr 08, 2021 at 06:30:22PM -0500, Madhavan T. Venkataraman wrote:
> On 4/8/21 2:30 PM, Madhavan T. Venkataraman wrote:

> > 1. Create a common section (I will have to come up with an appropriate name) and put
> >    all such functions in that one section.

> > 2. Create one section for each logical type (exception section, ftrace section and
> >    kprobe section) or some such.

> For now, I will start with idea 2. I will create a special section for each class of
> functions (EL1 exception handlers, FTRACE trampolines, KPROBE trampolines). Instead of a
> special functions array, I will implement a special_sections array. The rest of the code
> should just fall into place.

> Let me know if you prefer something different.

It might be safer to start off by just putting all SYM_CODE into a
section then pulling bits we know to be safe out of the section as
needed - we know that anything that's SYM_CODE is doing something
non-standard and needs checking to verify that the unwinder will be
happy with it and I that should cover most if not all of the cases above
as well as anything else we didn't explicitly think of.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-09 11:57 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <705993ccb34a611c75cdae0a8cb1b40f9b218ebd>
2021-04-05 20:43 ` [RFC PATCH v2 0/4] arm64: Implement stack trace reliability checks madvenka
2021-04-05 20:43   ` madvenka
2021-04-05 20:43   ` [RFC PATCH v2 1/4] arm64: Implement infrastructure for " madvenka
2021-04-05 20:43     ` madvenka
2021-04-08 15:15     ` Mark Brown
2021-04-08 15:15       ` Mark Brown
2021-04-08 17:17     ` Mark Brown
2021-04-08 17:17       ` Mark Brown
2021-04-08 19:30       ` Madhavan T. Venkataraman
2021-04-08 19:30         ` Madhavan T. Venkataraman
2021-04-08 23:30         ` Madhavan T. Venkataraman
2021-04-08 23:30           ` Madhavan T. Venkataraman
2021-04-09 11:57           ` Mark Brown [this message]
2021-04-09 11:57             ` Mark Brown
2021-04-05 20:43   ` [RFC PATCH v2 2/4] arm64: Mark a stack trace unreliable if an EL1 exception frame is detected madvenka
2021-04-05 20:43     ` madvenka
2021-04-05 20:43   ` [RFC PATCH v2 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable madvenka
2021-04-05 20:43     ` madvenka
2021-04-08 16:58     ` Mark Brown
2021-04-08 16:58       ` Mark Brown
2021-04-08 19:23       ` Madhavan T. Venkataraman
2021-04-08 19:23         ` Madhavan T. Venkataraman
2021-04-09 11:31         ` Mark Brown
2021-04-09 11:31           ` Mark Brown
2021-04-09 14:02           ` Madhavan T. Venkataraman
2021-04-09 14:02             ` Madhavan T. Venkataraman
2021-04-09 12:27     ` Mark Rutland
2021-04-09 12:27       ` Mark Rutland
2021-04-09 17:23       ` Madhavan T. Venkataraman
2021-04-09 17:23         ` Madhavan T. Venkataraman
2021-04-05 20:43   ` [RFC PATCH v2 4/4] arm64: Mark stack trace as unreliable if kretprobed functions are present madvenka
2021-04-05 20:43     ` madvenka
2021-04-09 12:09   ` [RFC PATCH v2 0/4] arm64: Implement stack trace reliability checks Mark Rutland
2021-04-09 12:09     ` Mark Rutland
2021-04-09 17:16     ` Madhavan T. Venkataraman
2021-04-09 17:16       ` Madhavan T. Venkataraman
2021-04-09 21:37     ` Josh Poimboeuf
2021-04-09 21:37       ` Josh Poimboeuf
2021-04-09 22:05       ` Madhavan T. Venkataraman
2021-04-09 22:05         ` Madhavan T. Venkataraman
2021-04-09 22:32         ` Josh Poimboeuf
2021-04-09 22:32           ` Josh Poimboeuf
2021-04-09 22:53           ` Josh Poimboeuf
2021-04-09 22:53             ` Josh Poimboeuf
2021-04-11 17:54             ` Madhavan T. Venkataraman
2021-04-11 17:54               ` Madhavan T. Venkataraman
2021-04-12 16:59           ` Mark Brown
2021-04-12 16:59             ` Mark Brown
2021-04-13 22:53             ` Josh Poimboeuf
2021-04-13 22:53               ` Josh Poimboeuf
2021-04-14 12:24               ` Mark Brown
2021-04-14 12:24                 ` Mark Brown
2021-04-12 17:36       ` Mark Brown
2021-04-12 17:36         ` Mark Brown
2021-04-12 19:55         ` Madhavan T. Venkataraman
2021-04-12 19:55           ` Madhavan T. Venkataraman
2021-04-13 11:02           ` Mark Brown
2021-04-13 11:02             ` Mark Brown
2021-04-14 10:23             ` Madhavan T. Venkataraman
2021-04-14 10:23               ` Madhavan T. Venkataraman
2021-04-14 12:35               ` Mark Brown
2021-04-14 12:35                 ` Mark Brown
2021-04-16 14:43               ` Madhavan T. Venkataraman
2021-04-16 14:43                 ` Madhavan T. Venkataraman
2021-04-16 15:36                 ` Mark Brown
2021-04-16 15:36                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409115708.GB4499@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=jpoimboe@redhat.com \
    --cc=jthierry@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=madvenka@linux.microsoft.com \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.