Re: [PATCH v3 2/3] drm/msm/dpu: add support to dump dpu registers

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3727 bytes --]

Hi Abhinav,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc6 next-20210408]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Abhinav-Kumar/Add-devcoredump-support-for-DPU/20210409-103135
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8ea10a48ffac0ff4eeda3e65ed93d8e5c2f0d4d4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Abhinav-Kumar/Add-devcoredump-support-for-DPU/20210409-103135
        git checkout 8ea10a48ffac0ff4eeda3e65ed93d8e5c2f0d4d4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_dbg_util.c: In function 'dpu_dbg_free_blk_mem':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_dbg_util.c:183:21: warning: variable 'top' set but not used [-Wunused-but-set-variable]
     183 |  struct dpu_hw_mdp *top;
         |                     ^~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_dbg_util.c: In function 'dpu_dbg_init_blk_info':
   drivers/gpu/drm/msm/disp/dpu1/dpu_dbg_util.c:230:21: warning: variable 'top' set but not used [-Wunused-but-set-variable]
     230 |  struct dpu_hw_mdp *top;
         |                     ^~~


vim +/top +183 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg_util.c

   177	
   178	void dpu_dbg_free_blk_mem(struct drm_device *drm_dev)
   179	{
   180		struct msm_drm_private *priv;
   181		struct dpu_kms *dpu_kms;
   182		struct dpu_mdss_cfg *cat;
 > 183		struct dpu_hw_mdp *top;
   184		struct dpu_dbg_base *dpu_dbg;
   185		int i;
   186	
   187		priv = drm_dev->dev_private;
   188		dpu_kms = to_dpu_kms(priv->kms);
   189		dpu_dbg = dpu_kms->dpu_dbg;
   190	
   191		cat = dpu_kms->catalog;
   192		top = dpu_kms->hw_mdp;
   193	
   194		/* free CTL sub-blocks mem */
   195		for (i = 0; i < cat->ctl_count; i++)
   196			kfree(dpu_dbg->mdp_regs->ctl[i]);
   197	
   198		/* free DSPP sub-blocks mem */
   199		for (i = 0; i < cat->dspp_count; i++)
   200			kfree(dpu_dbg->mdp_regs->dspp[i]);
   201	
   202		/* free INTF sub-blocks mem */
   203		for (i = 0; i < cat->intf_count; i++)
   204			kfree(dpu_dbg->mdp_regs->intf[i]);
   205	
   206		/* free INTF sub-blocks mem */
   207		for (i = 0; i < cat->pingpong_count; i++)
   208			kfree(dpu_dbg->mdp_regs->pp[i]);
   209	
   210		/* free SSPP sub-blocks mem */
   211		for (i = 0; i < cat->sspp_count; i++)
   212			kfree(dpu_dbg->mdp_regs->sspp[i]);
   213	
   214		/* free TOP sub-blocks mem */
   215		kfree(dpu_dbg->mdp_regs->top);
   216	
   217		/* free DSI regs mem */
   218		for (i = 0; i < ARRAY_SIZE(priv->dsi); i++)
   219			kfree(dpu_dbg->dsi_ctrl_regs[i]);
   220	
   221		/* free DP regs mem */
   222		kfree(dpu_dbg->dp_ctrl_regs);
   223	}
   224	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54383 bytes --]