* [bvanassche:scsi-status 19/25] drivers/s390/scsi/zfcp_dbf.c:646:22: error: incompatible types when assigning to type 'u32' {aka 'unsigned int'} from type 'struct scsi_status'
@ 2021-04-10 9:43 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-10 9:43 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8951 bytes --]
tree: https://github.com/bvanassche/linux scsi-status
head: b6f3ee28c1d53a4e4fb9d871009e5cb465c3d824
commit: 3f653a0515e027eea27a386bad8ea1a2e85135c3 [19/25] Introduce struct scsi_status
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/bvanassche/linux/commit/3f653a0515e027eea27a386bad8ea1a2e85135c3
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche scsi-status
git checkout 3f653a0515e027eea27a386bad8ea1a2e85135c3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/s390/scsi/zfcp_dbf.c: In function 'zfcp_dbf_scsi_common':
>> drivers/s390/scsi/zfcp_dbf.c:646:22: error: incompatible types when assigning to type 'u32' {aka 'unsigned int'} from type 'struct scsi_status'
646 | rec->scsi_result = sc->result;
| ^~
--
drivers/s390/scsi/zfcp_fc.c: In function 'zfcp_fc_ct_els_job_handler':
>> drivers/s390/scsi/zfcp_fc.c:954:12: error: request for member 'combined' in something not a structure or union
954 | jr->result.combined = zfcp_ct_els->status ? -EIO : 0;
| ^
drivers/s390/scsi/zfcp_fc.c:955:30: error: request for member 'combined' in something not a structure or union
955 | bsg_job_done(job, jr->result.combined, jr->reply_payload_rcv_len);
| ^
vim +646 drivers/s390/scsi/zfcp_dbf.c
8a36e4532ea104 Maxim Shchetynin 2005-09-13 620
250a1352b95e1d Swen Schillig 2010-12-02 621 /**
8221211863750b Steffen Maier 2018-05-17 622 * zfcp_dbf_scsi_common() - Common trace event helper for scsi.
8221211863750b Steffen Maier 2018-05-17 623 * @tag: Identifier for event.
8221211863750b Steffen Maier 2018-05-17 624 * @level: trace level of event.
8221211863750b Steffen Maier 2018-05-17 625 * @sdev: Pointer to SCSI device as context for this event.
8221211863750b Steffen Maier 2018-05-17 626 * @sc: Pointer to SCSI command, or NULL with task management function (TMF).
8221211863750b Steffen Maier 2018-05-17 627 * @fsf: Pointer to FSF request, or NULL.
250a1352b95e1d Swen Schillig 2010-12-02 628 */
8221211863750b Steffen Maier 2018-05-17 629 void zfcp_dbf_scsi_common(char *tag, int level, struct scsi_device *sdev,
8221211863750b Steffen Maier 2018-05-17 630 struct scsi_cmnd *sc, struct zfcp_fsf_req *fsf)
8a36e4532ea104 Maxim Shchetynin 2005-09-13 631 {
250a1352b95e1d Swen Schillig 2010-12-02 632 struct zfcp_adapter *adapter =
8221211863750b Steffen Maier 2018-05-17 633 (struct zfcp_adapter *) sdev->host->hostdata[0];
250a1352b95e1d Swen Schillig 2010-12-02 634 struct zfcp_dbf *dbf = adapter->dbf;
250a1352b95e1d Swen Schillig 2010-12-02 635 struct zfcp_dbf_scsi *rec = &dbf->scsi_buf;
4318e08c84e491 Christof Schmitt 2009-11-24 636 struct fcp_resp_with_ext *fcp_rsp;
250a1352b95e1d Swen Schillig 2010-12-02 637 struct fcp_resp_rsp_info *fcp_rsp_info;
250a1352b95e1d Swen Schillig 2010-12-02 638 unsigned long flags;
8a36e4532ea104 Maxim Shchetynin 2005-09-13 639
5771710bd5edfa Swen Schillig 2009-08-18 640 spin_lock_irqsave(&dbf->scsi_lock, flags);
6bc473dd324237 Martin Peschke 2008-03-31 641 memset(rec, 0, sizeof(*rec));
8a36e4532ea104 Maxim Shchetynin 2005-09-13 642
250a1352b95e1d Swen Schillig 2010-12-02 643 memcpy(rec->tag, tag, ZFCP_DBF_TAG_LEN);
250a1352b95e1d Swen Schillig 2010-12-02 644 rec->id = ZFCP_DBF_SCSI_CMND;
8221211863750b Steffen Maier 2018-05-17 645 if (sc) {
250a1352b95e1d Swen Schillig 2010-12-02 @646 rec->scsi_result = sc->result;
250a1352b95e1d Swen Schillig 2010-12-02 647 rec->scsi_retries = sc->retries;
250a1352b95e1d Swen Schillig 2010-12-02 648 rec->scsi_allowed = sc->allowed;
250a1352b95e1d Swen Schillig 2010-12-02 649 rec->scsi_id = sc->device->id;
9cb78c16f5dade Hannes Reinecke 2014-06-25 650 rec->scsi_lun = (u32)sc->device->lun;
5d4a3d0a2ff237 Steffen Maier 2017-07-28 651 rec->scsi_lun_64_hi = (u32)(sc->device->lun >> 32);
250a1352b95e1d Swen Schillig 2010-12-02 652 rec->host_scribble = (unsigned long)sc->host_scribble;
250a1352b95e1d Swen Schillig 2010-12-02 653
250a1352b95e1d Swen Schillig 2010-12-02 654 memcpy(rec->scsi_opcode, sc->cmnd,
8221211863750b Steffen Maier 2018-05-17 655 min_t(int, sc->cmd_len, ZFCP_DBF_SCSI_OPCODE));
8221211863750b Steffen Maier 2018-05-17 656 } else {
8221211863750b Steffen Maier 2018-05-17 657 rec->scsi_result = ~0;
8221211863750b Steffen Maier 2018-05-17 658 rec->scsi_retries = ~0;
8221211863750b Steffen Maier 2018-05-17 659 rec->scsi_allowed = ~0;
8221211863750b Steffen Maier 2018-05-17 660 rec->scsi_id = sdev->id;
8221211863750b Steffen Maier 2018-05-17 661 rec->scsi_lun = (u32)sdev->lun;
8221211863750b Steffen Maier 2018-05-17 662 rec->scsi_lun_64_hi = (u32)(sdev->lun >> 32);
8221211863750b Steffen Maier 2018-05-17 663 rec->host_scribble = ~0;
8221211863750b Steffen Maier 2018-05-17 664
8221211863750b Steffen Maier 2018-05-17 665 memset(rec->scsi_opcode, 0xff, ZFCP_DBF_SCSI_OPCODE);
8221211863750b Steffen Maier 2018-05-17 666 }
250a1352b95e1d Swen Schillig 2010-12-02 667
250a1352b95e1d Swen Schillig 2010-12-02 668 if (fsf) {
250a1352b95e1d Swen Schillig 2010-12-02 669 rec->fsf_req_id = fsf->req_id;
12c3e5754c8022 Steffen Maier 2017-07-28 670 rec->pl_len = FCP_RESP_WITH_EXT;
df00d7b8d5533a Steffen Maier 2017-07-28 671 fcp_rsp = &(fsf->qtcb->bottom.io.fcp_rsp.iu);
12c3e5754c8022 Steffen Maier 2017-07-28 672 /* mandatory parts of FCP_RSP IU in this SCSI record */
250a1352b95e1d Swen Schillig 2010-12-02 673 memcpy(&rec->fcp_rsp, fcp_rsp, FCP_RESP_WITH_EXT);
250a1352b95e1d Swen Schillig 2010-12-02 674 if (fcp_rsp->resp.fr_flags & FCP_RSP_LEN_VAL) {
250a1352b95e1d Swen Schillig 2010-12-02 675 fcp_rsp_info = (struct fcp_resp_rsp_info *) &fcp_rsp[1];
250a1352b95e1d Swen Schillig 2010-12-02 676 rec->fcp_rsp_info = fcp_rsp_info->rsp_code;
12c3e5754c8022 Steffen Maier 2017-07-28 677 rec->pl_len += be32_to_cpu(fcp_rsp->ext.fr_rsp_len);
8a36e4532ea104 Maxim Shchetynin 2005-09-13 678 }
250a1352b95e1d Swen Schillig 2010-12-02 679 if (fcp_rsp->resp.fr_flags & FCP_SNS_LEN_VAL) {
12c3e5754c8022 Steffen Maier 2017-07-28 680 rec->pl_len += be32_to_cpu(fcp_rsp->ext.fr_sns_len);
8a36e4532ea104 Maxim Shchetynin 2005-09-13 681 }
12c3e5754c8022 Steffen Maier 2017-07-28 682 /* complete FCP_RSP IU in associated PAYload record
12c3e5754c8022 Steffen Maier 2017-07-28 683 * but only if there are optional parts
12c3e5754c8022 Steffen Maier 2017-07-28 684 */
12c3e5754c8022 Steffen Maier 2017-07-28 685 if (fcp_rsp->resp.fr_flags != 0)
12c3e5754c8022 Steffen Maier 2017-07-28 686 zfcp_dbf_pl_write(
12c3e5754c8022 Steffen Maier 2017-07-28 687 dbf, fcp_rsp,
12c3e5754c8022 Steffen Maier 2017-07-28 688 /* at least one full PAY record
12c3e5754c8022 Steffen Maier 2017-07-28 689 * but not beyond hardware response field
12c3e5754c8022 Steffen Maier 2017-07-28 690 */
12c3e5754c8022 Steffen Maier 2017-07-28 691 min_t(u16, max_t(u16, rec->pl_len,
12c3e5754c8022 Steffen Maier 2017-07-28 692 ZFCP_DBF_PAY_MAX_REC),
12c3e5754c8022 Steffen Maier 2017-07-28 693 FSF_FCP_RSP_SIZE),
12c3e5754c8022 Steffen Maier 2017-07-28 694 "fcp_riu", fsf->req_id);
8a36e4532ea104 Maxim Shchetynin 2005-09-13 695 }
8a36e4532ea104 Maxim Shchetynin 2005-09-13 696
35f040df97fa0e Steffen Maier 2016-08-10 697 debug_event(dbf->scsi, level, rec, sizeof(*rec));
250a1352b95e1d Swen Schillig 2010-12-02 698 spin_unlock_irqrestore(&dbf->scsi_lock, flags);
8a36e4532ea104 Maxim Shchetynin 2005-09-13 699 }
8a36e4532ea104 Maxim Shchetynin 2005-09-13 700
:::::: The code at line 646 was first introduced by commit
:::::: 250a1352b95e1db3216e5c5d4f4365bea5122f4a [SCSI] zfcp: Redesign of the debug tracing for SCSI records.
:::::: TO: Swen Schillig <swen@vnet.ibm.com>
:::::: CC: James Bottomley <James.Bottomley@suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52319 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-10 9:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10 9:43 [bvanassche:scsi-status 19/25] drivers/s390/scsi/zfcp_dbf.c:646:22: error: incompatible types when assigning to type 'u32' {aka 'unsigned int'} from type 'struct scsi_status' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.