* UBI issues with linux-stable 5.11.11
@ 2021-04-07 19:03 Trevor Woerner
2021-04-07 20:23 ` Trevor Woerner
0 siblings, 1 reply; 9+ messages in thread
From: Trevor Woerner @ 2021-04-07 19:03 UTC (permalink / raw)
To: linux-mtd
Hi,
I've been testing out some newer kernels on my lpc32xx board and found some
issues. My current stable build is running 5.0.19 and it is fine, and I have a
test build running 5.4.78 and it runs fine too.
My board has an S34ML04G1 SLC NAND:
nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
nand: AMD/Spansion S34ML04G1
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
The SLC portion of my device tree looks like:
/* 512MB Flash via SLC NAND controller */
&slc {
status = "okay";
nxp,wdr-clks = <14>;
nxp,wwidth = <70250000>;
nxp,whold = <281000000>;
nxp,wsetup = <100000000>;
nxp,rdr-clks = <14>;
nxp,rwidth = <93666666>;
nxp,rhold = <281000000>;
nxp,rsetup = <100000000>;
nand-on-flash-bbt;
gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
mtd0@0 { label = "bootrom"; reg = <0x00000000 0x00020000>; };
mtd1@20000 { label = "uboot"; reg = <0x00020000 0x00060000>; };
mtd2@80000 { label = "fbkernel"; reg = <0x00080000 0x003c0000>; };
mtd3@440000 { label = "fbrootfs"; reg = <0x00440000 0x004e0000>; };
mtd4@920000 { label = "c_kernel"; reg = <0x00920000 0x003c0000>; };
mtd5@ce0000 { label = "c__atags"; reg = <0x00ce0000 0x00020000>; };
mtd6@d00000 { label = "c_rootfs"; reg = <0x00d00000 0x00300000>; };
mtd7@1000000 { label = "mender"; reg = <0x01000000 0x1f000000>; };
};
};
And my kernel parameters are:
ubi.mtd=7,512 rootfstype=ubifs root=ubi0
When running linux-stable 5.11.11 (aa7258f8f3d48a29bc024ea8c5145bdc4a980e4d
from branch linux-5.11.y) I get the following on bootup:
…
nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
nand: AMD/Spansion S34ML04G1
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
Bad block table found at page 262080, version 0x01
Bad block table found at page 262016, version 0x01
random: fast init done
nand_bbt: ECC error in BBT at 0x00001ffe0000
nand_bbt: ECC error in BBT at 0x00001ffc0000
Scanning device for bad blocks
Bad block table written to 0x00001ffe0000, version 0x01
Bad block table written to 0x00001ffc0000, version 0x01
8 fixed-partitions partitions found on MTD device nxp_lpc3220_slc
Creating 8 MTD partitions on "nxp_lpc3220_slc":
0x000000000000-0x000000020000 : "bootrom"
0x000000020000-0x000000080000 : "uboot"
0x000000080000-0x000000440000 : "fbkernel"
0x000000440000-0x000000920000 : "fbrootfs"
0x000000920000-0x000000ce0000 : "c_kernel"
0x000000ce0000-0x000000d00000 : "c__atags"
0x000000d00000-0x000001000000 : "c_rootfs"
0x000001000000-0x000020000000 : "mender"
…
ubi0: attaching mtd7
ubi0 warning: ubi_io_read: error -74 (ECC error) while reading 64 bytes from PEB 0:0, read only 64 bytes, retry
ubi0 warning: ubi_io_read: error -74 (ECC error) while reading 64 bytes from PEB 0:0, read only 64 bytes, retry
ubi0 warning: ubi_io_read: error -74 (ECC error) while reading 64 bytes from PEB 0:0, read only 64 bytes, retry
ubi0 error: ubi_io_read: error -74 (ECC error) while reading 64 bytes from PEB 0:0, read 64 bytes
CPU: 0 PID: 1 Comm: swapper Not tainted 5.11.11-yocto-standard #1
Hardware name: LPC32XX SoC (Flattened Device Tree)
[<c0011ac4>] (unwind_backtrace) from [<c00109c8>] (show_stack+0x10/0x14)
[<c00109c8>] (show_stack) from [<c0300e00>] (ubi_io_read+0x20c/0x2d8)
[<c0300e00>] (ubi_io_read) from [<c030110c>] (ubi_io_read_ec_hdr+0x68/0x20c)
[<c030110c>] (ubi_io_read_ec_hdr) from [<c03064dc>] (ubi_attach+0x2d8/0x11dc)
[<c03064dc>] (ubi_attach) from [<c02fb768>] (ubi_attach_mtd_dev+0x584/0xa10)
[<c02fb768>] (ubi_attach_mtd_dev) from [<c06bf730>] (ubi_init+0x1a8/0x214)
[<c06bf730>] (ubi_init) from [<c06a8f44>] (do_one_initcall+0x74/0x188)
[<c06a8f44>] (do_one_initcall) from [<c06a921c>] (kernel_init_freeable+0x170/0x1bc)
[<c06a921c>] (kernel_init_freeable) from [<c0557c54>] (kernel_init+0x8/0xf8)
[<c0557c54>] (kernel_init) from [<c0008528>] (ret_from_fork+0x14/0x2c)
Exception stack(0xc0825fb0 to 0xc0825ff8)
5fa0: 00000000 00000000 00000000 00000000
5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
…
The preceeding repeats over and over, the only difference being the PEB number
changing.
I found this which looks relevant: https://linux-sunxi.org/Mainline_NAND_Howto#Many_bad_blocks
I realize it's for a different SoC and NAND chip, but would it be worth
trying this procedure on my system?
Best regards,
Trevor
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with linux-stable 5.11.11
2021-04-07 19:03 UBI issues with linux-stable 5.11.11 Trevor Woerner
@ 2021-04-07 20:23 ` Trevor Woerner
2021-04-08 4:56 ` Alexander Dahl
2021-04-12 2:29 ` UBI issues with lpc32xx Was: UBI issues with 5.11.11 Trevor Woerner
0 siblings, 2 replies; 9+ messages in thread
From: Trevor Woerner @ 2021-04-07 20:23 UTC (permalink / raw)
To: linux-mtd
I forgot to note that my filesystem/flash/UBI works perfectly fine with
linux-stable kernels 5.0.19 to 5.10.27. The problem only shows up, suddenly,
when trying to use 5.11.11 (everything else being the same).
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with linux-stable 5.11.11
2021-04-07 20:23 ` Trevor Woerner
@ 2021-04-08 4:56 ` Alexander Dahl
2021-04-12 2:29 ` UBI issues with lpc32xx Was: UBI issues with 5.11.11 Trevor Woerner
1 sibling, 0 replies; 9+ messages in thread
From: Alexander Dahl @ 2021-04-08 4:56 UTC (permalink / raw)
To: Trevor Woerner; +Cc: linux-mtd
Hello Trevor,
Am Wed, Apr 07, 2021 at 04:23:56PM -0400 schrieb Trevor Woerner:
> I forgot to note that my filesystem/flash/UBI works perfectly fine with
> linux-stable kernels 5.0.19 to 5.10.27. The problem only shows up, suddenly,
> when trying to use 5.11.11 (everything else being the same).
I would try `git bisect` on this, probably with v5.10 as start and
master (or the last rc) as end point.
Greets
Alex
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-07 20:23 ` Trevor Woerner
2021-04-08 4:56 ` Alexander Dahl
@ 2021-04-12 2:29 ` Trevor Woerner
2021-04-12 16:02 ` Miquel Raynal
1 sibling, 1 reply; 9+ messages in thread
From: Trevor Woerner @ 2021-04-12 2:29 UTC (permalink / raw)
To: linux-mtd
Sorry for taking so long. Bisecting from 5.4.78 to 5.11.11 revealed a bunch of
different issues.
In my original email I jumped "to the end" of the stable releases and found an
issue with 5.11.11, but while bisecting I found things along the way.
Hopefully I've isolated the first problem. I also decided to bisect along the
Torvalds repository, hopefully that's the preferred way.
This is the issue, a NULL dereference:
Booting Linux on physical CPU 0x0
Linux version 5.10.0-rc6-yocto-standard (oe-user@oe-host) (arm-oe-linux-gnueabi-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.36.1.20210209) #1 PREEMPT Mon Apr 12 01:52:55 UTC 2021
CPU: ARM926EJ-S [41069264] revision 4 (ARMv5TEJ), cr=0005317f
…
nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
nand: AMD/Spansion S34ML04G1
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
8<--- cut here ---
Unable to handle kernel NULL pointer dereference at virtual address 00000018
pgd = (ptrval)
[00000018] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT ARM
CPU: 0 PID: 1 Comm: swapper Not tainted 5.10.0-rc6-yocto-standard #1
Hardware name: LPC32XX SoC (Flattened Device Tree)
PC is at nand_ecc_sw_hamming_correct+0x18/0x3c
LR is at lpc32xx_nand_read_page_syndrome+0xdc/0x130
pc : [<c02d376c>] lr : [<c02e048c>] psr: 20000053
sp : c0827b78 ip : c09d5820 fp : 00000000
r10: c0827ccc r9 : c02d3ef8 r8 : 00000000
r7 : c08e0828 r6 : c4850000 r5 : 00000000 r4 : c09d5820
r3 : 00000000 r2 : c0827b9c r1 : c08e0828 r0 : c4850000
Flags: nzCv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none
Control: 0005317f Table: 80004000 DAC: 00000053
Process swapper (pid: 1, stack limit = 0x(ptrval))
Stack: (0xc0827b78 to 0xc0828000)
7b60: c09d5820 c4850000
7b80: c08e0828 c02e048c 00000000 c0039480 c06c3760 00000028 00000018 ffffffff
7ba0: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff c072170c 0000000a
7bc0: c06fac40 c00095f8 00000001 c080f0e0 c080b000 00200140 ffff8b90 c06b7208
7be0: c0827c10 c09d5820 c4850800 c4850000 00000800 c4850000 c02e03b0 c02d4a14
7c00: 00000000 c004bb50 c0827ca0 00000000 0003ffc0 00000800 00000040 00000040
7c20: 00000000 00000000 0003ffc0 00000000 00000000 00000800 00000000 00000001
7c40: 00000001 00000000 c4850000 c09d58f8 00000000 00000000 00000000 00000000
7c60: 0003ffc0 c09d5820 00000000 c09d5820 c0827ccc 00000000 00000000 00000000
7c80: 1ffe0000 c02c58f0 c0827ccc c4850000 1ffe0000 c09d5820 c4850000 1ffe0000
7ca0: 00000000 00000800 c0827ccc 00000000 c070d484 c02db644 c0827ccc 00000dc0
7cc0: c4850000 c00bd1f4 000000dc 00000000 00000800 00000000 00000040 00000000
7ce0: 00000000 c4850000 c4850800 c06b7208 c070d458 c09d5820 00000fff 00000fff
7d00: c4850000 00000000 00000001 c02dc2cc 00000800 c070d458 00000001 00000000
7d20: ffffffff 00000001 20000000 c070d484 00000006 0000024f 00000000 c09d5820
7d40: 00000000 00000000 00000001 c4850000 000000dc c070d49c 000000dc c02dc7e0
7d60: 000000dc 00000001 c070d458 c00cfb20 c0a4d6c0 c09d5820 c02c4804 c09d5000
7d80: 00000000 c09d5820 00000000 00000000 00000001 00000001 000000dc 00000001
7da0: 000000dc c02da618 00000800 00000040 00000001 00000000 00000000 00000001
7dc0: 00000000 07bfa480 10bfb840 05953d6a c0616a89 c0616bc3 c062cf8f c062cf98
7de0: c062cf9b c062cfa7 c0707d38 c06b7208 c0707d4c c09d5820 00000000 c08fac10
7e00: c08fac00 07bfa480 10bfb840 05953d6a e101e101 c02e0b98 c0af2528 c0825b20
7e20: c0701a08 e100e001 10bfb840 042fee10 00000400 c06b7208 00000001 c08fac10
7e40: c070e1a8 00000000 c07430ec c070e1a8 00000000 c0653840 00000000 c02a0b98
7e60: c08fac10 00000000 00000000 c029f614 00000000 c08fac10 c070e1a8 c070bf18
7e80: c06aa838 c0721000 c0653840 c029fbb4 00000000 c08fac10 c070e1a8 c029fc78
7ea0: c08fac10 c070e1a8 c029fbcc c029dde0 c070bf18 c080f36c c0810230 c06b7208
7ec0: c070e1a8 c0a4d780 00000000 c029e52c c062e635 c062e63d 00000000 c070e1a8
7ee0: ffffe000 00000000 c0721000 c02a02a4 c0699e74 ffffe000 00000000 c0683efc
7f00: c08191ec c0618d51 00000000 c0032f00 00000001 c0653840 c06833d8 00000424
7f20: 00000006 00000006 00000000 0000041f 00000000 c08191d5 c08191dd c06b7208
7f40: 00000000 00000006 000000d4 c06b7208 c06aa854 00000007 000000d4 c08191a0
7f60: c06aa858 c06841d8 00000006 00000006 00000000 c06833d8 00000000 c06b32f8
7f80: 00000000 00000000 c053b81c 00000000 00000000 00000000 00000000 00000000
7fa0: 00000000 c053b824 00000000 c0008520 00000000 00000000 00000000 00000000
7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
[<c02d376c>] (nand_ecc_sw_hamming_correct) from [<c02e048c>] (lpc32xx_nand_read_page_syndrome+0xdc/0x130)
[<c02e048c>] (lpc32xx_nand_read_page_syndrome) from [<c02d4a14>] (nand_read_oob+0x3f0/0x610)
[<c02d4a14>] (nand_read_oob) from [<c02c58f0>] (mtd_read_oob+0xc8/0x138)
[<c02c58f0>] (mtd_read_oob) from [<c02db644>] (scan_read+0xcc/0x130)
[<c02db644>] (scan_read) from [<c02dc2cc>] (search_bbt+0x168/0x26c)
[<c02dc2cc>] (search_bbt) from [<c02dc7e0>] (nand_create_bbt+0x310/0x5c4)
[<c02dc7e0>] (nand_create_bbt) from [<c02da618>] (nand_scan_with_ids+0x1254/0x136c)
[<c02da618>] (nand_scan_with_ids) from [<c02e0b98>] (lpc32xx_nand_probe+0x530/0x600)
[<c02e0b98>] (lpc32xx_nand_probe) from [<c02a0b98>] (platform_drv_probe+0x38/0x6c)
[<c02a0b98>] (platform_drv_probe) from [<c029f614>] (really_probe+0x208/0x35c)
[<c029f614>] (really_probe) from [<c029fbb4>] (device_driver_attach+0x44/0x5c)
[<c029fbb4>] (device_driver_attach) from [<c029fc78>] (__driver_attach+0xac/0xb4)
[<c029fc78>] (__driver_attach) from [<c029dde0>] (bus_for_each_dev+0x64/0xa4)
[<c029dde0>] (bus_for_each_dev) from [<c029e52c>] (bus_add_driver+0x144/0x1a4)
[<c029e52c>] (bus_add_driver) from [<c02a02a4>] (driver_register+0xac/0xf0)
[<c02a02a4>] (driver_register) from [<c0683efc>] (do_one_initcall+0x74/0x194)
[<c0683efc>] (do_one_initcall) from [<c06841d8>] (kernel_init_freeable+0x168/0x1b4)
[<c06841d8>] (kernel_init_freeable) from [<c053b824>] (kernel_init+0x8/0xf8)
[<c053b824>] (kernel_init) from [<c0008520>] (ret_from_fork+0x14/0x34)
Exception stack(0xc0827fb0 to 0xc0827ff8)
7fa0: 00000000 00000000 00000000 00000000
7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
Code: e1a00001 e1a01002 e1a02003 e59c32b8 (e5933018)
---[ end trace 6305df6f8c1e3f00 ]---
Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---
Here's the commit via bisection:
$ git bisect bad
19b2ce184b9f404d6620adf667a9019e6abcae51 is the first bad commit
commit 19b2ce184b9f404d6620adf667a9019e6abcae51
Author: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed Sep 30 01:01:20 2020 +0200
mtd: nand: ecc-hamming: Stop using raw NAND structures
This code is meant to be reused by the SPI-NAND core. Now that the
driver has been cleaned and reorganized, use a generic ECC engine
object to store the driver's data instead of accessing members of the
nand_chip structure. This means adding proper init/cleanup helpers.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200929230124.31491-17-miquel.raynal@bootlin.com
drivers/mtd/nand/ecc-sw-hamming.c | 17 +++++----
drivers/mtd/nand/raw/nand_base.c | 63 +++++++++++++++++++++++++++++++--
include/linux/mtd/nand-ecc-sw-hamming.h | 20 +++++++++++
include/linux/mtd/rawnand.h | 2 ++
4 files changed, 90 insertions(+), 12 deletions(-)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-12 2:29 ` UBI issues with lpc32xx Was: UBI issues with 5.11.11 Trevor Woerner
@ 2021-04-12 16:02 ` Miquel Raynal
2021-04-12 18:05 ` Trevor Woerner
0 siblings, 1 reply; 9+ messages in thread
From: Miquel Raynal @ 2021-04-12 16:02 UTC (permalink / raw)
To: Trevor Woerner; +Cc: linux-mtd
Hi Trevor,
Trevor Woerner <twoerner@gmail.com> wrote on Sun, 11 Apr 2021 22:29:47
-0400:
> Sorry for taking so long. Bisecting from 5.4.78 to 5.11.11 revealed a bunch of
> different issues.
>
> In my original email I jumped "to the end" of the stable releases and found an
> issue with 5.11.11, but while bisecting I found things along the way.
> Hopefully I've isolated the first problem. I also decided to bisect along the
> Torvalds repository, hopefully that's the preferred way.
>
> This is the issue, a NULL dereference:
>
> Booting Linux on physical CPU 0x0
> Linux version 5.10.0-rc6-yocto-standard (oe-user@oe-host) (arm-oe-linux-gnueabi-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.36.1.20210209) #1 PREEMPT Mon Apr 12 01:52:55 UTC 2021
> CPU: ARM926EJ-S [41069264] revision 4 (ARMv5TEJ), cr=0005317f
> …
> nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
> nand: AMD/Spansion S34ML04G1
> nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
> 8<--- cut here ---
> Unable to handle kernel NULL pointer dereference at virtual address 00000018
> pgd = (ptrval)
> [00000018] *pgd=00000000
> Internal error: Oops: 5 [#1] PREEMPT ARM
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.10.0-rc6-yocto-standard #1
> Hardware name: LPC32XX SoC (Flattened Device Tree)
> PC is at nand_ecc_sw_hamming_correct+0x18/0x3c
> LR is at lpc32xx_nand_read_page_syndrome+0xdc/0x130
> pc : [<c02d376c>] lr : [<c02e048c>] psr: 20000053
> sp : c0827b78 ip : c09d5820 fp : 00000000
> r10: c0827ccc r9 : c02d3ef8 r8 : 00000000
> r7 : c08e0828 r6 : c4850000 r5 : 00000000 r4 : c09d5820
> r3 : 00000000 r2 : c0827b9c r1 : c08e0828 r0 : c4850000
> Flags: nzCv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none
> Control: 0005317f Table: 80004000 DAC: 00000053
> Process swapper (pid: 1, stack limit = 0x(ptrval))
> Stack: (0xc0827b78 to 0xc0828000)
> 7b60: c09d5820 c4850000
> 7b80: c08e0828 c02e048c 00000000 c0039480 c06c3760 00000028 00000018 ffffffff
> 7ba0: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff c072170c 0000000a
> 7bc0: c06fac40 c00095f8 00000001 c080f0e0 c080b000 00200140 ffff8b90 c06b7208
> 7be0: c0827c10 c09d5820 c4850800 c4850000 00000800 c4850000 c02e03b0 c02d4a14
> 7c00: 00000000 c004bb50 c0827ca0 00000000 0003ffc0 00000800 00000040 00000040
> 7c20: 00000000 00000000 0003ffc0 00000000 00000000 00000800 00000000 00000001
> 7c40: 00000001 00000000 c4850000 c09d58f8 00000000 00000000 00000000 00000000
> 7c60: 0003ffc0 c09d5820 00000000 c09d5820 c0827ccc 00000000 00000000 00000000
> 7c80: 1ffe0000 c02c58f0 c0827ccc c4850000 1ffe0000 c09d5820 c4850000 1ffe0000
> 7ca0: 00000000 00000800 c0827ccc 00000000 c070d484 c02db644 c0827ccc 00000dc0
> 7cc0: c4850000 c00bd1f4 000000dc 00000000 00000800 00000000 00000040 00000000
> 7ce0: 00000000 c4850000 c4850800 c06b7208 c070d458 c09d5820 00000fff 00000fff
> 7d00: c4850000 00000000 00000001 c02dc2cc 00000800 c070d458 00000001 00000000
> 7d20: ffffffff 00000001 20000000 c070d484 00000006 0000024f 00000000 c09d5820
> 7d40: 00000000 00000000 00000001 c4850000 000000dc c070d49c 000000dc c02dc7e0
> 7d60: 000000dc 00000001 c070d458 c00cfb20 c0a4d6c0 c09d5820 c02c4804 c09d5000
> 7d80: 00000000 c09d5820 00000000 00000000 00000001 00000001 000000dc 00000001
> 7da0: 000000dc c02da618 00000800 00000040 00000001 00000000 00000000 00000001
> 7dc0: 00000000 07bfa480 10bfb840 05953d6a c0616a89 c0616bc3 c062cf8f c062cf98
> 7de0: c062cf9b c062cfa7 c0707d38 c06b7208 c0707d4c c09d5820 00000000 c08fac10
> 7e00: c08fac00 07bfa480 10bfb840 05953d6a e101e101 c02e0b98 c0af2528 c0825b20
> 7e20: c0701a08 e100e001 10bfb840 042fee10 00000400 c06b7208 00000001 c08fac10
> 7e40: c070e1a8 00000000 c07430ec c070e1a8 00000000 c0653840 00000000 c02a0b98
> 7e60: c08fac10 00000000 00000000 c029f614 00000000 c08fac10 c070e1a8 c070bf18
> 7e80: c06aa838 c0721000 c0653840 c029fbb4 00000000 c08fac10 c070e1a8 c029fc78
> 7ea0: c08fac10 c070e1a8 c029fbcc c029dde0 c070bf18 c080f36c c0810230 c06b7208
> 7ec0: c070e1a8 c0a4d780 00000000 c029e52c c062e635 c062e63d 00000000 c070e1a8
> 7ee0: ffffe000 00000000 c0721000 c02a02a4 c0699e74 ffffe000 00000000 c0683efc
> 7f00: c08191ec c0618d51 00000000 c0032f00 00000001 c0653840 c06833d8 00000424
> 7f20: 00000006 00000006 00000000 0000041f 00000000 c08191d5 c08191dd c06b7208
> 7f40: 00000000 00000006 000000d4 c06b7208 c06aa854 00000007 000000d4 c08191a0
> 7f60: c06aa858 c06841d8 00000006 00000006 00000000 c06833d8 00000000 c06b32f8
> 7f80: 00000000 00000000 c053b81c 00000000 00000000 00000000 00000000 00000000
> 7fa0: 00000000 c053b824 00000000 c0008520 00000000 00000000 00000000 00000000
> 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
> [<c02d376c>] (nand_ecc_sw_hamming_correct) from [<c02e048c>] (lpc32xx_nand_read_page_syndrome+0xdc/0x130)
I assumed I understood this trace well enough to write a patch. Can you
please give this change a try?
If it does not fix your issue, would you mind tracing down the issue to
the root dereference that produces this panic?
Also please share your entire boot log in case there is anything else
interesting (and perhaps your NAND DT node as well).
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-12 16:02 ` Miquel Raynal
@ 2021-04-12 18:05 ` Trevor Woerner
2021-04-13 10:00 ` Miquel Raynal
0 siblings, 1 reply; 9+ messages in thread
From: Trevor Woerner @ 2021-04-12 18:05 UTC (permalink / raw)
To: Miquel Raynal; +Cc: linux-mtd
Hi Miquel,
On Mon 2021-04-12 @ 06:02:33 PM, Miquel Raynal wrote:
> I assumed I understood this trace well enough to write a patch. Can you
> please give this change a try?
>
> If it does not fix your issue, would you mind tracing down the issue to
> the root dereference that produces this panic?
It looks, to me, that your patch solves the NULL dereference problem. But it
reveals a new one "Driver must set ecc.strength when using hardware ECC". Is
that something I should be setting in my device tree, or is that a driver
issue too?
> Also please share your entire boot log in case there is anything else
> interesting (and perhaps your NAND DT node as well).
New boot log:
Booting Linux on physical CPU 0x0
Linux version 5.10.0-rc6-yocto-standard (oe-user@oe-host) (arm-oe-linux-gnueabi-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.36.1.20210209) #1 PREEMPT Mon Apr 12 17:49:12 UTC 2021
CPU: ARM926EJ-S [41069264] revision 4 (ARMv5TEJ), cr=0005317f
CPU: VIVT data cache, VIVT instruction cache
OF: fdt: Machine model: NAUTEL nape83 board based on NXP LPC3240
Memory policy: Data cache writeback
Zone ranges:
Normal [mem 0x0000000080000000-0x0000000083ffffff]
Movable zone start for each node
Early memory node ranges
node 0: [mem 0x0000000080000000-0x0000000083ffffff]
Initmem setup node 0 [mem 0x0000000080000000-0x0000000083ffffff]
Built 1 zonelists, mobility grouping on. Total pages: 16240
Kernel command line: ubi.mtd=7,512 rootfstype=ubifs root=ubi0 rootwait rw console=ttyS0,115200n81
Dentry cache hash table entries: 8192 (order: 3, 32768 bytes, linear)
Inode-cache hash table entries: 4096 (order: 2, 16384 bytes, linear)
mem auto-init: stack:off, heap alloc:off, heap free:off
Memory: 57312K/65536K available (5341K kernel code, 432K rwdata, 1108K rodata, 196K init, 206K bss, 8224K reserved, 0K cma-reserved)
rcu: Preemptible hierarchical RCU implementation.
Trampoline variant of Tasks RCU enabled.
rcu: RCU calculated value of scheduler-enlistment delay is 10 jiffies.
NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
random: get_random_bytes called from start_kernel+0x2bc/0x4d4 with crng_init=0
clk_pll_recalc_rate: hclk_pll: PLL clocks are not in valid ranges: 0/0/0
clocksource: lpc3220 timer: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 147020034397 ns
Switching to timer-based delay loop, resolution 76ns
sched_clock: 32 bits at 13MHz, resolution 76ns, wraps every 165191050201ns
Console: colour dummy device 80x30
Calibrating delay loop (skipped), value calculated using timer frequency.. 26.00 BogoMIPS (lpj=130000)
pid_max: default: 32768 minimum: 301
Mount-cache hash table entries: 1024 (order: 0, 4096 bytes, linear)
Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes, linear)
CPU: Testing write buffer coherency: ok
Setting up static identity map for 0x80008400 - 0x8000843c
rcu: Hierarchical SRCU implementation.
devtmpfs: initialized
VFP support v0.3: implementor 41 architecture 1 part 10 variant 9 rev 1
clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
futex hash table entries: 256 (order: -1, 3072 bytes, linear)
NET: Registered protocol family 16
DMA: preallocated 256 KiB pool for atomic coherent allocations
cpuidle: using governor menu
LPC32XX unique ID: 5565d99a09d8905d38df4d6190bb7480
pl08xdmac pl08xdmac: initialized 8 virtual memcpy channels
pl08xdmac pl08xdmac: initialized 2 virtual slave channels
pl08xdmac pl08xdmac: DMA: PL080 rev0 at 0x31000000 irq 21
SCSI subsystem initialized
usbcore: registered new interface driver usbfs
usbcore: registered new interface driver hub
usbcore: registered new device driver usb
Advanced Linux Sound Architecture Driver Initialized.
clocksource: Switched to clocksource lpc3220 timer
NET: Registered protocol family 2
tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 4096 bytes, linear)
TCP established hash table entries: 1024 (order: 0, 4096 bytes, linear)
TCP bind hash table entries: 1024 (order: 0, 4096 bytes, linear)
TCP: Hash tables configured (established 1024 bind 1024)
UDP hash table entries: 256 (order: 0, 4096 bytes, linear)
UDP-Lite hash table entries: 256 (order: 0, 4096 bytes, linear)
NET: Registered protocol family 1
RPC: Registered named UNIX socket transport module.
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
RPC: Registered tcp NFSv4.1 backchannel transport module.
workingset: timestamp_bits=14 max_order=14 bucket_order=0
NET: Registered protocol family 38
io scheduler mq-deadline registered
io scheduler kyber registered
Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
printk: console [ttyS0] disabled
40090000.serial: ttyS0 at MMIO 0x40090000 (irq = 24, base_baud = 812500) is a LPC3220
printk: console [ttyS0] enabled
40080000.serial: ttyS1 at MMIO 0x40080000 (irq = 25, base_baud = 812500) is a LPC3220
40088000.serial: ttyS2 at MMIO 0x40088000 (irq = 26, base_baud = 812500) is a LPC3220
40098000.serial: ttyS3 at MMIO 0x40098000 (irq = 27, base_baud = 812500) is a LPC3220
40014000.serial: ttyTX0 at MMIO 0x40014000 (irq = 30, base_baud = 812500) is a lpc32xx_hsuart
40018000.serial: ttyTX1 at MMIO 0x40018000 (irq = 31, base_baud = 812500) is a lpc32xx_hsuart
4001c000.serial: ttyTX2 at MMIO 0x4001c000 (irq = 32, base_baud = 812500) is a lpc32xx_hsuart
brd: module loaded
loop: module loaded
nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
nand: AMD/Spansion S34ML04G1
nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/nand_base.c:5781 nand_scan_with_ids+0xbf8/0x136c
Driver must set ecc.strength when using hardware ECC
CPU: 0 PID: 1 Comm: swapper Not tainted 5.10.0-rc6-yocto-standard #1
Hardware name: LPC32XX SoC (Flattened Device Tree)
[<c0011978>] (unwind_backtrace) from [<c00108a8>] (show_stack+0x10/0x14)
[<c00108a8>] (show_stack) from [<c0531950>] (__warn+0xa8/0xd0)
[<c0531950>] (__warn) from [<c05319f0>] (warn_slowpath_fmt+0x78/0xac)
[<c05319f0>] (warn_slowpath_fmt) from [<c02d9fbc>] (nand_scan_with_ids+0xbf8/0x136c)
[<c02d9fbc>] (nand_scan_with_ids) from [<c02e0bd4>] (lpc32xx_nand_probe+0x530/0x600)
[<c02e0bd4>] (lpc32xx_nand_probe) from [<c02a0b98>] (platform_drv_probe+0x38/0x6c)
[<c02a0b98>] (platform_drv_probe) from [<c029f614>] (really_probe+0x208/0x35c)
[<c029f614>] (really_probe) from [<c029fbb4>] (device_driver_attach+0x44/0x5c)
[<c029fbb4>] (device_driver_attach) from [<c029fc78>] (__driver_attach+0xac/0xb4)
[<c029fc78>] (__driver_attach) from [<c029dde0>] (bus_for_each_dev+0x64/0xa4)
[<c029dde0>] (bus_for_each_dev) from [<c029e52c>] (bus_add_driver+0x144/0x1a4)
[<c029e52c>] (bus_add_driver) from [<c02a02a4>] (driver_register+0xac/0xf0)
[<c02a02a4>] (driver_register) from [<c0683efc>] (do_one_initcall+0x74/0x194)
[<c0683efc>] (do_one_initcall) from [<c06841d8>] (kernel_init_freeable+0x168/0x1b4)
[<c06841d8>] (kernel_init_freeable) from [<c053b864>] (kernel_init+0x8/0xf8)
[<c053b864>] (kernel_init) from [<c0008520>] (ret_from_fork+0x14/0x34)
Exception stack(0xc0827fb0 to 0xc0827ff8)
7fa0: 00000000 00000000 00000000 00000000
7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
---[ end trace 81018977b459f36a ]---
lpc32xx-nand: probe of 20020000.flash failed with error -22
libphy: Fixed MDIO Bus: probed
ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
ohci-nxp: OHCI NXP driver
ISP1301 Vendor ID : 0x0483
ISP1301 Product ID : 0xa0c4
ISP1301 Version ID : 0x4747
usb-ohci 31020000.ohci: at 0x(ptrval), irq 0
random: fast init done
usb-ohci 31020000.ohci: OHCI Host Controller
usb-ohci 31020000.ohci: new USB bus registered, assigned bus number 1
usb-ohci 31020000.ohci: irq 22, io mem 0x31020000
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 2 ports detected
usbcore: registered new interface driver usb-storage
udc-core: couldn't find an available UDC - added [g_ether] to list of pending drivers
rtc-lpc32xx 40024000.rtc: registered as rtc0
rtc-lpc32xx 40024000.rtc: setting system clock to 2021-04-12T17:50:29 UTC (1618249829)
i2c /dev entries driver
pnx4008-watchdog 4003c000.watchdog: heartbeat 19 sec
usbcore: registered new interface driver usbhid
usbhid: USB HID core driver
IPVS: Registered protocols ()
IPVS: Connection hash table configured (size=4096, memory=32Kbytes)
IPVS: ipvs loaded.
ipt_CLUSTERIP: ClusterIP Version 0.8 loaded successfully
NET: Registered protocol family 10
Segment Routing with IPv6
sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver
NET: Registered protocol family 17
Bridge firewalling registered
UBI error: cannot open mtd 7, error -19
ALSA device list:
No soundcards found.
VFS: Cannot open root device "ubi0" or unknown-block(0,0): error -19
Please append a correct "root=" boot option; here are the available partitions:
0100 16384 ram0
(driver?)
Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
CPU: 0 PID: 1 Comm: swapper Tainted: G W 5.10.0-rc6-yocto-standard #1
Hardware name: LPC32XX SoC (Flattened Device Tree)
[<c0011978>] (unwind_backtrace) from [<c00108a8>] (show_stack+0x10/0x14)
[<c00108a8>] (show_stack) from [<c05316a8>] (panic+0x100/0x300)
[<c05316a8>] (panic) from [<c0684688>] (mount_block_root+0x1dc/0x26c)
[<c0684688>] (mount_block_root) from [<c06848f4>] (prepare_namespace+0x84/0x17c)
[<c06848f4>] (prepare_namespace) from [<c053b864>] (kernel_init+0x8/0xf8)
[<c053b864>] (kernel_init) from [<c0008520>] (ret_from_fork+0x14/0x34)
Exception stack(0xc0827fb0 to 0xc0827ff8)
7fa0: 00000000 00000000 00000000 00000000
7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
---[ end Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) ]---
The second panic, of course, will be fixed when the first one is resolved.
My NAND device tree:
#include "lpc32xx.dtsi"
/* 512MB Flash via SLC NAND controller */
&slc {
status = "okay";
nxp,wdr-clks = <14>;
nxp,wwidth = <70250000>;
nxp,whold = <281000000>;
nxp,wsetup = <100000000>;
nxp,rdr-clks = <14>;
nxp,rwidth = <93666666>;
nxp,rhold = <281000000>;
nxp,rsetup = <100000000>;
nand-on-flash-bbt;
gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
mtd0@0 { label = "bootrom"; reg = <0x00000000 0x00020000>; };
mtd1@20000 { label = "uboot"; reg = <0x00020000 0x00060000>; };
mtd2@80000 { label = "fbkernel"; reg = <0x00080000 0x003c0000>; };
mtd3@440000 { label = "fbrootfs"; reg = <0x00440000 0x004e0000>; };
mtd4@920000 { label = "c_kernel"; reg = <0x00920000 0x003c0000>; };
mtd5@ce0000 { label = "c__atags"; reg = <0x00ce0000 0x00020000>; };
mtd6@d00000 { label = "c_rootfs"; reg = <0x00d00000 0x00300000>; };
mtd7@1000000 { label = "mender"; reg = <0x01000000 0x1f000000>; };
};
};
Best regards,
Trevor
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-12 18:05 ` Trevor Woerner
@ 2021-04-13 10:00 ` Miquel Raynal
2021-04-13 12:48 ` Trevor Woerner
0 siblings, 1 reply; 9+ messages in thread
From: Miquel Raynal @ 2021-04-13 10:00 UTC (permalink / raw)
To: Trevor Woerner; +Cc: linux-mtd
Hi Trevor,
Trevor Woerner <twoerner@gmail.com> wrote on Mon, 12 Apr 2021 14:05:31
-0400:
> Hi Miquel,
>
> On Mon 2021-04-12 @ 06:02:33 PM, Miquel Raynal wrote:
> > I assumed I understood this trace well enough to write a patch. Can you
> > please give this change a try?
> >
> > If it does not fix your issue, would you mind tracing down the issue to
> > the root dereference that produces this panic?
>
> It looks, to me, that your patch solves the NULL dereference problem. But it
> reveals a new one "Driver must set ecc.strength when using hardware ECC". Is
> that something I should be setting in my device tree, or is that a driver
> issue too?
>
> > Also please share your entire boot log in case there is anything else
> > interesting (and perhaps your NAND DT node as well).
>
> New boot log:
> Booting Linux on physical CPU 0x0
> Linux version 5.10.0-rc6-yocto-standard (oe-user@oe-host) (arm-oe-linux-gnueabi-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.36.1.20210209) #1 PREEMPT Mon Apr 12 17:49:12 UTC 2021
> CPU: ARM926EJ-S [41069264] revision 4 (ARMv5TEJ), cr=0005317f
> CPU: VIVT data cache, VIVT instruction cache
> OF: fdt: Machine model: NAUTEL nape83 board based on NXP LPC3240
> Memory policy: Data cache writeback
> Zone ranges:
> Normal [mem 0x0000000080000000-0x0000000083ffffff]
> Movable zone start for each node
> Early memory node ranges
> node 0: [mem 0x0000000080000000-0x0000000083ffffff]
> Initmem setup node 0 [mem 0x0000000080000000-0x0000000083ffffff]
> Built 1 zonelists, mobility grouping on. Total pages: 16240
> Kernel command line: ubi.mtd=7,512 rootfstype=ubifs root=ubi0 rootwait rw console=ttyS0,115200n81
> Dentry cache hash table entries: 8192 (order: 3, 32768 bytes, linear)
> Inode-cache hash table entries: 4096 (order: 2, 16384 bytes, linear)
> mem auto-init: stack:off, heap alloc:off, heap free:off
> Memory: 57312K/65536K available (5341K kernel code, 432K rwdata, 1108K rodata, 196K init, 206K bss, 8224K reserved, 0K cma-reserved)
> rcu: Preemptible hierarchical RCU implementation.
> Trampoline variant of Tasks RCU enabled.
> rcu: RCU calculated value of scheduler-enlistment delay is 10 jiffies.
> NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
> random: get_random_bytes called from start_kernel+0x2bc/0x4d4 with crng_init=0
> clk_pll_recalc_rate: hclk_pll: PLL clocks are not in valid ranges: 0/0/0
> clocksource: lpc3220 timer: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 147020034397 ns
> Switching to timer-based delay loop, resolution 76ns
> sched_clock: 32 bits at 13MHz, resolution 76ns, wraps every 165191050201ns
> Console: colour dummy device 80x30
> Calibrating delay loop (skipped), value calculated using timer frequency.. 26.00 BogoMIPS (lpj=130000)
> pid_max: default: 32768 minimum: 301
> Mount-cache hash table entries: 1024 (order: 0, 4096 bytes, linear)
> Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes, linear)
> CPU: Testing write buffer coherency: ok
> Setting up static identity map for 0x80008400 - 0x8000843c
> rcu: Hierarchical SRCU implementation.
> devtmpfs: initialized
> VFP support v0.3: implementor 41 architecture 1 part 10 variant 9 rev 1
> clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
> futex hash table entries: 256 (order: -1, 3072 bytes, linear)
> NET: Registered protocol family 16
> DMA: preallocated 256 KiB pool for atomic coherent allocations
> cpuidle: using governor menu
> LPC32XX unique ID: 5565d99a09d8905d38df4d6190bb7480
> pl08xdmac pl08xdmac: initialized 8 virtual memcpy channels
> pl08xdmac pl08xdmac: initialized 2 virtual slave channels
> pl08xdmac pl08xdmac: DMA: PL080 rev0 at 0x31000000 irq 21
> SCSI subsystem initialized
> usbcore: registered new interface driver usbfs
> usbcore: registered new interface driver hub
> usbcore: registered new device driver usb
> Advanced Linux Sound Architecture Driver Initialized.
> clocksource: Switched to clocksource lpc3220 timer
> NET: Registered protocol family 2
> tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 4096 bytes, linear)
> TCP established hash table entries: 1024 (order: 0, 4096 bytes, linear)
> TCP bind hash table entries: 1024 (order: 0, 4096 bytes, linear)
> TCP: Hash tables configured (established 1024 bind 1024)
> UDP hash table entries: 256 (order: 0, 4096 bytes, linear)
> UDP-Lite hash table entries: 256 (order: 0, 4096 bytes, linear)
> NET: Registered protocol family 1
> RPC: Registered named UNIX socket transport module.
> RPC: Registered udp transport module.
> RPC: Registered tcp transport module.
> RPC: Registered tcp NFSv4.1 backchannel transport module.
> workingset: timestamp_bits=14 max_order=14 bucket_order=0
> NET: Registered protocol family 38
> io scheduler mq-deadline registered
> io scheduler kyber registered
> Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
> printk: console [ttyS0] disabled
> 40090000.serial: ttyS0 at MMIO 0x40090000 (irq = 24, base_baud = 812500) is a LPC3220
> printk: console [ttyS0] enabled
> 40080000.serial: ttyS1 at MMIO 0x40080000 (irq = 25, base_baud = 812500) is a LPC3220
> 40088000.serial: ttyS2 at MMIO 0x40088000 (irq = 26, base_baud = 812500) is a LPC3220
> 40098000.serial: ttyS3 at MMIO 0x40098000 (irq = 27, base_baud = 812500) is a LPC3220
> 40014000.serial: ttyTX0 at MMIO 0x40014000 (irq = 30, base_baud = 812500) is a lpc32xx_hsuart
> 40018000.serial: ttyTX1 at MMIO 0x40018000 (irq = 31, base_baud = 812500) is a lpc32xx_hsuart
> 4001c000.serial: ttyTX2 at MMIO 0x4001c000 (irq = 32, base_baud = 812500) is a lpc32xx_hsuart
> brd: module loaded
> loop: module loaded
> nand: device found, Manufacturer ID: 0x01, Chip ID: 0xdc
> nand: AMD/Spansion S34ML04G1
> nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/nand_base.c:5781 nand_scan_with_ids+0xbf8/0x136c
> Driver must set ecc.strength when using hardware ECC
I tried another version of the patch, please tell me if it works
better for you. If yes, I will have to copy this fix for 4 other
drivers in the same situation.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-13 10:00 ` Miquel Raynal
@ 2021-04-13 12:48 ` Trevor Woerner
2021-04-13 14:36 ` Miquel Raynal
0 siblings, 1 reply; 9+ messages in thread
From: Trevor Woerner @ 2021-04-13 12:48 UTC (permalink / raw)
To: Miquel Raynal; +Cc: linux-mtd
Hi Miquel,
On Tue 2021-04-13 @ 12:00:34 PM, Miquel Raynal wrote:
> I tried another version of the patch, please tell me if it works
> better for you. If yes, I will have to copy this fix for 4 other
> drivers in the same situation.
Success! Thank you :-)
Your v2 patch works perfectly.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: UBI issues with lpc32xx Was: UBI issues with 5.11.11
2021-04-13 12:48 ` Trevor Woerner
@ 2021-04-13 14:36 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2021-04-13 14:36 UTC (permalink / raw)
To: Trevor Woerner; +Cc: linux-mtd
Hi Trevor,
Trevor Woerner <twoerner@gmail.com> wrote on Tue, 13 Apr 2021 08:48:39
-0400:
> Hi Miquel,
>
> On Tue 2021-04-13 @ 12:00:34 PM, Miquel Raynal wrote:
> > I tried another version of the patch, please tell me if it works
> > better for you. If yes, I will have to copy this fix for 4 other
> > drivers in the same situation.
>
> Success! Thank you :-)
> Your v2 patch works perfectly.
Great! Thanks for testing!
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-04-13 14:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 19:03 UBI issues with linux-stable 5.11.11 Trevor Woerner
2021-04-07 20:23 ` Trevor Woerner
2021-04-08 4:56 ` Alexander Dahl
2021-04-12 2:29 ` UBI issues with lpc32xx Was: UBI issues with 5.11.11 Trevor Woerner
2021-04-12 16:02 ` Miquel Raynal
2021-04-12 18:05 ` Trevor Woerner
2021-04-13 10:00 ` Miquel Raynal
2021-04-13 12:48 ` Trevor Woerner
2021-04-13 14:36 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.