From: kernel test robot <lkp@intel.com> To: "Marek Behún" <kabel@kernel.org>, netdev@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch> Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, "David S . Miller" <davem@davemloft.net>, "Russell King" <rmk+kernel@armlinux.org.uk>, kuba@kernel.org, "Marek Behún" <kabel@kernel.org> Subject: Re: [PATCH net-next 1/5] net: phy: marvell: refactor HWMON OOP style Date: Tue, 13 Apr 2021 22:26:00 +0800 [thread overview] Message-ID: <202104132201.eou1XDPl-lkp@intel.com> (raw) In-Reply-To: <20210413075538.30175-2-kabel@kernel.org> [-- Attachment #1: Type: text/plain, Size: 3075 bytes --] Hi "Marek, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on next-20210413] [cannot apply to net-next/master ipvs/master linus/master v5.12-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-phy-marvell-some-HWMON-updates/20210413-155751 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git ccb39c6285581992f0225c45e4de704028a8ec17 config: x86_64-randconfig-a011-20210413 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/594b70c48fa643c6864722ab488bbfba0b210852 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Beh-n/net-phy-marvell-some-HWMON-updates/20210413-155751 git checkout 594b70c48fa643c6864722ab488bbfba0b210852 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/phy/marvell.c:2416:3: error: fallthrough annotation does not directly precede switch label fallthrough; ^ include/linux/compiler_attributes.h:208:41: note: expanded from macro 'fallthrough' # define fallthrough __attribute__((__fallthrough__)) ^ 1 error generated. vim +2416 drivers/net/phy/marvell.c 2394 2395 static int marvell_hwmon_read(struct device *dev, enum hwmon_sensor_types type, 2396 u32 attr, int channel, long *temp) 2397 { 2398 struct phy_device *phydev = dev_get_drvdata(dev); 2399 const struct marvell_hwmon_ops *ops = to_marvell_hwmon_ops(phydev); 2400 int err = -EOPNOTSUPP; 2401 2402 switch (attr) { 2403 case hwmon_temp_input: 2404 if (ops->get_temp) 2405 err = ops->get_temp(phydev, temp); 2406 break; 2407 case hwmon_temp_crit: 2408 if (ops->get_temp_critical) 2409 err = ops->get_temp_critical(phydev, temp); 2410 break; 2411 case hwmon_temp_max_alarm: 2412 if (ops->get_temp_alarm) 2413 err = ops->get_temp_alarm(phydev, temp); 2414 break; 2415 default: > 2416 fallthrough; 2417 } 2418 2419 return err; 2420 } 2421 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 31878 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 1/5] net: phy: marvell: refactor HWMON OOP style Date: Tue, 13 Apr 2021 22:26:00 +0800 [thread overview] Message-ID: <202104132201.eou1XDPl-lkp@intel.com> (raw) In-Reply-To: <20210413075538.30175-2-kabel@kernel.org> [-- Attachment #1: Type: text/plain, Size: 3152 bytes --] Hi "Marek, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on next-20210413] [cannot apply to net-next/master ipvs/master linus/master v5.12-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-phy-marvell-some-HWMON-updates/20210413-155751 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git ccb39c6285581992f0225c45e4de704028a8ec17 config: x86_64-randconfig-a011-20210413 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/594b70c48fa643c6864722ab488bbfba0b210852 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Beh-n/net-phy-marvell-some-HWMON-updates/20210413-155751 git checkout 594b70c48fa643c6864722ab488bbfba0b210852 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/phy/marvell.c:2416:3: error: fallthrough annotation does not directly precede switch label fallthrough; ^ include/linux/compiler_attributes.h:208:41: note: expanded from macro 'fallthrough' # define fallthrough __attribute__((__fallthrough__)) ^ 1 error generated. vim +2416 drivers/net/phy/marvell.c 2394 2395 static int marvell_hwmon_read(struct device *dev, enum hwmon_sensor_types type, 2396 u32 attr, int channel, long *temp) 2397 { 2398 struct phy_device *phydev = dev_get_drvdata(dev); 2399 const struct marvell_hwmon_ops *ops = to_marvell_hwmon_ops(phydev); 2400 int err = -EOPNOTSUPP; 2401 2402 switch (attr) { 2403 case hwmon_temp_input: 2404 if (ops->get_temp) 2405 err = ops->get_temp(phydev, temp); 2406 break; 2407 case hwmon_temp_crit: 2408 if (ops->get_temp_critical) 2409 err = ops->get_temp_critical(phydev, temp); 2410 break; 2411 case hwmon_temp_max_alarm: 2412 if (ops->get_temp_alarm) 2413 err = ops->get_temp_alarm(phydev, temp); 2414 break; 2415 default: > 2416 fallthrough; 2417 } 2418 2419 return err; 2420 } 2421 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 31878 bytes --]
next prev parent reply other threads:[~2021-04-13 14:26 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 7:55 [PATCH net-next 0/5] net: phy: marvell: some HWMON updates Marek Behún 2021-04-13 7:55 ` [PATCH net-next 1/5] net: phy: marvell: refactor HWMON OOP style Marek Behún 2021-04-13 14:26 ` kernel test robot [this message] 2021-04-13 14:26 ` kernel test robot 2021-04-13 14:36 ` Andrew Lunn 2021-04-13 15:11 ` Marek Behún 2021-04-13 7:55 ` [PATCH net-next 2/5] net: phy: marvell: fix HWMON enable register for 6390 Marek Behún 2021-04-13 14:25 ` Andrew Lunn 2021-04-13 15:12 ` Marek Behún 2021-04-13 7:55 ` [PATCH net-next 3/5] net: phy: marvell: use assignment by bitwise AND operator Marek Behún 2021-04-13 14:25 ` Andrew Lunn 2021-04-13 7:55 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: simulate Amethyst PHY model number Marek Behún 2021-04-13 14:26 ` Andrew Lunn 2021-04-13 7:55 ` [PATCH net-next 5/5] net: phy: marvell: add support for Amethyst internal PHY Marek Behún 2021-04-13 14:33 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202104132201.eou1XDPl-lkp@intel.com \ --to=lkp@intel.com \ --cc=andrew@lunn.ch \ --cc=clang-built-linux@googlegroups.com \ --cc=davem@davemloft.net \ --cc=kabel@kernel.org \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=rmk+kernel@armlinux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.