[linux-next:master 12286/12404] drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant because platform_get_irq() already prints an error

[linux-next:master 12286/12404] drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Sergey Shtylyov <s.shtylyov@omprussia.ru>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   dcf1b51d6b2ac5da234ae6883ed0e9422c339588
commit: 6c11dc060427e07ca144eacaccd696106b361b06 [12286/12404] scsi: hisi_sas: Fix IRQ checks
:::::: branch date: 6 hours ago
:::::: commit date: 12 hours ago
config: riscv-allmodconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant because platform_get_irq() already prints an error
   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1669:3-10: line 1669 is redundant because platform_get_irq() already prints an error
   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1687:3-10: line 1687 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68898 bytes --]

[PATCH] scsi: hisi_sas: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2478 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Sergey Shtylyov <s.shtylyov@omprussia.ru>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: John Garry <john.garry@huawei.com>
CC: "James E.J. Bottomley" <jejb@linux.ibm.com>
CC: linux-scsi(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1669:3-10: line 1669 is redundant because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1687:3-10: line 1687 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks")
CC: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   dcf1b51d6b2ac5da234ae6883ed0e9422c339588
commit: 6c11dc060427e07ca144eacaccd696106b361b06 [12286/12404] scsi: hisi_sas: Fix IRQ checks
:::::: branch date: 6 hours ago
:::::: commit date: 12 hours ago

Please take the patch only if it's a positive warning. Thanks!

 hisi_sas_v1_hw.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1647,8 +1647,6 @@ static int interrupt_init_v1_hw(struct h
 		for (j = 0; j < HISI_SAS_PHY_INT_NR; j++, idx++) {
 			irq = platform_get_irq(pdev, idx);
 			if (irq < 0) {
-				dev_err(dev, "irq init: fail map phy interrupt %d\n",
-					idx);
 				return -ENOENT;
 			}
 
@@ -1666,8 +1664,6 @@ static int interrupt_init_v1_hw(struct h
 	for (i = 0; i < hisi_hba->queue_count; i++, idx++) {
 		irq = platform_get_irq(pdev, idx);
 		if (irq < 0) {
-			dev_err(dev, "irq init: could not map cq interrupt %d\n",
-				idx);
 			return -ENOENT;
 		}
 
@@ -1684,8 +1680,6 @@ static int interrupt_init_v1_hw(struct h
 	for (i = 0; i < HISI_SAS_FATAL_INT_NR; i++, idx++) {
 		irq = platform_get_irq(pdev, idx);
 		if (irq < 0) {
-			dev_err(dev, "irq init: could not map fatal interrupt %d\n",
-				idx);
 			return -ENOENT;
 		}