* [PATCH v18 0/5] add power control in i2c
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (4):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
misc: eeprom: at24: check suspend status before disable regulator
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++
drivers/misc/eeprom/at24.c | 6 +-
include/linux/i2c.h | 2 +
8 files changed, 114 insertions(+), 2 deletions(-)
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v18 0/5] add power control in i2c
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (4):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
misc: eeprom: at24: check suspend status before disable regulator
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++
drivers/misc/eeprom/at24.c | 6 +-
include/linux/i2c.h | 2 +
8 files changed, 114 insertions(+), 2 deletions(-)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v18 0/5] add power control in i2c
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (4):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
misc: eeprom: at24: check suspend status before disable regulator
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++
drivers/misc/eeprom/at24.c | 6 +-
include/linux/i2c.h | 2 +
8 files changed, 114 insertions(+), 2 deletions(-)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v18 1/5] i2c: core: support bus regulator controlling in adapter
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
@ 2021-04-14 8:38 ` Hsin-Yi Wang
-1 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 90 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 24c8f11bac73..c34920f30c5a 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,79 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ if (!pm_runtime_status_suspended(&client->dev)) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev))
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ return regulator_disable(client->adapter->bus_regulator);
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +761,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 1/5] i2c: core: support bus regulator controlling in adapter
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 90 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 24c8f11bac73..c34920f30c5a 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,79 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ if (!pm_runtime_status_suspended(&client->dev)) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev))
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ return regulator_disable(client->adapter->bus_regulator);
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +761,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 1/5] i2c: core: support bus regulator controlling in adapter
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 90 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 24c8f11bac73..c34920f30c5a 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,79 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ if (!pm_runtime_status_suspended(&client->dev)) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev))
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client || !client->adapter->bus_regulator)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ return regulator_disable(client->adapter->bus_regulator);
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +761,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 2/5] dt-binding: i2c: mt65xx: add vbus-supply property
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
@ 2021-04-14 8:38 ` Hsin-Yi Wang
-1 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 2/5] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 2/5] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 3/5] i2c: mediatek: mt65xx: add optional vbus-supply
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
@ 2021-04-14 8:38 ` Hsin-Yi Wang
-1 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 2ffd2f354d0a..82f2b6716005 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1215,6 +1215,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 3/5] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 2ffd2f354d0a..82f2b6716005 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1215,6 +1215,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 3/5] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 2ffd2f354d0a..82f2b6716005 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1215,6 +1215,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 4/5] misc: eeprom: at24: check suspend status before disable regulator
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
@ 2021-04-14 8:38 ` Hsin-Yi Wang
-1 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables
regulator in runtime suspend. If runtime suspend is called before
regulator disable, it will results in regulator unbalanced disabling.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/misc/eeprom/at24.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 926408b41270..7a6f01ace78a 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client)
at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
if (IS_ERR(at24->nvmem)) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return PTR_ERR(at24->nvmem);
}
@@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client)
err = at24_read(at24, 0, &test_byte, 1);
if (err) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return -ENODEV;
}
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 4/5] misc: eeprom: at24: check suspend status before disable regulator
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables
regulator in runtime suspend. If runtime suspend is called before
regulator disable, it will results in regulator unbalanced disabling.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/misc/eeprom/at24.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 926408b41270..7a6f01ace78a 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client)
at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
if (IS_ERR(at24->nvmem)) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return PTR_ERR(at24->nvmem);
}
@@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client)
err = at24_read(at24, 0, &test_byte, 1);
if (err) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return -ENODEV;
}
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 4/5] misc: eeprom: at24: check suspend status before disable regulator
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables
regulator in runtime suspend. If runtime suspend is called before
regulator disable, it will results in regulator unbalanced disabling.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/misc/eeprom/at24.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 926408b41270..7a6f01ace78a 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client)
at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
if (IS_ERR(at24->nvmem)) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return PTR_ERR(at24->nvmem);
}
@@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client)
err = at24_read(at24, 0, &test_byte, 1);
if (err) {
pm_runtime_disable(dev);
- regulator_disable(at24->vcc_reg);
+ if (!pm_runtime_status_suspended(dev))
+ regulator_disable(at24->vcc_reg);
return -ENODEV;
}
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 5/5] arm64: dts: mt8183: add supply name for eeprom
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
@ 2021-04-14 8:38 ` Hsin-Yi Wang
-1 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 5/5] arm64: dts: mt8183: add supply name for eeprom
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v18 5/5] arm64: dts: mt8183: add supply name for eeprom
@ 2021-04-14 8:38 ` Hsin-Yi Wang
0 siblings, 0 replies; 19+ messages in thread
From: Hsin-Yi Wang @ 2021-04-14 8:38 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Rob Herring, Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v18 1/5] i2c: core: support bus regulator controlling in adapter
2021-04-14 8:38 ` Hsin-Yi Wang
(?)
(?)
@ 2021-04-14 16:08 ` kernel test robot
-1 siblings, 0 replies; 19+ messages in thread
From: kernel test robot @ 2021-04-14 16:08 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3149 bytes --]
Hi Hsin-Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20210413]
[also build test ERROR on v5.12-rc7]
[cannot apply to wsa/i2c/for-next robh/for-next char-misc/char-misc-testing mediatek/for-next v5.12-rc7 v5.12-rc6 v5.12-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/add-power-control-in-i2c/20210414-164337
base: dcf1b51d6b2ac5da234ae6883ed0e9422c339588
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/bdc2a0f5916e6855282b62026e7ba83432859dac
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hsin-Yi-Wang/add-power-control-in-i2c/20210414-164337
git checkout bdc2a0f5916e6855282b62026e7ba83432859dac
# save the attached .config to linux build tree
make W=1 W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_gem.c:1251:
>> drivers/gpu/drm/i915/selftests/i915_gem.c:97:13: error: conflicting types for 'pm_suspend'
97 | static void pm_suspend(struct drm_i915_private *i915)
| ^~~~~~~~~~
In file included from include/linux/regulator/consumer.h:35,
from include/linux/i2c.h:18,
from drivers/gpu/drm/i915/i915_drv.h:39,
from drivers/gpu/drm/i915/gt/intel_context.h:14,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:12,
from drivers/gpu/drm/i915/i915_gem.c:44:
include/linux/suspend.h:331:12: note: previous declaration of 'pm_suspend' was here
331 | extern int pm_suspend(suspend_state_t state);
| ^~~~~~~~~~
vim +/pm_suspend +97 drivers/gpu/drm/i915/selftests/i915_gem.c
3f51b7e1f36a37 Chris Wilson 2018-08-30 96
3f51b7e1f36a37 Chris Wilson 2018-08-30 @97 static void pm_suspend(struct drm_i915_private *i915)
3f51b7e1f36a37 Chris Wilson 2018-08-30 98 {
c9d08cc3e3393e Chris Wilson 2019-01-14 99 intel_wakeref_t wakeref;
c9d08cc3e3393e Chris Wilson 2019-01-14 100
c447ff7db34807 Daniele Ceraolo Spurio 2019-06-13 101 with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
e986209c67024c Chris Wilson 2020-01-30 102 i915_ggtt_suspend(&i915->ggtt);
3f51b7e1f36a37 Chris Wilson 2018-08-30 103 i915_gem_suspend_late(i915);
d4225a535b3b08 Chris Wilson 2019-01-14 104 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 105 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65259 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2021-04-14 16:08 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 8:38 [PATCH v18 0/5] add power control in i2c Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` [PATCH v18 1/5] i2c: core: support bus regulator controlling in adapter Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 16:08 ` kernel test robot
2021-04-14 8:38 ` [PATCH v18 2/5] dt-binding: i2c: mt65xx: add vbus-supply property Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` [PATCH v18 3/5] i2c: mediatek: mt65xx: add optional vbus-supply Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` [PATCH v18 4/5] misc: eeprom: at24: check suspend status before disable regulator Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` [PATCH v18 5/5] arm64: dts: mt8183: add supply name for eeprom Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
2021-04-14 8:38 ` Hsin-Yi Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.