From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
David Airlie <airlied@linux.ie>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS
Date: Wed, 14 Apr 2021 10:52:33 +0200 [thread overview]
Message-ID: <20210414085233.npcjjkjmbnwkuxdh@gilmour> (raw)
In-Reply-To: <20210413094904.3736372-12-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 948 bytes --]
On Tue, Apr 13, 2021 at 11:49:03AM +0200, Daniel Vetter wrote:
> It's very confusing for userspace to have to deal with inconsistencies
> here, and some drivers screwed this up a bit. Most just ommitted the
> format list when they meant to say that only linear modifier is
> allowed, but some also meant that only implied modifiers are
> acceptable (because actually none of the planes registered supported
> modifiers).
>
> Now that this is all done consistently across all drivers, document
> the rules and enforce it in the drm core.
>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
David Airlie <airlied@linux.ie>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS
Date: Wed, 14 Apr 2021 10:52:33 +0200 [thread overview]
Message-ID: <20210414085233.npcjjkjmbnwkuxdh@gilmour> (raw)
In-Reply-To: <20210413094904.3736372-12-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 948 bytes --]
On Tue, Apr 13, 2021 at 11:49:03AM +0200, Daniel Vetter wrote:
> It's very confusing for userspace to have to deal with inconsistencies
> here, and some drivers screwed this up a bit. Most just ommitted the
> format list when they meant to say that only linear modifier is
> allowed, but some also meant that only implied modifiers are
> acceptable (because actually none of the planes registered supported
> modifiers).
>
> Now that this is all done consistently across all drivers, document
> the rules and enforce it in the drm core.
>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-14 8:52 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 9:48 [PATCH 01/12] drm/arm: Don't set allow_fb_modifiers explicitly Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` [PATCH 02/12] drm/arm/malidp: Always list modifiers Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-13 9:48 ` [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-20 6:31 ` Inki Dae
2021-04-20 6:31 ` [Intel-gfx] " Inki Dae
2021-04-20 6:31 ` Inki Dae
2021-04-20 6:31 ` Inki Dae
2021-04-20 8:41 ` Daniel Vetter
2021-04-20 8:41 ` [Intel-gfx] " Daniel Vetter
2021-04-20 8:41 ` Daniel Vetter
2021-04-20 8:41 ` Daniel Vetter
2021-04-13 9:48 ` [PATCH 04/12] drm/i915: " Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` [PATCH 05/12] drm/imx: " Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-13 11:47 ` Lucas Stach
2021-04-13 11:47 ` [Intel-gfx] " Lucas Stach
2021-04-13 11:47 ` Lucas Stach
2021-04-13 14:04 ` Daniel Vetter
2021-04-13 14:04 ` [Intel-gfx] " Daniel Vetter
2021-04-13 14:04 ` Daniel Vetter
2021-04-13 14:14 ` Lucas Stach
2021-04-13 14:14 ` [Intel-gfx] " Lucas Stach
2021-04-13 14:14 ` Lucas Stach
2021-04-14 2:24 ` Liu Ying
2021-04-14 2:24 ` [Intel-gfx] " Liu Ying
2021-04-14 2:24 ` Liu Ying
2021-04-14 9:10 ` Daniel Vetter
2021-04-14 9:10 ` [Intel-gfx] " Daniel Vetter
2021-04-14 9:10 ` Daniel Vetter
2021-04-15 11:35 ` Daniel Vetter
2021-04-15 11:35 ` [Intel-gfx] " Daniel Vetter
2021-04-15 11:35 ` Daniel Vetter
2021-04-13 9:48 ` [PATCH 06/12] drm/msm/dpu1: " Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` [PATCH 07/12] drm/msm/mdp4: Fix modifier support enabling Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-13 9:48 ` [PATCH 08/12] drm/nouveau: Don't set allow_fb_modifiers explicitly Daniel Vetter
2021-04-13 9:48 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:48 ` Daniel Vetter
2021-04-13 9:48 ` [Nouveau] " Daniel Vetter
2021-04-13 9:49 ` [PATCH 09/12] drm/stm: " Daniel Vetter
2021-04-13 9:49 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:49 ` Daniel Vetter
2021-04-13 9:49 ` [PATCH 10/12] drm/tegra: " Daniel Vetter
2021-04-13 9:49 ` [Intel-gfx] " Daniel Vetter
2021-04-13 9:49 ` Daniel Vetter
2021-04-13 11:37 ` Thierry Reding
2021-04-13 11:37 ` [Intel-gfx] " Thierry Reding
2021-04-13 11:37 ` Thierry Reding
2021-04-15 11:33 ` Daniel Vetter
2021-04-15 11:33 ` [Intel-gfx] " Daniel Vetter
2021-04-15 11:33 ` Daniel Vetter
2021-04-13 9:49 ` [PATCH 11/12] drm/vc4: " Daniel Vetter
2021-04-13 9:49 ` [Intel-gfx] " Daniel Vetter
2021-04-14 8:51 ` Maxime Ripard
2021-04-14 8:51 ` [Intel-gfx] " Maxime Ripard
2021-04-13 9:49 ` [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS Daniel Vetter
2021-04-13 9:49 ` [Intel-gfx] " Daniel Vetter
2021-04-13 11:54 ` Lucas Stach
2021-04-13 11:54 ` [Intel-gfx] " Lucas Stach
2021-04-13 14:17 ` Daniel Vetter
2021-04-13 14:17 ` [Intel-gfx] " Daniel Vetter
2021-04-13 11:56 ` Pekka Paalanen
2021-04-13 11:56 ` [Intel-gfx] " Pekka Paalanen
2021-04-13 14:11 ` Daniel Vetter
2021-04-13 14:11 ` [Intel-gfx] " Daniel Vetter
2021-04-13 14:19 ` Daniel Vetter
2021-04-13 14:19 ` [Intel-gfx] " Daniel Vetter
2021-04-14 7:45 ` Pekka Paalanen
2021-04-14 7:45 ` [Intel-gfx] " Pekka Paalanen
2021-04-13 15:22 ` Simon Ser
2021-04-13 15:22 ` [Intel-gfx] " Simon Ser
2021-04-14 8:52 ` Maxime Ripard [this message]
2021-04-14 8:52 ` Maxime Ripard
2021-04-14 9:08 ` [PATCH] " Daniel Vetter
2021-04-14 9:08 ` [Intel-gfx] " Daniel Vetter
2021-04-14 12:14 ` Pekka Paalanen
2021-04-14 12:14 ` [Intel-gfx] " Pekka Paalanen
2021-04-16 6:30 ` Simon Ser
2021-04-16 6:30 ` [Intel-gfx] " Simon Ser
2021-04-13 12:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly Patchwork
2021-04-13 12:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-04-13 12:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-13 14:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-14 12:24 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414085233.npcjjkjmbnwkuxdh@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.