* [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502
@ 2021-04-14 14:55 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 2/5] PEP8 double aggressive E20 and E211 Khem Raj
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Khem Raj @ 2021-04-14 14:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: persianpros, Khem Raj
From: persianpros <persianpros@yahoo.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
contrib/oe-stylize.py | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
index ba4b87a74c..6f2b96c381 100755
--- a/contrib/oe-stylize.py
+++ b/contrib/oe-stylize.py
@@ -353,7 +353,8 @@ if __name__ == "__main__":
# ignore empty lines
if line.isspace() or line is '':
# flush comments into the olines
- for c in commentBloc: olines.append(c)
+ for c in commentBloc:
+ olines.append(c)
commentBloc = []
continue
@@ -370,7 +371,8 @@ if __name__ == "__main__":
continue
if var in seen_vars:
- for c in commentBloc: seen_vars[var].append(c)
+ for c in commentBloc:
+ seen_vars[var].append(c)
commentBloc = []
seen_vars[var].append(line)
else:
@@ -389,24 +391,29 @@ if __name__ == "__main__":
if not in_routine:
print ("## Warning: unknown variable/routine \"%s\"" % originalLine.rstrip('\n'))
var = 'others'
- for c in commentBloc: seen_vars[var].append(c)
+ for c in commentBloc:
+ seen_vars[var].append(c)
commentBloc = []
seen_vars[var].append(line)
- if not keep and not in_routine: var = ""
+ if not keep and not in_routine:
+ var = ""
# -- dump the sanitized .bb file --
addEmptyLine = False
# write comments that are not related to variables nor routines
- for l in commentBloc: olines.append(l)
+ for l in commentBloc:
+ olines.append(l)
# write variables and routines
previourVarPrefix = "unknown"
for k in OE_vars:
- if k=='SRC_URI': addEmptyLine = True
+ if k=='SRC_URI':
+ addEmptyLine = True
if seen_vars[k] != []:
if addEmptyLine and not k.startswith(previourVarPrefix):
olines.append("")
for l in seen_vars[k]:
olines.append(l)
previourVarPrefix = k.split('_')[0]=='' and "unknown" or k.split('_')[0]
- for line in olines: print(line)
+ for line in olines:
+ print(line)
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][ 2/5] PEP8 double aggressive E20 and E211
2021-04-14 14:55 [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502 Khem Raj
@ 2021-04-14 14:55 ` Khem Raj
2021-04-14 14:55 ` [meta-oe][ 3/5] PEP8 double aggressive E22, E224, E241, E242 and E27 Khem Raj
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2021-04-14 14:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: persianpros, Khem Raj
From: persianpros <persianpros@yahoo.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
contrib/oe-stylize.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
index 6f2b96c381..7958797059 100755
--- a/contrib/oe-stylize.py
+++ b/contrib/oe-stylize.py
@@ -312,10 +312,10 @@ def follow_rule(i, line):
# if the line still does not respect the rule
if not rules[i][0](line):
# this is a rule disgression
- print ("## Disgression: ", rules[i][2], " in: '", oldline, "'")
+ print("## Disgression: ", rules[i][2], " in: '", oldline, "'")
else:
# just remind user about his/her errors
- print ("## Reminder: ", rules[i][2], " in : '", oldline, "'")
+ print("## Reminder: ", rules[i][2], " in : '", oldline, "'")
return line
@@ -389,7 +389,7 @@ if __name__ == "__main__":
line = follow_rule(5, line)
if var == "":
if not in_routine:
- print ("## Warning: unknown variable/routine \"%s\"" % originalLine.rstrip('\n'))
+ print("## Warning: unknown variable/routine \"%s\"" % originalLine.rstrip('\n'))
var = 'others'
for c in commentBloc:
seen_vars[var].append(c)
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][ 3/5] PEP8 double aggressive E22, E224, E241, E242 and E27
2021-04-14 14:55 [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 2/5] PEP8 double aggressive E20 and E211 Khem Raj
@ 2021-04-14 14:55 ` Khem Raj
2021-04-14 14:55 ` [meta-oe][ 4/5] PEP8 double aggressive E301 ~ E306 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 5/5] PEP8 double aggressive W291 ~ W293 and W391 Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2021-04-14 14:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: persianpros, Khem Raj
From: persianpros <persianpros@yahoo.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
contrib/oe-stylize.py | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
index 7958797059..9d95911ae6 100755
--- a/contrib/oe-stylize.py
+++ b/contrib/oe-stylize.py
@@ -222,7 +222,7 @@ for v in OE_vars:
# No spaces are allowed at the beginning of lines that define a variable or
# a do_ routine
def respect_rule0(line):
- return line.lstrip()==line
+ return line.lstrip() == line
def conformTo_rule0(line):
return line.lstrip()
@@ -239,7 +239,7 @@ def conformTo_rule1(line):
# _Format guideline #2_:
# Tabs should not be used (use spaces instead).
def respect_rule2(line):
- return line.count('\t')==0
+ return line.count('\t') == 0
def conformTo_rule2(line):
return line.expandtabs()
@@ -261,7 +261,7 @@ def respect_rule4(line):
if r is not None:
r2 = re.search(r'("?)([^"\\]*)(["\\]?)', r.group(5))
# do not test for None it because always match
- return r2.group(1)=='"' and r2.group(3)!=''
+ return r2.group(1) == '"' and r2.group(3) != ''
return False
def conformTo_rule4(line):
r = re.search(varRegexp, line)
@@ -271,7 +271,7 @@ def conformTo_rule4(line):
# The correct spacing for a variable is FOO = "BAR".
def respect_rule5(line):
r = re.search(varRegexp, line)
- return r is not None and r.group(2)==" " and r.group(4)==" "
+ return r is not None and r.group(2) == " " and r.group(4) == " "
def conformTo_rule5(line):
r = re.search(varRegexp, line)
return ''.join([r.group(1), ' ', r.group(3), ' ', r.group(5)])
@@ -279,7 +279,7 @@ def conformTo_rule5(line):
# _Format guideline #6_:
# Don't use spaces or tabs on empty lines
def respect_rule6(line):
- return not line.isspace() or line=="\n"
+ return not line.isspace() or line == "\n"
def conformTo_rule6(line):
return ""
@@ -359,7 +359,7 @@ if __name__ == "__main__":
continue
if line.startswith('}'):
- in_routine=False
+ in_routine = False
keep = line.endswith('\\') or in_routine
# handles commented lines
@@ -381,7 +381,7 @@ if __name__ == "__main__":
var = k
break
if re.match(routineRegexp, line) is not None:
- in_routine=True
+ in_routine = True
line = follow_rule(0, line)
elif re.match(varRegexp, line) is not None:
line = follow_rule(0, line)
@@ -406,14 +406,14 @@ if __name__ == "__main__":
# write variables and routines
previourVarPrefix = "unknown"
for k in OE_vars:
- if k=='SRC_URI':
+ if k == 'SRC_URI':
addEmptyLine = True
if seen_vars[k] != []:
if addEmptyLine and not k.startswith(previourVarPrefix):
olines.append("")
for l in seen_vars[k]:
olines.append(l)
- previourVarPrefix = k.split('_')[0]=='' and "unknown" or k.split('_')[0]
+ previourVarPrefix = k.split('_')[0] == '' and "unknown" or k.split('_')[0]
for line in olines:
print(line)
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][ 4/5] PEP8 double aggressive E301 ~ E306
2021-04-14 14:55 [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 2/5] PEP8 double aggressive E20 and E211 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 3/5] PEP8 double aggressive E22, E224, E241, E242 and E27 Khem Raj
@ 2021-04-14 14:55 ` Khem Raj
2021-04-14 14:55 ` [meta-oe][ 5/5] PEP8 double aggressive W291 ~ W293 and W391 Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2021-04-14 14:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: persianpros, Khem Raj
From: persianpros <persianpros@yahoo.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
contrib/oe-stylize.py | 35 +++++++++++++++++++
.../oeqa/selftest/cases/meta_oe_sources.py | 1 +
2 files changed, 36 insertions(+)
diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
index 9d95911ae6..cfabb90b10 100755
--- a/contrib/oe-stylize.py
+++ b/contrib/oe-stylize.py
@@ -221,41 +221,59 @@ for v in OE_vars:
# _Format guideline #0_:
# No spaces are allowed at the beginning of lines that define a variable or
# a do_ routine
+
+
def respect_rule0(line):
return line.lstrip() == line
+
+
def conformTo_rule0(line):
return line.lstrip()
# _Format guideline #1_:
# No spaces are allowed behind the line continuation symbol '\'
+
+
def respect_rule1(line):
if line.rstrip().endswith('\\'):
return line.endswith('\\')
else:
return True
+
+
def conformTo_rule1(line):
return line.rstrip()
# _Format guideline #2_:
# Tabs should not be used (use spaces instead).
+
+
def respect_rule2(line):
return line.count('\t') == 0
+
+
def conformTo_rule2(line):
return line.expandtabs()
# _Format guideline #3_:
# Comments inside bb files are allowed using the '#' character at the
# beginning of a line.
+
+
def respect_rule3(line):
if line.lstrip().startswith('#'):
return line.startswith('#')
else:
return True
+
+
def conformTo_rule3(line):
return line.lstrip()
# _Format guideline #4_:
# Use quotes on the right hand side of assignments FOO = "BAR"
+
+
def respect_rule4(line):
r = re.search(varRegexp, line)
if r is not None:
@@ -263,33 +281,48 @@ def respect_rule4(line):
# do not test for None it because always match
return r2.group(1) == '"' and r2.group(3) != ''
return False
+
+
def conformTo_rule4(line):
r = re.search(varRegexp, line)
return ''.join([r.group(1), ' ', r.group(3), ' "', r.group(5), r.group(5).endswith('"') and '' or '"'])
# _Format guideline #5_:
# The correct spacing for a variable is FOO = "BAR".
+
+
def respect_rule5(line):
r = re.search(varRegexp, line)
return r is not None and r.group(2) == " " and r.group(4) == " "
+
+
def conformTo_rule5(line):
r = re.search(varRegexp, line)
return ''.join([r.group(1), ' ', r.group(3), ' ', r.group(5)])
# _Format guideline #6_:
# Don't use spaces or tabs on empty lines
+
+
def respect_rule6(line):
return not line.isspace() or line == "\n"
+
+
def conformTo_rule6(line):
return ""
# _Format guideline #7_:
# Indentation of multiline variables such as SRC_URI is desireable.
+
+
def respect_rule7(line):
return True
+
+
def conformTo_rule7(line):
return line
+
rules = (
(respect_rule0, conformTo_rule0, "No spaces are allowed at the beginning of lines that define a variable or a do_ routine"),
(respect_rule1, conformTo_rule1, "No spaces are allowed behind the line continuation symbol '\\'"),
@@ -303,6 +336,8 @@ rules = (
# Function to check that a line respects a rule. If not, it tries to conform
# the line to the rule. Reminder or Disgression message are dump accordingly.
+
+
def follow_rule(i, line):
oldline = line
# if the line does not respect the rule
diff --git a/meta-oe/lib/oeqa/selftest/cases/meta_oe_sources.py b/meta-oe/lib/oeqa/selftest/cases/meta_oe_sources.py
index b17c7950c7..c5a9a27946 100644
--- a/meta-oe/lib/oeqa/selftest/cases/meta_oe_sources.py
+++ b/meta-oe/lib/oeqa/selftest/cases/meta_oe_sources.py
@@ -6,6 +6,7 @@ import tempfile
from oeqa.selftest.case import OESelftestTestCase
from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_bb_vars
+
class MetaOESourceMirroring(OESelftestTestCase):
# Can we download everything from the OpenEmbedded Sources Mirror over http only
def test_oe_source_mirror(self):
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [meta-oe][ 5/5] PEP8 double aggressive W291 ~ W293 and W391
2021-04-14 14:55 [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502 Khem Raj
` (2 preceding siblings ...)
2021-04-14 14:55 ` [meta-oe][ 4/5] PEP8 double aggressive E301 ~ E306 Khem Raj
@ 2021-04-14 14:55 ` Khem Raj
3 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2021-04-14 14:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: persianpros, Khem Raj
From: persianpros <persianpros@yahoo.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
contrib/oe-stylize.py | 43 +++++++++++++++++++++----------------------
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/contrib/oe-stylize.py b/contrib/oe-stylize.py
index cfabb90b10..e1ba1b3218 100755
--- a/contrib/oe-stylize.py
+++ b/contrib/oe-stylize.py
@@ -2,12 +2,12 @@
"""\
Sanitize a bitbake file following the OpenEmbedded style guidelines,
-see http://openembedded.org/wiki/StyleGuide
+see http://openembedded.org/wiki/StyleGuide
(C) 2006 Cyril Romain <cyril.romain@gmail.com>
MIT license
-TODO:
+TODO:
- add the others OpenEmbedded variables commonly used:
- parse command arguments and print usage on misuse
. prevent giving more than one .bb file in arguments
@@ -19,7 +19,7 @@ TODO:
- count rule breaks and displays them in the order frequence
"""
-from __future__ import print_function
+from __future__ import print_function
import fileinput
import string
import re
@@ -65,7 +65,7 @@ OE_vars = [
'RSUGGESTS',
'RPROVIDES',
'RCONFLICTS',
- 'FILES',
+ 'FILES',
'do_package',
'do_stage',
'addhandler',
@@ -215,36 +215,36 @@ routineRegexp = r'^([a-zA-Z0-9_ ${}-]+?)\('
# Variables seen in the processed .bb
seen_vars = {}
-for v in OE_vars:
+for v in OE_vars:
seen_vars[v] = []
-# _Format guideline #0_:
-# No spaces are allowed at the beginning of lines that define a variable or
+# _Format guideline #0_:
+# No spaces are allowed at the beginning of lines that define a variable or
# a do_ routine
-def respect_rule0(line):
+def respect_rule0(line):
return line.lstrip() == line
-def conformTo_rule0(line):
+def conformTo_rule0(line):
return line.lstrip()
-# _Format guideline #1_:
+# _Format guideline #1_:
# No spaces are allowed behind the line continuation symbol '\'
def respect_rule1(line):
if line.rstrip().endswith('\\'):
return line.endswith('\\')
- else:
+ else:
return True
def conformTo_rule1(line):
return line.rstrip()
-# _Format guideline #2_:
+# _Format guideline #2_:
# Tabs should not be used (use spaces instead).
@@ -256,14 +256,14 @@ def conformTo_rule2(line):
return line.expandtabs()
# _Format guideline #3_:
-# Comments inside bb files are allowed using the '#' character at the
+# Comments inside bb files are allowed using the '#' character at the
# beginning of a line.
def respect_rule3(line):
if line.lstrip().startswith('#'):
return line.startswith('#')
- else:
+ else:
return True
@@ -364,8 +364,8 @@ if __name__ == "__main__":
if True:
lines.append(line)
else:
- # expandtabs on each line so that rule2 is always respected
- # rstrip each line so that rule1 is always respected
+ # expandtabs on each line so that rule2 is always respected
+ # rstrip each line so that rule1 is always respected
line = line.expandtabs().rstrip()
# ignore empty lines (or line filled with spaces or tabs only)
# so that rule6 is always respected
@@ -377,7 +377,7 @@ if __name__ == "__main__":
in_routine = False
commentBloc = []
olines = []
- for line in lines:
+ for line in lines:
originalLine = line
# rstrip line to remove line breaks characters
line = line.rstrip()
@@ -393,7 +393,7 @@ if __name__ == "__main__":
commentBloc = []
continue
- if line.startswith('}'):
+ if line.startswith('}'):
in_routine = False
keep = line.endswith('\\') or in_routine
@@ -415,7 +415,7 @@ if __name__ == "__main__":
if line.startswith(k):
var = k
break
- if re.match(routineRegexp, line) is not None:
+ if re.match(routineRegexp, line) is not None:
in_routine = True
line = follow_rule(0, line)
elif re.match(varRegexp, line) is not None:
@@ -443,12 +443,11 @@ if __name__ == "__main__":
for k in OE_vars:
if k == 'SRC_URI':
addEmptyLine = True
- if seen_vars[k] != []:
+ if seen_vars[k] != []:
if addEmptyLine and not k.startswith(previourVarPrefix):
olines.append("")
- for l in seen_vars[k]:
+ for l in seen_vars[k]:
olines.append(l)
previourVarPrefix = k.split('_')[0] == '' and "unknown" or k.split('_')[0]
for line in olines:
print(line)
-
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-14 14:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 14:55 [meta-oe][ 1/5] PEP8 double aggressive E701, E70 and E502 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 2/5] PEP8 double aggressive E20 and E211 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 3/5] PEP8 double aggressive E22, E224, E241, E242 and E27 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 4/5] PEP8 double aggressive E301 ~ E306 Khem Raj
2021-04-14 14:55 ` [meta-oe][ 5/5] PEP8 double aggressive W291 ~ W293 and W391 Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.