From: Rob Herring <robh@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: lee.jones@linaro.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com Subject: Re: [v2 1/2] dt-bindings: Add bindings for aspeed pwm-tach and pwm. Date: Wed, 14 Apr 2021 17:15:53 -0500 [thread overview] Message-ID: <20210414221553.GA56046@robh.at.kernel.org> (raw) In-Reply-To: <20210414104939.1093-2-billy_tsai@aspeedtech.com> On Wed, Apr 14, 2021 at 06:49:38PM +0800, Billy Tsai wrote: > This patch adds device bindings for aspeed pwm-tach device which is a > multi-function device include pwn and tach function and pwm device which > should be the sub-node of pwm-tach device. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > Change-Id: I18d9dea14c3a04e1b7e38ffecd49d45917b9b545 Drop > --- > .../bindings/mfd/aspeed,ast2600-pwm-tach.yaml | 60 +++++++++++++++++++ > .../bindings/pwm/aspeed,ast2600-pwm.yaml | 44 ++++++++++++++ > 2 files changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > new file mode 100644 > index 000000000000..eaf8bdf8d44e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 ASPEED, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/aspeed,ast2600-pwm-tach.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PWM Tach controller Device Tree Bindings > + > +description: | > + The PWM Tach controller is represented as a multi-function device which > + includes: > + PWM > + Tach But is it really? A PWM and tach sounds like a fan controller. Look at other existing PWM+tach bindings we have for fans. > + > +maintainers: > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2600-pwm-tach > + - const: syscon > + - const: simple-mfd > + reg: > + maxItems: 1 > + "#address-cells": > + const: 1 > + "#size-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: > + type: object As you know the 2 node names, they should be documented. However, see below. > + > +examples: > + - | > + pwm_tach: pwm_tach@1e610000 { > + compatible = "aspeed,ast2600-pwm-tach", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1e610000 0x100>; > + > + pwm: pwm@0 { > + compatible = "aspeed,ast2600-pwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x100>; > + }; > + > + tach: tach@1 { > + compatible = "aspeed,ast2600-tach"; > + reg = <0x0 0x100>; You have 2 nodes at the same address. Not valid. > + }; There's no real need for 2 child nodes. The parent node can be a PWM provider. > + }; > diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > new file mode 100644 > index 000000000000..97923e68ccb9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 ASPEED, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED AST2600 PWM controller > + > +maintainers: > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +description: | > + The ASPEED PWM controller can support upto 16 PWM outputs. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-pwm > + > + "#pwm-cells": > + const: 3 > + > + reg: > + maxItems: 1 > + > +additionalProperties: false > + > +examples: > + - | > + // The PWM should be a subnode of a "aspeed,ast2600-pwm-tach" compatible > + // node. > + pwm_tach: pwm_tach@1e610000 { > + compatible = "aspeed,ast2600-pwm-tach", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1e610000 0x100>; > + > + pwm: pwm@0 { > + compatible = "aspeed,ast2600-pwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x100>; > + }; > + }; > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: lee.jones@linaro.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com Subject: Re: [v2 1/2] dt-bindings: Add bindings for aspeed pwm-tach and pwm. Date: Wed, 14 Apr 2021 17:15:53 -0500 [thread overview] Message-ID: <20210414221553.GA56046@robh.at.kernel.org> (raw) In-Reply-To: <20210414104939.1093-2-billy_tsai@aspeedtech.com> On Wed, Apr 14, 2021 at 06:49:38PM +0800, Billy Tsai wrote: > This patch adds device bindings for aspeed pwm-tach device which is a > multi-function device include pwn and tach function and pwm device which > should be the sub-node of pwm-tach device. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > Change-Id: I18d9dea14c3a04e1b7e38ffecd49d45917b9b545 Drop > --- > .../bindings/mfd/aspeed,ast2600-pwm-tach.yaml | 60 +++++++++++++++++++ > .../bindings/pwm/aspeed,ast2600-pwm.yaml | 44 ++++++++++++++ > 2 files changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > new file mode 100644 > index 000000000000..eaf8bdf8d44e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 ASPEED, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/aspeed,ast2600-pwm-tach.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PWM Tach controller Device Tree Bindings > + > +description: | > + The PWM Tach controller is represented as a multi-function device which > + includes: > + PWM > + Tach But is it really? A PWM and tach sounds like a fan controller. Look at other existing PWM+tach bindings we have for fans. > + > +maintainers: > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2600-pwm-tach > + - const: syscon > + - const: simple-mfd > + reg: > + maxItems: 1 > + "#address-cells": > + const: 1 > + "#size-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: > + type: object As you know the 2 node names, they should be documented. However, see below. > + > +examples: > + - | > + pwm_tach: pwm_tach@1e610000 { > + compatible = "aspeed,ast2600-pwm-tach", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1e610000 0x100>; > + > + pwm: pwm@0 { > + compatible = "aspeed,ast2600-pwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x100>; > + }; > + > + tach: tach@1 { > + compatible = "aspeed,ast2600-tach"; > + reg = <0x0 0x100>; You have 2 nodes at the same address. Not valid. > + }; There's no real need for 2 child nodes. The parent node can be a PWM provider. > + }; > diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > new file mode 100644 > index 000000000000..97923e68ccb9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 ASPEED, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED AST2600 PWM controller > + > +maintainers: > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +description: | > + The ASPEED PWM controller can support upto 16 PWM outputs. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-pwm > + > + "#pwm-cells": > + const: 3 > + > + reg: > + maxItems: 1 > + > +additionalProperties: false > + > +examples: > + - | > + // The PWM should be a subnode of a "aspeed,ast2600-pwm-tach" compatible > + // node. > + pwm_tach: pwm_tach@1e610000 { > + compatible = "aspeed,ast2600-pwm-tach", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1e610000 0x100>; > + > + pwm: pwm@0 { > + compatible = "aspeed,ast2600-pwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x100>; > + }; > + }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-14 22:15 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-14 10:49 [v2 0/2] Support pwm driver for aspeed ast26xx Billy Tsai 2021-04-14 10:49 ` Billy Tsai 2021-04-14 10:49 ` [v2 1/2] dt-bindings: Add bindings for aspeed pwm-tach and pwm Billy Tsai 2021-04-14 10:49 ` Billy Tsai 2021-04-14 14:50 ` Rob Herring 2021-04-14 14:50 ` Rob Herring 2021-04-14 22:15 ` Rob Herring [this message] 2021-04-14 22:15 ` Rob Herring 2021-04-15 3:44 ` Billy Tsai 2021-04-15 14:43 ` Rob Herring 2021-04-15 14:43 ` Rob Herring 2021-04-16 8:44 ` Billy Tsai 2021-04-16 8:44 ` Billy Tsai 2021-04-14 10:49 ` [v2 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai 2021-04-14 10:49 ` Billy Tsai 2021-04-26 20:43 ` Uwe Kleine-König 2021-04-26 20:43 ` Uwe Kleine-König 2021-05-03 4:42 ` Billy Tsai 2021-05-03 4:42 ` Billy Tsai 2021-05-03 5:57 ` Billy Tsai 2021-05-03 5:57 ` Billy Tsai 2021-05-03 6:23 ` Uwe Kleine-König 2021-05-03 6:23 ` Uwe Kleine-König 2021-05-03 6:10 ` Uwe Kleine-König 2021-05-03 6:10 ` Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210414221553.GA56046@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=billy_tsai@aspeedtech.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.