All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime@cerno.tech
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: daniel@ffwll.ch, airlied@linux.ie,
	maarten.lankhorst@linux.intel.com, kraxel@redhat.com,
	corbet@lwn.net, lgirdwood@gmail.com, broonie@kernel.org,
	sam@ravnborg.org, robh@kernel.org, emil.l.velikov@gmail.com,
	geert+renesas@glider.be, hdegoede@redhat.com,
	bluescreen_avenger@verizon.net, dri-devel@lists.freedesktop.org,
	linux-doc@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node
Date: Thu, 15 Apr 2021 14:11:27 +0200	[thread overview]
Message-ID: <20210415121127.igpedvc6sep5jqq5@gilmour> (raw)
In-Reply-To: <9b21042c-9908-3847-702a-cb891d1769e0@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

On Thu, Apr 15, 2021 at 01:02:44PM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.04.21 um 11:21 schrieb Maxime Ripard:
> > Hi,
> > 
> > On Thu, Apr 15, 2021 at 09:31:01AM +0200, Thomas Zimmermann wrote:
> > > Am 08.04.21 um 10:13 schrieb Maxime Ripard:
> > > > Hi,
> > > > 
> > > > On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote:
> > > > > Make sure required hardware clocks are enabled while the firmware
> > > > > framebuffer is in use.
> > > > > 
> > > > > The basic code has been taken from the simplefb driver and adapted
> > > > > to DRM. Clocks are released automatically via devres helpers.
> > > > > 
> > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> > > > > Tested-by: nerdopolis <bluescreen_avenger@verizon.net>
> > > > 
> > > > Even though it's definitely simpler to review, merging the driver first
> > > > and then the clocks and regulators will break bisection on the platforms
> > > > that rely on them
> > > 
> > > I'd like to keep the patches separate for now, but can squash patches 6 to 8
> > > them into one before pushing them. OK?
> > 
> > Yep, that works for me :)
> > 
> > > > 
> > > > Another thing worth considering is also that both drivers will probe if
> > > > they are enabled (which is pretty likely), which is not great :)
> > > > 
> > > > I guess we should make them mutually exclusive through Kconfig
> > > 
> > > We already have several drivers in fbdev and DRM that handle the same
> > > hardware. We don't do this for any other pair, why bother now?
> > 
> > Yeah, but simplefb/simpledrm are going to be enabled pretty much
> > everywhere, as opposed to the other drivers that are more specialized.
> 
> Well, OK. But I'd like to give simpledrm preference over simplefb. There
> should be an incentive to switch to DRM.

Yeah that makes total sense :)

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime@cerno.tech
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: bluescreen_avenger@verizon.net, geert+renesas@glider.be,
	corbet@lwn.net, airlied@linux.ie, emil.l.velikov@gmail.com,
	linux-doc@vger.kernel.org, lgirdwood@gmail.com,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org, hdegoede@redhat.com,
	broonie@kernel.org, kraxel@redhat.com, sam@ravnborg.org
Subject: Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node
Date: Thu, 15 Apr 2021 14:11:27 +0200	[thread overview]
Message-ID: <20210415121127.igpedvc6sep5jqq5@gilmour> (raw)
In-Reply-To: <9b21042c-9908-3847-702a-cb891d1769e0@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1883 bytes --]

On Thu, Apr 15, 2021 at 01:02:44PM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.04.21 um 11:21 schrieb Maxime Ripard:
> > Hi,
> > 
> > On Thu, Apr 15, 2021 at 09:31:01AM +0200, Thomas Zimmermann wrote:
> > > Am 08.04.21 um 10:13 schrieb Maxime Ripard:
> > > > Hi,
> > > > 
> > > > On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote:
> > > > > Make sure required hardware clocks are enabled while the firmware
> > > > > framebuffer is in use.
> > > > > 
> > > > > The basic code has been taken from the simplefb driver and adapted
> > > > > to DRM. Clocks are released automatically via devres helpers.
> > > > > 
> > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> > > > > Tested-by: nerdopolis <bluescreen_avenger@verizon.net>
> > > > 
> > > > Even though it's definitely simpler to review, merging the driver first
> > > > and then the clocks and regulators will break bisection on the platforms
> > > > that rely on them
> > > 
> > > I'd like to keep the patches separate for now, but can squash patches 6 to 8
> > > them into one before pushing them. OK?
> > 
> > Yep, that works for me :)
> > 
> > > > 
> > > > Another thing worth considering is also that both drivers will probe if
> > > > they are enabled (which is pretty likely), which is not great :)
> > > > 
> > > > I guess we should make them mutually exclusive through Kconfig
> > > 
> > > We already have several drivers in fbdev and DRM that handle the same
> > > hardware. We don't do this for any other pair, why bother now?
> > 
> > Yeah, but simplefb/simpledrm are going to be enabled pretty much
> > everywhere, as opposed to the other drivers that are more specialized.
> 
> Well, OK. But I'd like to give simpledrm preference over simplefb. There
> should be an incentive to switch to DRM.

Yeah that makes total sense :)

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-04-15 12:11 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 10:29 [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs Thomas Zimmermann
2021-03-18 10:29 ` Thomas Zimmermann
2021-03-18 10:29 ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 01/10] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip() Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 02/10] drm/format-helper: Add blitter functions Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 03/10] drm/aperture: Move fbdev conflict helpers into drm_aperture.h Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-04-08  9:50   ` Daniel Vetter
2021-04-08  9:50     ` Daniel Vetter
2021-04-08  9:50     ` Daniel Vetter
2021-04-09  7:09     ` Thomas Zimmermann
2021-04-09  7:09       ` Thomas Zimmermann
2021-04-09  7:09       ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 04/10] drm/aperture: Add infrastructure for aperture ownership Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-04-08  9:48   ` Daniel Vetter
2021-04-08  9:48     ` Daniel Vetter
2021-04-08  9:48     ` Daniel Vetter
2021-04-09  7:06     ` Thomas Zimmermann
2021-04-09  7:06       ` Thomas Zimmermann
2021-04-09  7:06       ` Thomas Zimmermann
2021-04-09  9:22       ` Daniel Vetter
2021-04-09  9:22         ` Daniel Vetter
2021-04-09  9:22         ` Daniel Vetter
2021-04-15  6:56         ` Thomas Zimmermann
2021-04-15  6:56           ` Thomas Zimmermann
2021-04-15  6:56           ` Thomas Zimmermann
2021-04-15 12:57           ` Daniel Vetter
2021-04-15 12:57             ` Daniel Vetter
2021-04-15 12:57             ` Daniel Vetter
2021-04-15 19:12             ` Thomas Zimmermann
2021-04-15 19:12               ` Thomas Zimmermann
2021-04-15 19:12               ` Thomas Zimmermann
2021-04-16  8:42               ` Daniel Vetter
2021-04-16  8:42                 ` Daniel Vetter
2021-04-16  8:42                 ` Daniel Vetter
2021-04-09  7:54     ` Thomas Zimmermann
2021-04-09  7:54       ` Thomas Zimmermann
2021-04-09  7:54       ` Thomas Zimmermann
2021-04-09  9:29       ` Daniel Vetter
2021-04-09  9:29         ` Daniel Vetter
2021-04-09  9:29         ` Daniel Vetter
2021-03-18 10:29 ` [PATCH v2 05/10] drm: Add simpledrm driver Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 06/10] drm/simpledrm: Add fbdev emulation Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 07/10] drm/simpledrm: Initialize framebuffer data from device-tree node Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:39   ` Geert Uytterhoeven
2021-03-18 10:39     ` Geert Uytterhoeven
2021-03-18 10:39     ` Geert Uytterhoeven
2021-03-18 11:00     ` Thomas Zimmermann
2021-03-18 11:00       ` Thomas Zimmermann
2021-03-18 11:00       ` Thomas Zimmermann
2021-04-08  8:13   ` Maxime Ripard
2021-04-08  8:13     ` Maxime Ripard
2021-04-15  7:31     ` Thomas Zimmermann
2021-04-15  7:31       ` Thomas Zimmermann
2021-04-15  7:31       ` Thomas Zimmermann
2021-04-15  9:21       ` Maxime Ripard
2021-04-15  9:21         ` Maxime Ripard
2021-04-15 11:02         ` Thomas Zimmermann
2021-04-15 11:02           ` Thomas Zimmermann
2021-04-15 11:02           ` Thomas Zimmermann
2021-04-15 12:11           ` maxime [this message]
2021-04-15 12:11             ` maxime
2021-03-18 10:29 ` [PATCH v2 09/10] drm/simpledrm: Acquire regulators " Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 10/10] drm/simpledrm: Acquire memory aperture for framebuffer Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-18 10:29   ` Thomas Zimmermann
2021-03-25 11:29 ` [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs Hans de Goede
2021-03-25 11:29   ` Hans de Goede
2021-03-25 11:29   ` Hans de Goede
2021-03-29 12:31   ` Thomas Zimmermann
2021-03-29 12:31     ` Thomas Zimmermann
2021-03-29 12:31     ` Thomas Zimmermann
2021-03-29 14:50     ` Hans de Goede
2021-03-29 14:50       ` Hans de Goede
2021-03-29 14:50       ` Hans de Goede
2021-03-30  7:09       ` Thomas Zimmermann
2021-03-30  7:09         ` Thomas Zimmermann
2021-03-30  7:09         ` Thomas Zimmermann
2021-03-30  8:34         ` Hans de Goede
2021-03-30  8:34           ` Hans de Goede
2021-03-30  8:34           ` Hans de Goede
2021-04-08 10:14           ` Daniel Vetter
2021-04-08 10:14             ` Daniel Vetter
2021-04-08 10:14             ` Daniel Vetter
2021-03-26  2:31 ` nerdopolis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210415121127.igpedvc6sep5jqq5@gilmour \
    --to=maxime@cerno.tech \
    --cc=airlied@linux.ie \
    --cc=bluescreen_avenger@verizon.net \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.