All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Baoquan He <bhe@redhat.com>,
	kexec@lists.infradead.org, x86@kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: x86/crash: fix crash_setup_memmap_entries() out-of-bounds access
Date: Fri, 16 Apr 2021 19:47:08 +0800	[thread overview]
Message-ID: <20210416114708.GB79779@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <063a63ddea914ac654cbe9a1d1d6c76986af7882.camel@gmx.de>

On 04/16/21 at 01:28pm, Mike Galbraith wrote:
> On Fri, 2021-04-16 at 19:07 +0800, Dave Young wrote:
> >
> > > We're excluding two ranges, allocate the scratch space we need to do that.
> >
> > I think 1 range should be fine, have you tested 1?
> 
> Have now, and vzalloc(struct_size(cmem, ranges, 1)) worked just fine.

Ok, thanks for your quick response.  Care to resend and cc x86 list and
Andrew?

Andrew usually takes core kexec/kdump fixes, x86 usually go through x86
maintainer.

Thanks
Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Young <dyoung@redhat.com>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Baoquan He <bhe@redhat.com>,
	kexec@lists.infradead.org, x86@kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: x86/crash: fix crash_setup_memmap_entries() out-of-bounds access
Date: Fri, 16 Apr 2021 19:47:08 +0800	[thread overview]
Message-ID: <20210416114708.GB79779@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <063a63ddea914ac654cbe9a1d1d6c76986af7882.camel@gmx.de>

On 04/16/21 at 01:28pm, Mike Galbraith wrote:
> On Fri, 2021-04-16 at 19:07 +0800, Dave Young wrote:
> >
> > > We're excluding two ranges, allocate the scratch space we need to do that.
> >
> > I think 1 range should be fine, have you tested 1?
> 
> Have now, and vzalloc(struct_size(cmem, ranges, 1)) worked just fine.

Ok, thanks for your quick response.  Care to resend and cc x86 list and
Andrew?

Andrew usually takes core kexec/kdump fixes, x86 usually go through x86
maintainer.

Thanks
Dave


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2021-04-16 11:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 17:56 x86/crash: fix crash_setup_memmap_entries() out-of-bounds access Mike Galbraith
2021-04-16 11:07 ` Dave Young
2021-04-16 11:07   ` Dave Young
2021-04-16 11:28   ` Mike Galbraith
2021-04-16 11:28     ` Mike Galbraith
2021-04-16 11:47     ` Dave Young [this message]
2021-04-16 11:47       ` Dave Young
2021-04-16 12:02       ` [patch] " Mike Galbraith
2021-04-16 12:02         ` Mike Galbraith
2021-04-16 12:16         ` Borislav Petkov
2021-04-16 12:16           ` Borislav Petkov
2021-04-16 13:16           ` Mike Galbraith
2021-04-16 13:16             ` Mike Galbraith
2021-04-16 14:44             ` Borislav Petkov
2021-04-16 14:44               ` Borislav Petkov
2021-04-16 15:13               ` Mike Galbraith
2021-04-16 15:13                 ` Mike Galbraith
2021-04-16 21:44                 ` Thomas Gleixner
2021-04-16 21:44                   ` Thomas Gleixner
2021-04-17  0:05                   ` Mike Galbraith
2021-04-17  0:05                     ` Mike Galbraith
2021-04-19  8:52                     ` Borislav Petkov
2021-04-19  8:52                       ` Borislav Petkov
2021-04-19  9:37                       ` DaveYoung
2021-04-19  9:37                         ` DaveYoung
2021-04-20 18:00         ` [tip: x86/urgent] x86/crash: Fix " tip-bot2 for Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416114708.GB79779@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=efault@gmx.de \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.