[Buildroot] [PATCH] package/tio: disable for sparc and sparc64 architectures

[Buildroot] [PATCH] package/tio: disable for sparc and sparc64 architectures

[Sergio Prado]

tio fails to build on sparc and sparc64 architectures with a
redefinition of 'struct termio' error, with no proper fix or workaround
for now. See discussions in [1] and [2] and picocom source code in [3].

[1] http://patchwork.ozlabs.org/project/buildroot/patch/20191227204520.1500501-1-fontaine.fabrice at gmail.com/
[2] http://patchwork.ozlabs.org/project/buildroot/patch/20200511142602.46170-1-vadim4j at gmail.com/
[3] https://github.com/npat-efault/picocom/blob/master/termbits2.h#L37

So let's disable it for now on sparc and sparc64 architectures.

Fixes:
http://autobuild.buildroot.org/results/e041dde522e2a774f528d4377f67ca0a8a99461c
http://autobuild.buildroot.org/results/6e1f9fe47e8b2cfdf5effcb7bbc697189f54ff2c
http://autobuild.buildroot.org/results/49708fe6f404fea6761f102af854e98d6a1d43c1
Many more...

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
 package/tio/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/tio/Config.in b/package/tio/Config.in
index 6c748c5d12a1..d5d619100eb3 100644
--- a/package/tio/Config.in
+++ b/package/tio/Config.in
@@ -1,8 +1,15 @@
 config BR2_PACKAGE_TIO
 	bool "tio"
+	depends on !BR2_sparc64 && !BR2_sparc
 	help
 	  "tio" is a simple TTY terminal application which features a
 	  straightforward commandline interface to easily connect to
 	  TTY devices for basic input/output.
 
 	  https://tio.github.io/
+
+# tio is disabled for sparc and sparc64 architectures because it fails
+# to build with a redefinition of 'struct termio' error, with no proper
+# fix or workaround for now
+comment "tio is disabled for sparc and sparc64 architectures"
+	depends on BR2_sparc64 || BR2_sparc
-- 
2.17.1

[Buildroot] [PATCH] package/tio: disable for sparc and sparc64 architectures

[Sergio Prado]

Hi,

Any changes to merge this one? I keep receiving e-mails about autobuild
failures in the tio package, and I think the best approach here is just to
disable it for sparc.

Best regards,

Sergio Prado
Embedded Labworks

Em dom., 25 de out. de 2020 ?s 13:35, Sergio Prado <
sergio.prado@e-labworks.com> escreveu:

> tio fails to build on sparc and sparc64 architectures with a
> redefinition of 'struct termio' error, with no proper fix or workaround
> for now. See discussions in [1] and [2] and picocom source code in [3].
>
> [1]
> http://patchwork.ozlabs.org/project/buildroot/patch/20191227204520.1500501-1-fontaine.fabrice at gmail.com/
> [2]
> http://patchwork.ozlabs.org/project/buildroot/patch/20200511142602.46170-1-vadim4j at gmail.com/
> [3] https://github.com/npat-efault/picocom/blob/master/termbits2.h#L37
>
> So let's disable it for now on sparc and sparc64 architectures.
>
> Fixes:
>
> http://autobuild.buildroot.org/results/e041dde522e2a774f528d4377f67ca0a8a99461c
>
> http://autobuild.buildroot.org/results/6e1f9fe47e8b2cfdf5effcb7bbc697189f54ff2c
>
> http://autobuild.buildroot.org/results/49708fe6f404fea6761f102af854e98d6a1d43c1
> Many more...
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
>  package/tio/Config.in | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/tio/Config.in b/package/tio/Config.in
> index 6c748c5d12a1..d5d619100eb3 100644
> --- a/package/tio/Config.in
> +++ b/package/tio/Config.in
> @@ -1,8 +1,15 @@
>  config BR2_PACKAGE_TIO
>         bool "tio"
> +       depends on !BR2_sparc64 && !BR2_sparc
>         help
>           "tio" is a simple TTY terminal application which features a
>           straightforward commandline interface to easily connect to
>           TTY devices for basic input/output.
>
>           https://tio.github.io/
> +
> +# tio is disabled for sparc and sparc64 architectures because it fails
> +# to build with a redefinition of 'struct termio' error, with no proper
> +# fix or workaround for now
> +comment "tio is disabled for sparc and sparc64 architectures"
> +       depends on BR2_sparc64 || BR2_sparc
> --
> 2.17.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210410/7e5e900d/attachment.html>

[Buildroot] [PATCH] package/tio: disable for sparc and sparc64 architectures

[Yann E. MORIN]

Sergio, All,

On 2020-10-25 13:34 -0300, Sergio Prado spake thusly:
> tio fails to build on sparc and sparc64 architectures with a
> redefinition of 'struct termio' error, with no proper fix or workaround
> for now. See discussions in [1] and [2] and picocom source code in [3].
> 
> [1] http://patchwork.ozlabs.org/project/buildroot/patch/20191227204520.1500501-1-fontaine.fabrice at gmail.com/
> [2] http://patchwork.ozlabs.org/project/buildroot/patch/20200511142602.46170-1-vadim4j at gmail.com/
> [3] https://github.com/npat-efault/picocom/blob/master/termbits2.h#L37
> 
> So let's disable it for now on sparc and sparc64 architectures.
> 
> Fixes:
> http://autobuild.buildroot.org/results/e041dde522e2a774f528d4377f67ca0a8a99461c
> http://autobuild.buildroot.org/results/6e1f9fe47e8b2cfdf5effcb7bbc697189f54ff2c
> http://autobuild.buildroot.org/results/49708fe6f404fea6761f102af854e98d6a1d43c1
> Many more...
> 
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>

Eventually applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/tio/Config.in | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/tio/Config.in b/package/tio/Config.in
> index 6c748c5d12a1..d5d619100eb3 100644
> --- a/package/tio/Config.in
> +++ b/package/tio/Config.in
> @@ -1,8 +1,15 @@
>  config BR2_PACKAGE_TIO
>  	bool "tio"
> +	depends on !BR2_sparc64 && !BR2_sparc
>  	help
>  	  "tio" is a simple TTY terminal application which features a
>  	  straightforward commandline interface to easily connect to
>  	  TTY devices for basic input/output.
>  
>  	  https://tio.github.io/
> +
> +# tio is disabled for sparc and sparc64 architectures because it fails
> +# to build with a redefinition of 'struct termio' error, with no proper
> +# fix or workaround for now
> +comment "tio is disabled for sparc and sparc64 architectures"
> +	depends on BR2_sparc64 || BR2_sparc
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/tio: disable for sparc and sparc64 architectures

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Sergio, All,
 > On 2020-10-25 13:34 -0300, Sergio Prado spake thusly:
 >> tio fails to build on sparc and sparc64 architectures with a
 >> redefinition of 'struct termio' error, with no proper fix or workaround
 >> for now. See discussions in [1] and [2] and picocom source code in [3].
 >> 
 >> [1] http://patchwork.ozlabs.org/project/buildroot/patch/20191227204520.1500501-1-fontaine.fabrice at gmail.com/
 >> [2] http://patchwork.ozlabs.org/project/buildroot/patch/20200511142602.46170-1-vadim4j at gmail.com/
 >> [3] https://github.com/npat-efault/picocom/blob/master/termbits2.h#L37
 >> 
 >> So let's disable it for now on sparc and sparc64 architectures.
 >> 
 >> Fixes:
 >> http://autobuild.buildroot.org/results/e041dde522e2a774f528d4377f67ca0a8a99461c
 >> http://autobuild.buildroot.org/results/6e1f9fe47e8b2cfdf5effcb7bbc697189f54ff2c
 >> http://autobuild.buildroot.org/results/49708fe6f404fea6761f102af854e98d6a1d43c1
 >> Many more...
 >> 
 >> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>

 > Eventually applied to master, thanks.

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard