* [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
@ 2021-04-17 15:35 ` Fabio M. De Francesco
0 siblings, 0 replies; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-17 15:35 UTC (permalink / raw)
To: outreachy-kernel, dri-devel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: Fabio M. De Francesco
Added a 'break' in the default case of a switch selection statement.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index e3d77dfefb0a..fc40aa0adf73 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct drm_device *dev,
return entry;
break;
default: /* Make gcc happy */
- ;
+ break;
}
if (entry->map->offset == map->offset)
return entry;
--
2.31.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
@ 2021-04-17 15:35 ` Fabio M. De Francesco
0 siblings, 0 replies; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-17 15:35 UTC (permalink / raw)
To: outreachy-kernel, dri-devel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: Fabio M. De Francesco
Added a 'break' in the default case of a switch selection statement.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/gpu/drm/drm_bufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index e3d77dfefb0a..fc40aa0adf73 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct drm_device *dev,
return entry;
break;
default: /* Make gcc happy */
- ;
+ break;
}
if (entry->map->offset == map->offset)
return entry;
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
2021-04-17 15:35 ` Fabio M. De Francesco
@ 2021-04-17 15:45 ` Julia Lawall
-1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-17 15:45 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: David Airlie, outreachy-kernel, dri-devel, Thomas Zimmermann
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> Added a 'break' in the default case of a switch selection statement.
Why?
julia
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/gpu/drm/drm_bufs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> index e3d77dfefb0a..fc40aa0adf73 100644
> --- a/drivers/gpu/drm/drm_bufs.c
> +++ b/drivers/gpu/drm/drm_bufs.c
> @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct drm_device *dev,
> return entry;
> break;
> default: /* Make gcc happy */
> - ;
> + break;
> }
> if (entry->map->offset == map->offset)
> return entry;
> --
> 2.31.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-fmdefrancesco%40gmail.com.
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
@ 2021-04-17 15:45 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-17 15:45 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: outreachy-kernel, dri-devel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> Added a 'break' in the default case of a switch selection statement.
Why?
julia
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/gpu/drm/drm_bufs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> index e3d77dfefb0a..fc40aa0adf73 100644
> --- a/drivers/gpu/drm/drm_bufs.c
> +++ b/drivers/gpu/drm/drm_bufs.c
> @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct drm_device *dev,
> return entry;
> break;
> default: /* Make gcc happy */
> - ;
> + break;
> }
> if (entry->map->offset == map->offset)
> return entry;
> --
> 2.31.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-fmdefrancesco%40gmail.com.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
2021-04-17 15:45 ` Julia Lawall
@ 2021-04-17 16:03 ` Fabio M. De Francesco
-1 siblings, 0 replies; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-17 16:03 UTC (permalink / raw)
To: Julia Lawall; +Cc: David Airlie, outreachy-kernel, dri-devel, Thomas Zimmermann
On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > Added a 'break' in the default case of a switch selection statement.
>
> Why?
>
GCC issues a warning, even if it is not strictly necessary for the code to
work properly. Do you think that I have to explain in the patch log the reason
why I made that change?
Thanks,
Fabio
>
> julia
>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > drivers/gpu/drm/drm_bufs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> > index e3d77dfefb0a..fc40aa0adf73 100644
> > --- a/drivers/gpu/drm/drm_bufs.c
> > +++ b/drivers/gpu/drm/drm_bufs.c
> > @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct
> > drm_device *dev,>
> > return entry;
> >
> > break;
> >
> > default: /* Make gcc happy */
> >
> > - ;
> > + break;
> >
> > }
> > if (entry->map->offset == map->offset)
> >
> > return entry;
> >
> > --
> > 2.31.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group. To unsubscribe from this group and stop
receiving
> > emails from it, send an email to
> > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion on
> > the web visit
> > https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-f
> > mdefrancesco%40gmail.com.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
@ 2021-04-17 16:03 ` Fabio M. De Francesco
0 siblings, 0 replies; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-17 16:03 UTC (permalink / raw)
To: Julia Lawall
Cc: outreachy-kernel, dri-devel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > Added a 'break' in the default case of a switch selection statement.
>
> Why?
>
GCC issues a warning, even if it is not strictly necessary for the code to
work properly. Do you think that I have to explain in the patch log the reason
why I made that change?
Thanks,
Fabio
>
> julia
>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > drivers/gpu/drm/drm_bufs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> > index e3d77dfefb0a..fc40aa0adf73 100644
> > --- a/drivers/gpu/drm/drm_bufs.c
> > +++ b/drivers/gpu/drm/drm_bufs.c
> > @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct
> > drm_device *dev,>
> > return entry;
> >
> > break;
> >
> > default: /* Make gcc happy */
> >
> > - ;
> > + break;
> >
> > }
> > if (entry->map->offset == map->offset)
> >
> > return entry;
> >
> > --
> > 2.31.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group. To unsubscribe from this group and stop
receiving
> > emails from it, send an email to
> > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion on
> > the web visit
> > https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-f
> > mdefrancesco%40gmail.com.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
2021-04-17 16:03 ` Fabio M. De Francesco
@ 2021-04-17 16:04 ` Julia Lawall
-1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-17 16:04 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: David Airlie, outreachy-kernel, dri-devel, Thomas Zimmermann
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> > On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > > Added a 'break' in the default case of a switch selection statement.
> >
> > Why?
> >
> GCC issues a warning, even if it is not strictly necessary for the code to
> work properly. Do you think that I have to explain in the patch log the reason
> why I made that change?
It would be helpful.
julia
>
> Thanks,
>
> Fabio
> >
> > julia
> >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >
> > > drivers/gpu/drm/drm_bufs.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> > > index e3d77dfefb0a..fc40aa0adf73 100644
> > > --- a/drivers/gpu/drm/drm_bufs.c
> > > +++ b/drivers/gpu/drm/drm_bufs.c
> > > @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct
> > > drm_device *dev,>
> > > return entry;
> > >
> > > break;
> > >
> > > default: /* Make gcc happy */
> > >
> > > - ;
> > > + break;
> > >
> > > }
> > > if (entry->map->offset == map->offset)
> > >
> > > return entry;
> > >
> > > --
> > > 2.31.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "outreachy-kernel" group. To unsubscribe from this group and stop
> receiving
> > > emails from it, send an email to
> > > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion on
> > > the web visit
> > > https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-f
> > > mdefrancesco%40gmail.com.
>
>
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case
@ 2021-04-17 16:04 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-17 16:04 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: outreachy-kernel, dri-devel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> > On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > > Added a 'break' in the default case of a switch selection statement.
> >
> > Why?
> >
> GCC issues a warning, even if it is not strictly necessary for the code to
> work properly. Do you think that I have to explain in the patch log the reason
> why I made that change?
It would be helpful.
julia
>
> Thanks,
>
> Fabio
> >
> > julia
> >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >
> > > drivers/gpu/drm/drm_bufs.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
> > > index e3d77dfefb0a..fc40aa0adf73 100644
> > > --- a/drivers/gpu/drm/drm_bufs.c
> > > +++ b/drivers/gpu/drm/drm_bufs.c
> > > @@ -79,7 +79,7 @@ static struct drm_map_list *drm_find_matching_map(struct
> > > drm_device *dev,>
> > > return entry;
> > >
> > > break;
> > >
> > > default: /* Make gcc happy */
> > >
> > > - ;
> > > + break;
> > >
> > > }
> > > if (entry->map->offset == map->offset)
> > >
> > > return entry;
> > >
> > > --
> > > 2.31.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "outreachy-kernel" group. To unsubscribe from this group and stop
> receiving
> > > emails from it, send an email to
> > > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion on
> > > the web visit
> > > https://groups.google.com/d/msgid/outreachy-kernel/20210417153540.22017-1-f
> > > mdefrancesco%40gmail.com.
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-17 16:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 15:35 [PATCH Resend] drm/drm_bufs.c: In switch, add break in default case Fabio M. De Francesco
2021-04-17 15:35 ` Fabio M. De Francesco
2021-04-17 15:45 ` [Outreachy kernel] " Julia Lawall
2021-04-17 15:45 ` Julia Lawall
2021-04-17 16:03 ` Fabio M. De Francesco
2021-04-17 16:03 ` Fabio M. De Francesco
2021-04-17 16:04 ` Julia Lawall
2021-04-17 16:04 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.