From: Matthew Wilcox <willy@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: "brouer@redhat.com" <brouer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"mcroce@linux.microsoft.com" <mcroce@linux.microsoft.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"arnd@kernel.org" <arnd@kernel.org>, "hch@lst.de" <hch@lst.de>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head
Date: Sat, 17 Apr 2021 22:28:43 +0100 [thread overview]
Message-ID: <20210417212843.GT2531743@casper.infradead.org> (raw)
In-Reply-To: <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com>
On Sat, Apr 17, 2021 at 09:13:45PM +0000, David Laight wrote:
> > struct { /* page_pool used by netstack */
> > - /**
> > - * @dma_addr: might require a 64-bit value on
> > - * 32-bit architectures.
> > - */
> > + unsigned long pp_magic;
> > + unsigned long xmi;
> > + unsigned long _pp_mapping_pad;
> > unsigned long dma_addr[2];
> > };
>
> You've deleted the comment.
Yes. It no longer added any value. You can see dma_addr now occupies
two words.
> I also think there should be a comment that dma_addr[0]
> must be aliased to ->index.
That's not a requirement. Moving the pfmemalloc indicator is a
requirement so that we _can_ use index, but there's no requirement about
how index is used.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: "arnd@kernel.org" <arnd@kernel.org>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mgorman@suse.de" <mgorman@suse.de>,
"brouer@redhat.com" <brouer@redhat.com>,
"mcroce@linux.microsoft.com" <mcroce@linux.microsoft.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"hch@lst.de" <hch@lst.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head
Date: Sat, 17 Apr 2021 22:28:43 +0100 [thread overview]
Message-ID: <20210417212843.GT2531743@casper.infradead.org> (raw)
In-Reply-To: <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com>
On Sat, Apr 17, 2021 at 09:13:45PM +0000, David Laight wrote:
> > struct { /* page_pool used by netstack */
> > - /**
> > - * @dma_addr: might require a 64-bit value on
> > - * 32-bit architectures.
> > - */
> > + unsigned long pp_magic;
> > + unsigned long xmi;
> > + unsigned long _pp_mapping_pad;
> > unsigned long dma_addr[2];
> > };
>
> You've deleted the comment.
Yes. It no longer added any value. You can see dma_addr now occupies
two words.
> I also think there should be a comment that dma_addr[0]
> must be aliased to ->index.
That's not a requirement. Moving the pfmemalloc indicator is a
requirement so that we _can_ use index, but there's no requirement about
how index is used.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: "brouer@redhat.com" <brouer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"mcroce@linux.microsoft.com" <mcroce@linux.microsoft.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"arnd@kernel.org" <arnd@kernel.org>, "hch@lst.de" <hch@lst.de>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head
Date: Sat, 17 Apr 2021 22:28:43 +0100 [thread overview]
Message-ID: <20210417212843.GT2531743@casper.infradead.org> (raw)
In-Reply-To: <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com>
On Sat, Apr 17, 2021 at 09:13:45PM +0000, David Laight wrote:
> > struct { /* page_pool used by netstack */
> > - /**
> > - * @dma_addr: might require a 64-bit value on
> > - * 32-bit architectures.
> > - */
> > + unsigned long pp_magic;
> > + unsigned long xmi;
> > + unsigned long _pp_mapping_pad;
> > unsigned long dma_addr[2];
> > };
>
> You've deleted the comment.
Yes. It no longer added any value. You can see dma_addr now occupies
two words.
> I also think there should be a comment that dma_addr[0]
> must be aliased to ->index.
That's not a requirement. Moving the pfmemalloc indicator is a
requirement so that we _can_ use index, but there's no requirement about
how index is used.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: "brouer@redhat.com" <brouer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"mcroce@linux.microsoft.com" <mcroce@linux.microsoft.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"arnd@kernel.org" <arnd@kernel.org>, "hch@lst.de" <hch@lst.de>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"mgorman@suse.de" <mgorman@suse.de>
Subject: Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head
Date: Sat, 17 Apr 2021 22:28:43 +0100 [thread overview]
Message-ID: <20210417212843.GT2531743@casper.infradead.org> (raw)
In-Reply-To: <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com>
On Sat, Apr 17, 2021 at 09:13:45PM +0000, David Laight wrote:
> > struct { /* page_pool used by netstack */
> > - /**
> > - * @dma_addr: might require a 64-bit value on
> > - * 32-bit architectures.
> > - */
> > + unsigned long pp_magic;
> > + unsigned long xmi;
> > + unsigned long _pp_mapping_pad;
> > unsigned long dma_addr[2];
> > };
>
> You've deleted the comment.
Yes. It no longer added any value. You can see dma_addr now occupies
two words.
> I also think there should be a comment that dma_addr[0]
> must be aliased to ->index.
That's not a requirement. Moving the pfmemalloc indicator is a
requirement so that we _can_ use index, but there's no requirement about
how index is used.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-17 21:29 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 23:07 [PATCH 0/2] Change struct page layout for page_pool Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` [PATCH 1/2] mm: Fix struct page layout on 32-bit systems Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-17 1:08 ` kernel test robot
2021-04-17 1:08 ` kernel test robot
2021-04-17 1:08 ` kernel test robot
2021-04-17 1:08 ` kernel test robot
2021-04-17 2:45 ` Matthew Wilcox
2021-04-17 2:45 ` Matthew Wilcox
2021-04-17 2:45 ` Matthew Wilcox
2021-04-17 2:45 ` Matthew Wilcox
2021-04-17 18:32 ` Ilias Apalodimas
2021-04-17 18:32 ` Ilias Apalodimas
2021-04-17 18:32 ` Ilias Apalodimas
2021-04-17 18:32 ` Ilias Apalodimas
2021-04-17 20:22 ` Matthew Wilcox
2021-04-17 20:22 ` Matthew Wilcox
2021-04-17 20:22 ` Matthew Wilcox
2021-04-17 20:22 ` Matthew Wilcox
2021-04-18 11:21 ` Ilias Apalodimas
2021-04-18 11:21 ` Ilias Apalodimas
2021-04-18 11:21 ` Ilias Apalodimas
2021-04-18 11:21 ` Ilias Apalodimas
2021-04-17 21:18 ` David Laight
2021-04-17 21:18 ` David Laight
2021-04-17 21:18 ` David Laight
2021-04-17 21:18 ` David Laight
2021-04-17 21:18 ` David Laight
2021-04-17 22:45 ` Matthew Wilcox
2021-04-17 22:45 ` Matthew Wilcox
2021-04-17 22:45 ` Matthew Wilcox
2021-04-17 22:45 ` Matthew Wilcox
2021-04-17 22:45 ` Matthew Wilcox
2021-04-20 2:48 ` Vineet Gupta
2021-04-20 2:48 ` Vineet Gupta
2021-04-20 2:48 ` Vineet Gupta
2021-04-20 2:48 ` Vineet Gupta
2021-04-20 2:48 ` Vineet Gupta
2021-04-20 3:10 ` Matthew Wilcox
2021-04-20 3:10 ` Matthew Wilcox
2021-04-20 3:10 ` Matthew Wilcox
2021-04-20 3:10 ` Matthew Wilcox
2021-04-20 3:10 ` Matthew Wilcox
2021-04-20 7:07 ` Arnd Bergmann
2021-04-20 7:07 ` Arnd Bergmann
2021-04-20 7:07 ` Arnd Bergmann
2021-04-20 7:07 ` Arnd Bergmann
2021-04-20 7:07 ` Arnd Bergmann
2021-04-20 21:14 ` Vineet Gupta
2021-04-20 21:14 ` Vineet Gupta
2021-04-20 21:14 ` Vineet Gupta
2021-04-20 21:14 ` Vineet Gupta
2021-04-20 21:14 ` Vineet Gupta
2021-04-20 21:20 ` Arnd Bergmann
2021-04-20 21:20 ` Arnd Bergmann
2021-04-20 21:20 ` Arnd Bergmann
2021-04-20 21:20 ` Arnd Bergmann
2021-04-20 21:20 ` Arnd Bergmann
2021-04-21 5:50 ` hch
2021-04-21 5:50 ` hch
2021-04-21 5:50 ` hch
2021-04-21 5:50 ` hch
2021-04-21 5:50 ` hch
2021-04-21 8:43 ` David Laight
2021-04-21 8:43 ` David Laight
2021-04-21 8:43 ` David Laight
2021-04-21 8:43 ` David Laight
2021-04-21 8:43 ` David Laight
2021-04-21 8:58 ` Arnd Bergmann
2021-04-21 8:58 ` Arnd Bergmann
2021-04-21 8:58 ` Arnd Bergmann
2021-04-21 8:58 ` Arnd Bergmann
2021-04-21 8:58 ` Arnd Bergmann
2021-04-20 7:39 ` Geert Uytterhoeven
2021-04-20 7:39 ` Geert Uytterhoeven
2021-04-20 7:39 ` Geert Uytterhoeven
2021-04-20 7:39 ` Geert Uytterhoeven
2021-04-20 7:39 ` Geert Uytterhoeven
2021-04-20 8:39 ` David Laight
2021-04-20 8:39 ` David Laight
2021-04-20 8:39 ` David Laight
2021-04-20 8:39 ` David Laight
2021-04-20 11:32 ` Matthew Wilcox
2021-04-20 11:32 ` Matthew Wilcox
2021-04-20 11:32 ` Matthew Wilcox
2021-04-20 11:32 ` Matthew Wilcox
2021-04-17 7:34 ` Jesper Dangaard Brouer
2021-04-17 7:34 ` Jesper Dangaard Brouer
2021-04-17 7:34 ` Jesper Dangaard Brouer
2021-04-17 7:34 ` Jesper Dangaard Brouer
2021-04-20 7:21 ` Rasmus Villemoes
2021-04-20 7:21 ` Rasmus Villemoes
2021-04-20 7:21 ` Rasmus Villemoes
2021-04-20 7:21 ` Rasmus Villemoes
2021-04-16 23:07 ` [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-16 23:07 ` Matthew Wilcox (Oracle)
2021-04-17 21:13 ` David Laight
2021-04-17 21:13 ` David Laight
2021-04-17 21:13 ` David Laight
2021-04-17 21:13 ` David Laight
2021-04-17 21:13 ` David Laight
2021-04-17 21:28 ` Matthew Wilcox [this message]
2021-04-17 21:28 ` Matthew Wilcox
2021-04-17 21:28 ` Matthew Wilcox
2021-04-17 21:28 ` Matthew Wilcox
2021-04-17 21:28 ` Matthew Wilcox
2021-04-20 4:03 ` [PATCH 0/2] Change struct page layout for page_pool Michael Ellerman
2021-04-20 4:03 ` Michael Ellerman
2021-04-20 4:03 ` Michael Ellerman
2021-04-20 4:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417212843.GT2531743@casper.infradead.org \
--to=willy@infradead.org \
--cc=David.Laight@aculab.com \
--cc=arnd@kernel.org \
--cc=brouer@redhat.com \
--cc=grygorii.strashko@ti.com \
--cc=hch@lst.de \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcroce@linux.microsoft.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.