From: "Paul A. Clarke" <pc@us.ibm.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: acme@kernel.org, maddy@linux.vnet.ibm.com,
atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
jolsa@redhat.com, mpe@ellerman.id.au,
ravi.bangoria@linux.ibm.com, linux-perf-users@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf vendor events: Initial json/events list for power10 platform
Date: Sun, 18 Apr 2021 16:08:38 -0500 [thread overview]
Message-ID: <20210418210838.GA1845018@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <20210417091850.596023-1-kjain@linux.ibm.com>
On Sat, Apr 17, 2021 at 02:48:50PM +0530, Kajol Jain wrote:
> Patch adds initial json/events for POWER10.
I was able to apply, build, and run perf with these changes,
and every new event at least ran successfully with
`perf stat`.
Pedantically, there is a lot of inconsistency as to whether
the `BriefDescription` ends with a period or not, and whether
there is an extra space at the end.
Regardless, LGTM.
Tested-by: Paul A. Clarke <pc@us.ibm.com>
Reviewed-by: Paul A. Clarke <pc@us.ibm.com>
PC
WARNING: multiple messages have this Message-ID (diff)
From: "Paul A. Clarke" <pc@us.ibm.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: ravi.bangoria@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
acme@kernel.org, linux-perf-users@vger.kernel.org,
maddy@linux.vnet.ibm.com, jolsa@redhat.com
Subject: Re: [PATCH] perf vendor events: Initial json/events list for power10 platform
Date: Sun, 18 Apr 2021 16:08:38 -0500 [thread overview]
Message-ID: <20210418210838.GA1845018@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <20210417091850.596023-1-kjain@linux.ibm.com>
On Sat, Apr 17, 2021 at 02:48:50PM +0530, Kajol Jain wrote:
> Patch adds initial json/events for POWER10.
I was able to apply, build, and run perf with these changes,
and every new event at least ran successfully with
`perf stat`.
Pedantically, there is a lot of inconsistency as to whether
the `BriefDescription` ends with a period or not, and whether
there is an extra space at the end.
Regardless, LGTM.
Tested-by: Paul A. Clarke <pc@us.ibm.com>
Reviewed-by: Paul A. Clarke <pc@us.ibm.com>
PC
next prev parent reply other threads:[~2021-04-18 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 9:18 [PATCH] perf vendor events: Initial json/events list for power10 platform Kajol Jain
2021-04-17 9:18 ` Kajol Jain
2021-04-18 21:08 ` Paul A. Clarke [this message]
2021-04-18 21:08 ` Paul A. Clarke
2021-04-19 10:25 ` kajoljain
2021-04-19 10:25 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418210838.GA1845018@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com \
--to=pc@us.ibm.com \
--cc=acme@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.