[PATCH] Remove code for disabling ID protection

[PATCH] Remove code for disabling ID protection

[Kelvin Cao]

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

ID protection is a static setting in the Switchtec config file. With
ID protection enabled, only posted requests with requester IDs in the
requester ID table will be allowed to access the NT windows. Otherwise
all posted requests are allowed. ID protect is not applicable to
non-posted requests.

There's no need to disable it in the driver as we have already configured
the requester IDs. The driver works no matter this setting is enabled or
not.

Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
---
 drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 3 ---
 include/linux/switchtec.h              | 2 --
 2 files changed, 5 deletions(-)

diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 4c6eb61a6ac6..700a6218e72e 100644
--- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
+++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
@@ -966,9 +966,6 @@ static int config_req_id_table(struct switchtec_ntb *sndev,
 	if (rc)
 		return rc;
 
-	iowrite32(NTB_PART_CTRL_ID_PROT_DIS1,
-		  &mmio_ctrl->partition_ctrl);
-
 	for (i = 0; i < count; i++) {
 		iowrite32(req_ids[i] << 16 | NTB_CTRL_REQ_ID_EN,
 			  &mmio_ctrl->req_id_table[i]);
diff --git a/include/linux/switchtec.h b/include/linux/switchtec.h
index 082f1d51957a..76dc6d2085eb 100644
--- a/include/linux/switchtec.h
+++ b/include/linux/switchtec.h
@@ -336,8 +336,6 @@ enum {
 	NTB_CTRL_REQ_ID_EN = 1 << 0,
 
 	NTB_CTRL_LUT_EN = 1 << 0,
-
-	NTB_PART_CTRL_ID_PROT_DIS = 1 << 0,
 };
 
 struct ntb_ctrl_regs {
-- 
2.25.1

[PATCH] Remove code for disabling ID protection

[Kelvin Cao]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

ID protection is a static setting in the Switchtec config file. With
ID protection enabled, only posted requests with requester IDs in the
requester ID table will be allowed to access the NT windows. Otherwise
all posted requests are allowed. ID protect is not applicable to
non-posted requests.

There's no need to disable it in the driver as we have already configured
the requester IDs. The driver works no matter this setting is enabled or
not.

Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
---
 drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 3 ---
 include/linux/switchtec.h              | 2 --
 2 files changed, 5 deletions(-)

diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 4c6eb61a6ac6..700a6218e72e 100644
--- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
+++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
@@ -966,9 +966,6 @@ static int config_req_id_table(struct switchtec_ntb *sndev,
 	if (rc)
 		return rc;
 
-	iowrite32(NTB_PART_CTRL_ID_PROT_DIS,
-		  &mmio_ctrl->partition_ctrl);
-
 	for (i = 0; i < count; i++) {
 		iowrite32(req_ids[i] << 16 | NTB_CTRL_REQ_ID_EN,
 			  &mmio_ctrl->req_id_table[i]);
diff --git a/include/linux/switchtec.h b/include/linux/switchtec.h
index 082f1d51957a..76dc6d2085eb 100644
--- a/include/linux/switchtec.h
+++ b/include/linux/switchtec.h
@@ -336,8 +336,6 @@ enum {
 	NTB_CTRL_REQ_ID_EN = 1 << 0,
 
 	NTB_CTRL_LUT_EN = 1 << 0,
-
-	NTB_PART_CTRL_ID_PROT_DIS = 1 << 0,
 };
 
 struct ntb_ctrl_regs {
-- 
2.25.1

[PATCH] Remove code for disabling ID protection

[Kelvin Cao]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

ID protection is a static setting in the Switchtec config file. With
ID protection enabled, only posted requests with requester IDs in the
requester ID table will be allowed to access the NT windows. Otherwise
all posted requests are allowed. ID protect is not applicable to
non-posted requests.

There's no need to disable it in the driver as we have already configured
the requester IDs. The driver works no matter this setting is enabled or
not.

Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
---
 drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 3 ---
 include/linux/switchtec.h              | 2 --
 2 files changed, 5 deletions(-)

diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 4c6eb61a6ac6..700a6218e72e 100644
--- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
+++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
@@ -966,9 +966,6 @@ static int config_req_id_table(struct switchtec_ntb *sndev,
 	if (rc)
 		return rc;
 
-	iowrite32(NTB_PART_CTRL_ID_PROT_DIS,
-		  &mmio_ctrl->partition_ctrl);
-
 	for (i = 0; i < count; i++) {
 		iowrite32(req_ids[i] << 16 | NTB_CTRL_REQ_ID_EN,
 			  &mmio_ctrl->req_id_table[i]);
diff --git a/include/linux/switchtec.h b/include/linux/switchtec.h
index 082f1d51957a..76dc6d2085eb 100644
--- a/include/linux/switchtec.h
+++ b/include/linux/switchtec.h
@@ -336,8 +336,6 @@ enum {
 	NTB_CTRL_REQ_ID_EN = 1 << 0,
 
 	NTB_CTRL_LUT_EN = 1 << 0,
-
-	NTB_PART_CTRL_ID_PROT_DIS = 1 << 0,
 };
 
 struct ntb_ctrl_regs {
-- 
2.25.1