All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
	"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
	"dmitrym@microsoft.com" <dmitrym@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW
Date: Mon, 19 Apr 2021 22:45:16 +0300	[thread overview]
Message-ID: <20210419224516.54b7c446@sovereign> (raw)
In-Reply-To: <DM6PR12MB394543C3B31BEE2DA0315C05A4499@DM6PR12MB3945.namprd12.prod.outlook.com>

Hi Tal,

2021-04-19 18:06 (UTC+0000), Tal Shnaiderman:
> I also noticed warnings in clang on my setup that are related to rte_os_shim.h:
> 
> [185/314] Compiling C object drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj.
> In file included from ../drivers/common/mlx5/mlx5_common_mp.c:13:
> In file included from ..\drivers\common/mlx5/mlx5_common_utils.h:8:
> In file included from ..\drivers\common/mlx5/mlx5_common.h:17:
> ..\lib/librte_eal/windows/include\rte_os_shim.h:22:51: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
> #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__)
>                                                   ^
> However don't see it in CI, I'm using clang version 9.0.1

This warning only appears with --buildtype=debug, that's why I missed it.
I don't see a good way to fix it except #define open _open,
RTE_FMT_xxx approach is not applicable here.

  parent reply	other threads:[~2021-04-19 19:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 17:08 [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW Tal Shnaiderman
2021-04-18 18:13 ` Thomas Monjalon
2021-04-18 19:04   ` Tal Shnaiderman
2021-04-18 20:23     ` Dmitry Kozlyuk
2021-04-19  6:57       ` Tal Shnaiderman
2021-04-19 18:06         ` Tal Shnaiderman
2021-04-19 18:15           ` Thomas Monjalon
2021-04-19 19:29             ` [dpdk-dev] [dpdk-ci] " Aaron Conole
2021-04-19 20:09               ` Dmitry Kozlyuk
2021-04-19 20:33                 ` Lincoln Lavoie
2021-04-20 11:01                 ` Tal Shnaiderman
2021-04-19 19:45           ` Dmitry Kozlyuk [this message]
2021-04-19 18:55         ` [dpdk-dev] " Dmitry Kozlyuk
2021-04-21 16:09 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-04-26 15:58   ` Dmitry Kozlyuk
2021-05-04 17:17     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419224516.54b7c446@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.