All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
	"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
	"dmitrym@microsoft.com" <dmitrym@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW
Date: Sun, 18 Apr 2021 19:04:55 +0000	[thread overview]
Message-ID: <DM6PR12MB39458005CDF6F1EEE5F6AA84A44A9@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2018619.JnGxiWPmQR@thomas>

> Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW
> 
> External email: Use caution opening links or attachments
> 
> 
> 18/04/2021 19:08, Tal Shnaiderman:
> > the strncasecmp marco defined in rte_os_shim.h is already defined in
> > MinGW-w64, as a result the compiler prints out the warning below on
> > function redefinition whenever compiling a file including the header.
> >
> > ..\lib/librte_eal/windows/include/rte_os_shim.h:21:
> > warning: "strncasecmp" redefined
> > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
> 
> Why the tests are passing? Are we allowing warnings in build test?

It's a good question, I see CI is passing without warnings, Dmitry can you reproduce it?

On my side the collision is with the following file:

C:/mingw-w64/x86_64/mingw64/x86_64-w64-mingw32/include/string.h:119: note: this is the location of the previous definition
 #define strncasecmp _strnicmp

I'm using:
-gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0
-meson 0.53.2

> 
> > Fixed by defining the marco only to the clang compiler.
> 
> That's a very common typo: s/marco/macro/
> 

Thanks, will fix in v2 if this patch is indeed needed.

> 




  reply	other threads:[~2021-04-18 19:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 17:08 [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW Tal Shnaiderman
2021-04-18 18:13 ` Thomas Monjalon
2021-04-18 19:04   ` Tal Shnaiderman [this message]
2021-04-18 20:23     ` Dmitry Kozlyuk
2021-04-19  6:57       ` Tal Shnaiderman
2021-04-19 18:06         ` Tal Shnaiderman
2021-04-19 18:15           ` Thomas Monjalon
2021-04-19 19:29             ` [dpdk-dev] [dpdk-ci] " Aaron Conole
2021-04-19 20:09               ` Dmitry Kozlyuk
2021-04-19 20:33                 ` Lincoln Lavoie
2021-04-20 11:01                 ` Tal Shnaiderman
2021-04-19 19:45           ` [dpdk-dev] " Dmitry Kozlyuk
2021-04-19 18:55         ` Dmitry Kozlyuk
2021-04-21 16:09 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-04-26 15:58   ` Dmitry Kozlyuk
2021-05-04 17:17     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB39458005CDF6F1EEE5F6AA84A44A9@DM6PR12MB3945.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.