From: Chen Yu <yu.c.chen@intel.com>
To: Terry Bowman <terry.bowman@amd.com>
Cc: lenb@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, bp@suse.de,
calvin.walton@kepstin.ca, wei.huang2@amd.com
Subject: Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors
Date: Tue, 20 Apr 2021 10:03:36 +0800 [thread overview]
Message-ID: <20210420020336.GA386151@chenyu-desktop> (raw)
In-Reply-To: <20210419195812.147710-1-terry.bowman@amd.com>
On Mon, Apr 19, 2021 at 02:58:12PM -0500, Terry Bowman wrote:
> Turbostat fails to correctly collect and display RAPL summary information
> on Family 17h and 19h AMD processors. Running turbostat on these processors
> returns immediately. If turbostat is working correctly then RAPL summary
> data is displayed until the user provided command completes. If a command
> is not provided by the user then turbostat is designed to continuously
> display RAPL information until interrupted.
>
> The issue is due to offset_to_idx() and idx_to_offset() missing support for
> AMD MSR addresses/offsets. offset_to_idx()'s switch statement is missing
> cases for AMD MSRs and idx_to_offset() does not include a path to return
> AMD MSR(s) for any idx.
>
> The solution is add AMD MSR support to offset_to_idx() and idx_to_offset().
> These functions are split-out and renamed along architecture vendor lines
> for supporting both AMD and Intel MSRs.
>
> Fixes: 9972d5d84d76 ("tools/power turbostat: Enable accumulate RAPL display")
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
Thanks for fixing, Terry, and previously there was a patch for this from Bas Nieuwenhuizen:
https://lkml.org/lkml/2021/3/12/682
and it is expected to have been merged in Len's branch already.
thanks,
Chenyu
next prev parent reply other threads:[~2021-04-20 1:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:58 [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors Terry Bowman
2021-04-19 23:52 ` calvin.walton
2021-04-20 2:03 ` Chen Yu [this message]
2021-04-20 8:07 ` Borislav Petkov
2021-04-20 13:15 ` Chen Yu
2021-04-20 13:28 ` Calvin Walton
2021-04-20 14:37 ` Chen Yu
2021-04-20 14:42 ` Calvin Walton
2021-04-23 12:16 ` Chen Yu
2021-04-23 12:19 ` Borislav Petkov
2021-04-23 13:34 ` Chen Yu
2021-04-23 14:32 ` Borislav Petkov
2021-04-24 1:14 ` Chen Yu
2021-04-23 14:00 ` Calvin Walton
2021-04-23 14:29 ` Borislav Petkov
2021-04-24 1:34 ` Chen Yu
2021-04-23 14:04 ` Calvin Walton
2021-04-23 14:27 ` Chen Yu
2021-04-23 15:17 ` Calvin Walton
2021-04-20 14:06 ` Artem S. Tashkinov
2021-04-20 15:25 ` Borislav Petkov
2021-04-23 12:18 ` Chen Yu
2021-04-20 13:32 ` Calvin Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420020336.GA386151@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=bp@suse.de \
--cc=calvin.walton@kepstin.ca \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=terry.bowman@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.