From: Calvin Walton <calvin.walton@kepstin.ca>
To: Chen Yu <yu.c.chen@intel.com>
Cc: Borislav Petkov <bp@suse.de>, Terry Bowman <terry.bowman@amd.com>,
lenb@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, wei.huang2@amd.com, aros@gmx.com,
rui.zhang@intel.com
Subject: Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors
Date: Fri, 23 Apr 2021 10:04:10 -0400 [thread overview]
Message-ID: <4080ac25f6c8ca4088a950eb9d63da641c020941.camel@kepstin.ca> (raw)
In-Reply-To: <20210423121607.GA426003@chenyu-desktop>
On Fri, 2021-04-23 at 20:16 +0800, Chen Yu wrote
>
> Calvin, could you please take a look at the following version if it
> is suitible?
I assume this patch is adapted from my earlier submission of the
complete fix to be an incremental fix on top of the already applied
patch? If so, you are OK to add
Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
> From b2e63fe4f02e17289414b4f61237da822df115fb Mon Sep 17 00:00:00
> 2001
> From: Calvin Walton <calvin.walton@kepstin.ca>
> Date: Fri, 23 Apr 2021 17:32:13 +0800
> Subject: [PATCH 3/5] tools/power turbostat: Fix offset overflow issue
> in index
> converting
>
> The idx_to_offset() function returns type int (32-bit signed), but
> MSR_PKG_ENERGY_STAT is greater than INT_MAX (or rather, would be
> interpreted as a negative number). The end result is that it hits
> the if (offset < 0) check in update_msr_sum() resulting in the timer
> callback for updating the stat in the background when long durations
> are used to not happen. The similar issue exists in offset_to_idx()
> and update_msr_sum().
>
> This patch fixes this issue by converting the 'int' type to 'off_t'
> accordingly.
This patch covers all of the places I know about which had type issues
- it should be good. Thanks!
--
Calvin Walton <calvin.walton@kepstin.ca>
next prev parent reply other threads:[~2021-04-23 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:58 [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors Terry Bowman
2021-04-19 23:52 ` calvin.walton
2021-04-20 2:03 ` Chen Yu
2021-04-20 8:07 ` Borislav Petkov
2021-04-20 13:15 ` Chen Yu
2021-04-20 13:28 ` Calvin Walton
2021-04-20 14:37 ` Chen Yu
2021-04-20 14:42 ` Calvin Walton
2021-04-23 12:16 ` Chen Yu
2021-04-23 12:19 ` Borislav Petkov
2021-04-23 13:34 ` Chen Yu
2021-04-23 14:32 ` Borislav Petkov
2021-04-24 1:14 ` Chen Yu
2021-04-23 14:00 ` Calvin Walton
2021-04-23 14:29 ` Borislav Petkov
2021-04-24 1:34 ` Chen Yu
2021-04-23 14:04 ` Calvin Walton [this message]
2021-04-23 14:27 ` Chen Yu
2021-04-23 15:17 ` Calvin Walton
2021-04-20 14:06 ` Artem S. Tashkinov
2021-04-20 15:25 ` Borislav Petkov
2021-04-23 12:18 ` Chen Yu
2021-04-20 13:32 ` Calvin Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4080ac25f6c8ca4088a950eb9d63da641c020941.camel@kepstin.ca \
--to=calvin.walton@kepstin.ca \
--cc=aros@gmx.com \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=terry.bowman@amd.com \
--cc=wei.huang2@amd.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.