[PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

[PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The pointer tmp_hdr is being assigned a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/lpfc/lpfc_sli.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 06ccc0157bd8..9ead564dd0c0 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17936,7 +17936,6 @@ lpfc_fc_frame_add(struct lpfc_vport *vport, struct hbq_dmabuf *dmabuf)
 	seq_dmabuf->time_stamp = jiffies;
 	lpfc_update_rcv_time_stamp(vport);
 	if (list_empty(&seq_dmabuf->dbuf.list)) {
-		temp_hdr = dmabuf->hbuf.virt;
 		list_add_tail(&dmabuf->dbuf.list, &seq_dmabuf->dbuf.list);
 		return seq_dmabuf;
 	}
-- 
2.30.2

Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

[James Smart]

On 4/20/2021 3:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

[Martin K. Petersen]

Colin,

> The pointer tmp_hdr is being assigned a value that is never read, the
> assignment is redundant and can be removed.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr

[Martin K. Petersen]

On Tue, 20 Apr 2021 11:41:23 +0100, Colin King wrote:

> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant assignment to pointer temp_hdr
      https://git.kernel.org/mkp/scsi/c/52b259908114

-- 
Martin K. Petersen	Oracle Linux Engineering