* [PATCH for-6.0?] qga: fix guest-get-disks regression
@ 2021-04-20 12:58 marcandre.lureau
2021-04-20 13:04 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: marcandre.lureau @ 2021-04-20 12:58 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, armbru
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
inadvertently removed the has_dependencies from the partition disk
info, resulting in empty list being returned.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
qga/commands-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 4299ebd96f..75dbaab68e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
partition = g_new0(GuestDiskInfo, 1);
partition->name = dev_name;
partition->partition = true;
+ partition->has_dependencies = true;
/* Add parent disk as dependent for easier tracking of hierarchy */
QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
--
2.29.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
2021-04-20 12:58 [PATCH for-6.0?] qga: fix guest-get-disks regression marcandre.lureau
@ 2021-04-20 13:04 ` Daniel P. Berrangé
2021-04-20 13:12 ` Philippe Mathieu-Daudé
2021-04-20 15:03 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2021-04-20 13:04 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, armbru
On Tue, Apr 20, 2021 at 04:58:31PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
2021-04-20 12:58 [PATCH for-6.0?] qga: fix guest-get-disks regression marcandre.lureau
2021-04-20 13:04 ` Daniel P. Berrangé
@ 2021-04-20 13:12 ` Philippe Mathieu-Daudé
2021-04-20 15:03 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-20 13:12 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel, Peter Maydell; +Cc: armbru
On 4/20/21 2:58 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 4299ebd96f..75dbaab68e 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
> partition = g_new0(GuestDiskInfo, 1);
> partition->name = dev_name;
> partition->partition = true;
> + partition->has_dependencies = true;
> /* Add parent disk as dependent for easier tracking of hierarchy */
> QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
2021-04-20 12:58 [PATCH for-6.0?] qga: fix guest-get-disks regression marcandre.lureau
2021-04-20 13:04 ` Daniel P. Berrangé
2021-04-20 13:12 ` Philippe Mathieu-Daudé
@ 2021-04-20 15:03 ` Markus Armbruster
2021-04-20 15:27 ` Peter Maydell
2 siblings, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2021-04-20 15:03 UTC (permalink / raw)
To: marcandre.lureau; +Cc: Peter Maydell, qemu-devel
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 4299ebd96f..75dbaab68e 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
> partition = g_new0(GuestDiskInfo, 1);
> partition->name = dev_name;
> partition->partition = true;
> + partition->has_dependencies = true;
> /* Add parent disk as dependent for easier tracking of hierarchy */
> QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
This is a recent regression, and the fix is as safe as they get. Please
apply for 6.0.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
2021-04-20 15:03 ` Markus Armbruster
@ 2021-04-20 15:27 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2021-04-20 15:27 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Marc-André Lureau, QEMU Developers
On Tue, 20 Apr 2021 at 16:03, Markus Armbruster <armbru@redhat.com> wrote:
>
> marcandre.lureau@redhat.com writes:
>
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> > inadvertently removed the has_dependencies from the partition disk
> > info, resulting in empty list being returned.
> >
> > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > qga/commands-posix.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > index 4299ebd96f..75dbaab68e 100644
> > --- a/qga/commands-posix.c
> > +++ b/qga/commands-posix.c
> > @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
> > partition = g_new0(GuestDiskInfo, 1);
> > partition->name = dev_name;
> > partition->partition = true;
> > + partition->has_dependencies = true;
> > /* Add parent disk as dependent for easier tracking of hierarchy */
> > QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
>
> This is a recent regression, and the fix is as safe as they get. Please
> apply for 6.0.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks; applied to master for 6.0.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-20 15:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 12:58 [PATCH for-6.0?] qga: fix guest-get-disks regression marcandre.lureau
2021-04-20 13:04 ` Daniel P. Berrangé
2021-04-20 13:12 ` Philippe Mathieu-Daudé
2021-04-20 15:03 ` Markus Armbruster
2021-04-20 15:27 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.