All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: enetc: automatically select IERB module
@ 2021-04-20 14:28 Michael Walle
  2021-04-20 18:20 ` Vladimir Oltean
  2021-04-21  0:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2021-04-20 14:28 UTC (permalink / raw)
  To: netdev, linux-kernel
  Cc: Claudiu Manoil, David S . Miller, Jakub Kicinski,
	Vladimir Oltean, Michael Walle

Now that enetc supports flow control we have to make sure the settings in
the IERB are correct. Therefore, we actually depend on the enetc-ierb
module. Previously it was possible that this module was disabled while the
enetc was enabled. Fix it by automatically select the enetc-ierb module.

Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/net/ethernet/freescale/enetc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig
index d88f60c2bb82..cdc0ff89388a 100644
--- a/drivers/net/ethernet/freescale/enetc/Kconfig
+++ b/drivers/net/ethernet/freescale/enetc/Kconfig
@@ -2,7 +2,7 @@
 config FSL_ENETC
 	tristate "ENETC PF driver"
 	depends on PCI && PCI_MSI
-	depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n
+	select FSL_ENETC_IERB
 	select FSL_ENETC_MDIO
 	select PHYLINK
 	select PCS_LYNX
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: enetc: automatically select IERB module
  2021-04-20 14:28 [PATCH net-next] net: enetc: automatically select IERB module Michael Walle
@ 2021-04-20 18:20 ` Vladimir Oltean
  2021-04-21  0:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2021-04-20 18:20 UTC (permalink / raw)
  To: Michael Walle
  Cc: netdev, linux-kernel, Claudiu Manoil, David S . Miller,
	Jakub Kicinski, Vladimir Oltean

On Tue, Apr 20, 2021 at 04:28:21PM +0200, Michael Walle wrote:
> Now that enetc supports flow control we have to make sure the settings in
> the IERB are correct. Therefore, we actually depend on the enetc-ierb
> module. Previously it was possible that this module was disabled while the
> enetc was enabled. Fix it by automatically select the enetc-ierb module.
> 
> Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---

Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: enetc: automatically select IERB module
  2021-04-20 14:28 [PATCH net-next] net: enetc: automatically select IERB module Michael Walle
  2021-04-20 18:20 ` Vladimir Oltean
@ 2021-04-21  0:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-21  0:00 UTC (permalink / raw)
  To: Michael Walle
  Cc: netdev, linux-kernel, claudiu.manoil, davem, kuba, vladimir.oltean

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 20 Apr 2021 16:28:21 +0200 you wrote:
> Now that enetc supports flow control we have to make sure the settings in
> the IERB are correct. Therefore, we actually depend on the enetc-ierb
> module. Previously it was possible that this module was disabled while the
> enetc was enabled. Fix it by automatically select the enetc-ierb module.
> 
> Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block")
> Signed-off-by: Michael Walle <michael@walle.cc>
> 
> [...]

Here is the summary with links:
  - [net-next] net: enetc: automatically select IERB module
    https://git.kernel.org/netdev/net-next/c/1b8caefaf4f0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-21  0:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 14:28 [PATCH net-next] net: enetc: automatically select IERB module Michael Walle
2021-04-20 18:20 ` Vladimir Oltean
2021-04-21  0:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.