All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next 02/12] netfilter: x_tables: remove ipt_unregister_table
Date: Tue, 20 Apr 2021 22:17:25 +0800	[thread overview]
Message-ID: <202104202220.bGSfzxTb-lkp@intel.com> (raw)
In-Reply-To: <20210420122507.505-3-fw@strlen.de>

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
        git checkout 8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/ipv4/netfilter/ip_tables.c:1773:6: warning: no previous prototype for 'ipt_unregister_table' [-Wmissing-prototypes]
    1773 | void ipt_unregister_table(struct net *net, struct xt_table *table)
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/ipt_unregister_table +1773 net/ipv4/netfilter/ip_tables.c

  1772	
> 1773	void ipt_unregister_table(struct net *net, struct xt_table *table)
  1774	{
  1775		__ipt_unregister_table(net, table);
  1776	}
  1777	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67570 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH nf-next 02/12] netfilter: x_tables: remove ipt_unregister_table
Date: Tue, 20 Apr 2021 22:17:25 +0800	[thread overview]
Message-ID: <202104202220.bGSfzxTb-lkp@intel.com> (raw)
In-Reply-To: <20210420122507.505-3-fw@strlen.de>

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
        git checkout 8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/ipv4/netfilter/ip_tables.c:1773:6: warning: no previous prototype for 'ipt_unregister_table' [-Wmissing-prototypes]
    1773 | void ipt_unregister_table(struct net *net, struct xt_table *table)
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/ipt_unregister_table +1773 net/ipv4/netfilter/ip_tables.c

  1772	
> 1773	void ipt_unregister_table(struct net *net, struct xt_table *table)
  1774	{
  1775		__ipt_unregister_table(net, table);
  1776	}
  1777	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 67570 bytes --]

  reply	other threads:[~2021-04-20 14:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 12:24 [PATCH nf-next 00/12] netfilter: remove xtables pointers from struct net Florian Westphal
2021-04-20 12:24 ` [PATCH nf-next 01/12] netfilter: ebtables: remove the 3 ebtables " Florian Westphal
2021-04-20 12:24 ` [PATCH nf-next 02/12] netfilter: x_tables: remove ipt_unregister_table Florian Westphal
2021-04-20 14:17   ` kernel test robot [this message]
2021-04-20 14:17     ` kernel test robot
2021-04-20 16:44   ` kernel test robot
2021-04-20 16:44     ` kernel test robot
2021-04-20 12:24 ` [PATCH nf-next 03/12] netfilter: add xt_find_table Florian Westphal
2021-04-20 12:24 ` [PATCH nf-next 04/12] netfilter: iptables: unregister the tables by name Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 05/12] netfilter: ip6tables: " Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 06/12] netfilter: arptables: " Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 07/12] netfilter: x_tables: remove paranoia tests Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 08/12] netfilter: xt_nat: pass table to hookfn Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 09/12] netfilter: ip_tables: pass table pointer via nf_hook_ops Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 10/12] netfilter: arp_tables: " Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 11/12] netfilter: ip6_tables: " Florian Westphal
2021-04-20 12:25 ` [PATCH nf-next 12/12] netfilter: remove all xt_table anchors from struct net Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104202220.bGSfzxTb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=fw@strlen.de \
    --cc=kbuild-all@lists.01.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.