* [PATCH v2] yavta: Fix usage documentation for --field option
@ 2021-04-21 12:18 Niklas Söderlund
2021-05-22 11:33 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2021-04-21 12:18 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Linux-Renesas, Niklas Söderlund,
Niklas Söderlund
The --field option takes an argument selecting the field order. Update
the usage text to reflect this.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
* Changes since v1
- List all valid filed values.
---
yavta.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/yavta.c b/yavta.c
index 4e5b62a96eb66f8d..1129ab245966384b 100644
--- a/yavta.c
+++ b/yavta.c
@@ -2290,7 +2290,9 @@ static void usage(const char *argv0)
printf(" --enum-formats Enumerate formats\n");
printf(" --enum-inputs Enumerate inputs\n");
printf(" --fd Use a numeric file descriptor insted of a device\n");
- printf(" --field Interlaced format field order\n");
+ printf(" --field field Set the format field order\n");
+ printf("\tValid values for field are none, top, bottom, interlaced, seq-tb, seq-bt\n");
+ printf("\talternate, interlaced-tb and interlaced-bt.\n");
printf(" --log-status Log device status\n");
printf(" --no-query Don't query capabilities on open\n");
printf(" --offset User pointer buffer offset from page start\n");
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] yavta: Fix usage documentation for --field option
2021-04-21 12:18 [PATCH v2] yavta: Fix usage documentation for --field option Niklas Söderlund
@ 2021-05-22 11:33 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2021-05-22 11:33 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Geert Uytterhoeven, Linux-Renesas, Niklas Söderlund
Hi Niklas,
Thank you for the patch.
On Wed, Apr 21, 2021 at 02:18:38PM +0200, Niklas Söderlund wrote:
> The --field option takes an argument selecting the field order. Update
> the usage text to reflect this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v1
> - List all valid filed values.
> ---
> yavta.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/yavta.c b/yavta.c
> index 4e5b62a96eb66f8d..1129ab245966384b 100644
> --- a/yavta.c
> +++ b/yavta.c
> @@ -2290,7 +2290,9 @@ static void usage(const char *argv0)
> printf(" --enum-formats Enumerate formats\n");
> printf(" --enum-inputs Enumerate inputs\n");
> printf(" --fd Use a numeric file descriptor insted of a device\n");
> - printf(" --field Interlaced format field order\n");
> + printf(" --field field Set the format field order\n");
> + printf("\tValid values for field are none, top, bottom, interlaced, seq-tb, seq-bt\n");
Missing ',' after seq-bt.
> + printf("\talternate, interlaced-tb and interlaced-bt.\n");
One may argue that it would be nice to iterate over the fields array,
but that's likely overkill.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied with the added comma.
> printf(" --log-status Log device status\n");
> printf(" --no-query Don't query capabilities on open\n");
> printf(" --offset User pointer buffer offset from page start\n");
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-22 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 12:18 [PATCH v2] yavta: Fix usage documentation for --field option Niklas Söderlund
2021-05-22 11:33 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.