From: Borislav Petkov <bp@alien8.de> To: Ashish Kalra <ashish.kalra@amd.com> Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, seanjc@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com, kexec@lists.infradead.org Subject: Re: [PATCH v13 12/12] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature. Date: Wed, 21 Apr 2021 17:32:02 +0200 [thread overview] Message-ID: <20210421153202.GC5004@zn.tnic> (raw) In-Reply-To: <20210421152220.GB14004@ashkalra_ubuntu_server> On Wed, Apr 21, 2021 at 03:22:20PM +0000, Ashish Kalra wrote: > Yes, the above mentions to get KVM_FEATURE_CPUID and then check if live > migration feature is supported, i.e., > kvm_para_has_feature(KVM_FEATURE_SEV_LIVE_MIGRATION). The above comments > are written more generically. Do not write generic comments please - write exact comments to state precisely why you're doing what you're doing. > Just to ensure that the sev_live_migration_enabled is set to TRUE before > it is used immediately next in the function. Why wouldn't it be set to true by the time the next function runs? Do you have any concrete observations where this is not the case? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: Ashish Kalra <ashish.kalra@amd.com> Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, seanjc@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com, kexec@lists.infradead.org Subject: Re: [PATCH v13 12/12] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature. Date: Wed, 21 Apr 2021 17:32:02 +0200 [thread overview] Message-ID: <20210421153202.GC5004@zn.tnic> (raw) In-Reply-To: <20210421152220.GB14004@ashkalra_ubuntu_server> On Wed, Apr 21, 2021 at 03:22:20PM +0000, Ashish Kalra wrote: > Yes, the above mentions to get KVM_FEATURE_CPUID and then check if live > migration feature is supported, i.e., > kvm_para_has_feature(KVM_FEATURE_SEV_LIVE_MIGRATION). The above comments > are written more generically. Do not write generic comments please - write exact comments to state precisely why you're doing what you're doing. > Just to ensure that the sev_live_migration_enabled is set to TRUE before > it is used immediately next in the function. Why wouldn't it be set to true by the time the next function runs? Do you have any concrete observations where this is not the case? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-04-21 15:32 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-15 15:52 [PATCH v13 00/12] Add AMD SEV guest live migration support Ashish Kalra 2021-04-15 15:53 ` [PATCH v13 01/12] KVM: SVM: Add KVM_SEV SEND_START command Ashish Kalra 2021-04-20 8:50 ` Paolo Bonzini 2021-04-15 15:53 ` [PATCH v13 02/12] KVM: SVM: Add KVM_SEND_UPDATE_DATA command Ashish Kalra 2021-04-15 15:54 ` [PATCH v13 03/12] KVM: SVM: Add KVM_SEV_SEND_FINISH command Ashish Kalra 2021-04-15 15:54 ` [PATCH v13 04/12] KVM: SVM: Add support for KVM_SEV_RECEIVE_START command Ashish Kalra 2021-04-20 8:38 ` Paolo Bonzini 2021-04-20 9:18 ` Paolo Bonzini 2021-04-15 15:55 ` [PATCH v13 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command Ashish Kalra 2021-04-20 8:40 ` Paolo Bonzini 2021-04-20 8:43 ` Paolo Bonzini 2021-04-15 15:55 ` [PATCH v13 06/12] KVM: SVM: Add KVM_SEV_RECEIVE_FINISH command Ashish Kalra 2021-04-15 15:56 ` [PATCH v13 07/12] KVM: x86: Add AMD SEV specific Hypercall3 Ashish Kalra 2021-04-15 15:57 ` [PATCH v13 08/12] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall Ashish Kalra 2021-04-20 11:10 ` Paolo Bonzini 2021-04-20 17:24 ` Sean Christopherson 2021-04-15 15:57 ` [PATCH v13 09/12] mm: x86: Invoke hypercall when page encryption status is changed Ashish Kalra 2021-04-20 9:39 ` Paolo Bonzini 2021-04-21 10:05 ` Borislav Petkov 2021-04-21 12:00 ` Paolo Bonzini 2021-04-21 14:09 ` Borislav Petkov 2021-04-21 12:12 ` Ashish Kalra 2021-04-21 13:50 ` Brijesh Singh 2021-04-21 13:52 ` Borislav Petkov 2021-04-15 15:58 ` [PATCH v13 10/12] KVM: x86: Introduce new KVM_FEATURE_SEV_LIVE_MIGRATION feature & Custom MSR Ashish Kalra 2021-04-19 23:06 ` Sean Christopherson 2021-04-20 10:49 ` Paolo Bonzini 2021-04-20 9:47 ` Paolo Bonzini 2021-04-15 15:58 ` [PATCH v13 11/12] EFI: Introduce the new AMD Memory Encryption GUID Ashish Kalra 2021-04-15 16:01 ` [PATCH v13 12/12] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature Ashish Kalra 2021-04-15 16:01 ` Ashish Kalra 2021-04-20 10:52 ` Paolo Bonzini 2021-04-20 10:52 ` Paolo Bonzini 2021-04-21 14:44 ` Borislav Petkov 2021-04-21 14:44 ` Borislav Petkov 2021-04-21 15:22 ` Ashish Kalra 2021-04-21 15:22 ` Ashish Kalra 2021-04-21 15:32 ` Borislav Petkov [this message] 2021-04-21 15:32 ` Borislav Petkov 2021-04-21 15:38 ` Paolo Bonzini 2021-04-21 15:38 ` Paolo Bonzini 2021-04-21 18:48 ` Ashish Kalra 2021-04-21 18:48 ` Ashish Kalra 2021-04-21 19:19 ` Ashish Kalra 2021-04-21 19:19 ` Ashish Kalra 2021-04-16 21:43 ` [PATCH v13 00/12] Add AMD SEV guest live migration support Steve Rutherford 2021-04-19 14:40 ` Ashish Kalra 2021-04-20 11:11 ` Paolo Bonzini 2021-04-20 18:51 ` Borislav Petkov 2021-04-20 19:08 ` Paolo Bonzini 2021-04-20 20:28 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210421153202.GC5004@zn.tnic \ --to=bp@alien8.de \ --cc=ashish.kalra@amd.com \ --cc=brijesh.singh@amd.com \ --cc=hpa@zytor.com \ --cc=joro@8bytes.org \ --cc=kexec@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=pbonzini@redhat.com \ --cc=seanjc@google.com \ --cc=srutherford@google.com \ --cc=tglx@linutronix.de \ --cc=thomas.lendacky@amd.com \ --cc=venu.busireddy@oracle.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.