From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH RESEND-2 RFC net-next 12/18] devlink: Introduce rate nodes
Date: Thu, 22 Apr 2021 06:27:53 +0800 [thread overview]
Message-ID: <202104220602.R1bSHwEF-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4266 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <1619020385-20220-13-git-send-email-dlinkin@nvidia.com>
References: <1619020385-20220-13-git-send-email-dlinkin@nvidia.com>
TO: dlinkin(a)nvidia.com
Hi,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/dlinkin-nvidia-com/devlink-rate-objects-API/20210421-235552
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git a926c025d56bb1acd8a192fca0e307331ee91b30
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: x86_64-randconfig-m001-20210421 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/core/devlink.c:1591 devlink_nl_rate_set() error: uninitialized symbol 'err'.
Old smatch warnings:
net/core/devlink.c:1604 devlink_nl_rate_set() error: uninitialized symbol 'err'.
net/core/devlink.c:6364 devlink_fmsg_prepare_skb() error: uninitialized symbol 'err'.
vim +/err +1591 net/core/devlink.c
cd76dcd68d96aa Parav Pandit 2020-12-11 1574
709d06045321cd Dmytro Linkin 2021-04-21 1575 static int devlink_nl_rate_set(struct devlink_rate *devlink_rate,
709d06045321cd Dmytro Linkin 2021-04-21 1576 const struct devlink_ops *ops,
709d06045321cd Dmytro Linkin 2021-04-21 1577 struct genl_info *info)
709d06045321cd Dmytro Linkin 2021-04-21 1578 {
709d06045321cd Dmytro Linkin 2021-04-21 1579 struct nlattr **attrs = info->attrs;
709d06045321cd Dmytro Linkin 2021-04-21 1580 u64 rate;
709d06045321cd Dmytro Linkin 2021-04-21 1581 int err;
709d06045321cd Dmytro Linkin 2021-04-21 1582
709d06045321cd Dmytro Linkin 2021-04-21 1583 if (attrs[DEVLINK_ATTR_RATE_TX_SHARE]) {
709d06045321cd Dmytro Linkin 2021-04-21 1584 rate = nla_get_u64(attrs[DEVLINK_ATTR_RATE_TX_SHARE]);
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1585 if (devlink_rate_is_leaf(devlink_rate))
709d06045321cd Dmytro Linkin 2021-04-21 1586 err = ops->rate_leaf_tx_share_set(devlink_rate, devlink_rate->priv,
709d06045321cd Dmytro Linkin 2021-04-21 1587 rate, info->extack);
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1588 else if (devlink_rate_is_node(devlink_rate))
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1589 err = ops->rate_node_tx_share_set(devlink_rate, devlink_rate->priv,
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1590 rate, info->extack);
709d06045321cd Dmytro Linkin 2021-04-21 @1591 if (err)
709d06045321cd Dmytro Linkin 2021-04-21 1592 return err;
709d06045321cd Dmytro Linkin 2021-04-21 1593 devlink_rate->tx_share = rate;
709d06045321cd Dmytro Linkin 2021-04-21 1594 }
709d06045321cd Dmytro Linkin 2021-04-21 1595
709d06045321cd Dmytro Linkin 2021-04-21 1596 if (attrs[DEVLINK_ATTR_RATE_TX_MAX]) {
709d06045321cd Dmytro Linkin 2021-04-21 1597 rate = nla_get_u64(attrs[DEVLINK_ATTR_RATE_TX_MAX]);
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1598 if (devlink_rate_is_leaf(devlink_rate))
709d06045321cd Dmytro Linkin 2021-04-21 1599 err = ops->rate_leaf_tx_max_set(devlink_rate, devlink_rate->priv,
709d06045321cd Dmytro Linkin 2021-04-21 1600 rate, info->extack);
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1601 else if (devlink_rate_is_node(devlink_rate))
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1602 err = ops->rate_node_tx_max_set(devlink_rate, devlink_rate->priv,
ddc9bb1d01c107 Dmytro Linkin 2021-04-21 1603 rate, info->extack);
709d06045321cd Dmytro Linkin 2021-04-21 1604 if (err)
709d06045321cd Dmytro Linkin 2021-04-21 1605 return err;
709d06045321cd Dmytro Linkin 2021-04-21 1606 devlink_rate->tx_max = rate;
709d06045321cd Dmytro Linkin 2021-04-21 1607 }
709d06045321cd Dmytro Linkin 2021-04-21 1608
709d06045321cd Dmytro Linkin 2021-04-21 1609 return 0;
709d06045321cd Dmytro Linkin 2021-04-21 1610 }
709d06045321cd Dmytro Linkin 2021-04-21 1611
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33141 bytes --]
next reply other threads:[~2021-04-21 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 22:27 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-21 15:52 [PATCH RESEND-2 RFC net-next 00/18] devlink: rate objects API dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 12/18] devlink: Introduce rate nodes dlinkin
2021-04-21 21:31 ` kernel test robot
2021-04-21 21:32 ` kernel test robot
2021-04-23 9:37 ` Dan Carpenter
2021-04-23 9:37 ` Dan Carpenter
2021-04-23 10:26 ` Dmytro Linkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104220602.R1bSHwEF-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.