* [PATCH] chelsio/chcr: Remove useless MODULE_VERSION
@ 2021-04-15 10:06 Vinay Kumar Yadav
2021-04-22 7:46 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Vinay Kumar Yadav @ 2021-04-15 10:06 UTC (permalink / raw)
To: herbert, linux-crypto, davem; +Cc: secdev, Vinay Kumar Yadav
kernel version describes module state more accurately.
hence remove chcr versioning.
Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
---
drivers/crypto/chelsio/chcr_core.c | 3 +--
drivers/crypto/chelsio/chcr_core.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c
index f91f9d762a45..12fdae41a967 100644
--- a/drivers/crypto/chelsio/chcr_core.c
+++ b/drivers/crypto/chelsio/chcr_core.c
@@ -184,7 +184,7 @@ static void *chcr_uld_add(const struct cxgb4_lld_info *lld)
struct uld_ctx *u_ctx;
/* Create the device and add it in the device list */
- pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION);
+ pr_info_once("%s\n", DRV_DESC);
if (!(lld->ulp_crypto & ULP_CRYPTO_LOOKASIDE))
return ERR_PTR(-EOPNOTSUPP);
@@ -309,4 +309,3 @@ module_exit(chcr_crypto_exit);
MODULE_DESCRIPTION("Crypto Co-processor for Chelsio Terminator cards.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Chelsio Communications");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/crypto/chelsio/chcr_core.h b/drivers/crypto/chelsio/chcr_core.h
index b02f981e7c32..f7c8bb95a71b 100644
--- a/drivers/crypto/chelsio/chcr_core.h
+++ b/drivers/crypto/chelsio/chcr_core.h
@@ -44,7 +44,6 @@
#include "cxgb4_uld.h"
#define DRV_MODULE_NAME "chcr"
-#define DRV_VERSION "1.0.0.0-ko"
#define DRV_DESC "Chelsio T6 Crypto Co-processor Driver"
#define MAX_PENDING_REQ_TO_HW 20
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] chelsio/chcr: Remove useless MODULE_VERSION
2021-04-15 10:06 [PATCH] chelsio/chcr: Remove useless MODULE_VERSION Vinay Kumar Yadav
@ 2021-04-22 7:46 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-04-22 7:46 UTC (permalink / raw)
To: Vinay Kumar Yadav; +Cc: linux-crypto, davem, secdev
On Thu, Apr 15, 2021 at 03:36:07PM +0530, Vinay Kumar Yadav wrote:
> kernel version describes module state more accurately.
> hence remove chcr versioning.
>
> Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
> ---
> drivers/crypto/chelsio/chcr_core.c | 3 +--
> drivers/crypto/chelsio/chcr_core.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-22 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 10:06 [PATCH] chelsio/chcr: Remove useless MODULE_VERSION Vinay Kumar Yadav
2021-04-22 7:46 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.