* [linux-next:master 14157/14231] kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static?
@ 2021-04-22 0:18 ` kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-04-22 0:18 UTC (permalink / raw)
To: Alistair Popple
Cc: kbuild-all, Linux Memory Management List, Andrew Morton,
David Hildenbrand, Dan Williams, Andy Shevchenko,
Mauro Carvalho Chehab, linux-media, Daniel Vetter, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b74523885a715463203d4ccc3cf8c85952d3701a
commit: edede6a2ecfe8553e8232eb863a7a13ef40da3a2 [14157/14231] kernel/resource: allow region_intersects users to hold resource_lock
config: i386-randconfig-s002-20210421 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=edede6a2ecfe8553e8232eb863a7a13ef40da3a2
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout edede6a2ecfe8553e8232eb863a7a13ef40da3a2
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36153 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* [linux-next:master 14157/14231] kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static? @ 2021-04-22 0:18 ` kernel test robot 0 siblings, 0 replies; 7+ messages in thread From: kernel test robot @ 2021-04-22 0:18 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1400 bytes --] tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b74523885a715463203d4ccc3cf8c85952d3701a commit: edede6a2ecfe8553e8232eb863a7a13ef40da3a2 [14157/14231] kernel/resource: allow region_intersects users to hold resource_lock config: i386-randconfig-s002-20210421 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=edede6a2ecfe8553e8232eb863a7a13ef40da3a2 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout edede6a2ecfe8553e8232eb863a7a13ef40da3a2 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 36153 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static 2021-04-22 0:18 ` kernel test robot @ 2021-04-22 0:18 ` kernel test robot -1 siblings, 0 replies; 7+ messages in thread From: kernel test robot @ 2021-04-22 0:18 UTC (permalink / raw) To: Alistair Popple Cc: kbuild-all, Linux Memory Management List, Andrew Morton, David Hildenbrand, Dan Williams, Daniel Vetter, Mauro Carvalho Chehab, linux-media, Andy Shevchenko, linux-kernel Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index 8faae19f8236e..a4bc6f66136c6 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn) } EXPORT_SYMBOL_GPL(page_is_ram); -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, - unsigned long desc) +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags, + unsigned long desc) { struct resource res; int type = 0; int other = 0; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static @ 2021-04-22 0:18 ` kernel test robot 0 siblings, 0 replies; 7+ messages in thread From: kernel test robot @ 2021-04-22 0:18 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 813 bytes --] Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index 8faae19f8236e..a4bc6f66136c6 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn) } EXPORT_SYMBOL_GPL(page_is_ram); -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, - unsigned long desc) +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags, + unsigned long desc) { struct resource res; int type = 0; int other = 0; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static 2021-04-22 0:18 ` kernel test robot (?) @ 2021-04-22 10:46 ` Andy Shevchenko -1 siblings, 0 replies; 7+ messages in thread From: Andy Shevchenko @ 2021-04-22 10:46 UTC (permalink / raw) To: kernel test robot Cc: Alistair Popple, kbuild-all, Linux Memory Management List, Andrew Morton, David Hildenbrand, Dan Williams, Daniel Vetter, Mauro Carvalho Chehab, Linux Media Mailing List, Andy Shevchenko, Linux Kernel Mailing List On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@intel.com> wrote: Can you generate a commit message as well? Otherwise looks valid to me, thanks! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > --- > resource.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 8faae19f8236e..a4bc6f66136c6 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn) > } > EXPORT_SYMBOL_GPL(page_is_ram); > > -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > - unsigned long desc) > +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > + unsigned long desc) > { > struct resource res; > int type = 0; int other = 0; -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static @ 2021-04-22 10:46 ` Andy Shevchenko 0 siblings, 0 replies; 7+ messages in thread From: Andy Shevchenko @ 2021-04-22 10:46 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1172 bytes --] On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@intel.com> wrote: Can you generate a commit message as well? Otherwise looks valid to me, thanks! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > --- > resource.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 8faae19f8236e..a4bc6f66136c6 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn) > } > EXPORT_SYMBOL_GPL(page_is_ram); > > -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > - unsigned long desc) > +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > + unsigned long desc) > { > struct resource res; > int type = 0; int other = 0; -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static @ 2021-04-22 10:46 ` Andy Shevchenko 0 siblings, 0 replies; 7+ messages in thread From: Andy Shevchenko @ 2021-04-22 10:46 UTC (permalink / raw) To: kernel test robot Cc: Alistair Popple, kbuild-all, Linux Memory Management List, Andrew Morton, David Hildenbrand, Dan Williams, Daniel Vetter, Mauro Carvalho Chehab, Linux Media Mailing List, Andy Shevchenko, Linux Kernel Mailing List On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@intel.com> wrote: Can you generate a commit message as well? Otherwise looks valid to me, thanks! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > --- > resource.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 8faae19f8236e..a4bc6f66136c6 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn) > } > EXPORT_SYMBOL_GPL(page_is_ram); > > -int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > - unsigned long desc) > +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > + unsigned long desc) > { > struct resource res; > int type = 0; int other = 0; -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-22 10:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-22 0:18 [linux-next:master 14157/14231] kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static? kernel test robot 2021-04-22 0:18 ` kernel test robot 2021-04-22 0:18 ` [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static kernel test robot 2021-04-22 0:18 ` kernel test robot 2021-04-22 10:46 ` Andy Shevchenko 2021-04-22 10:46 ` Andy Shevchenko 2021-04-22 10:46 ` Andy Shevchenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.