[hare-scsi-devel:scsi-result-rework 56/146] drivers/scsi/aha1542.c:393:29: error: 'SAM_STAT_OK' undeclared; did you mean 'SAM_STAT_GOOD'?

[hare-scsi-devel:scsi-result-rework 56/146] drivers/scsi/aha1542.c:393:29: error: 'SAM_STAT_OK' undeclared; did you mean 'SAM_STAT_GOOD'?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3448 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result-rework
head:   19720ea7b22b443a182646eef7edc36e32e7b515
commit: 6835516ab21df9c34f6104b5ff01442c47a0854c [56/146] aha1542: drop scsierr argument from makecode()
config: mips-randconfig-r016-20210421 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=6835516ab21df9c34f6104b5ff01442c47a0854c
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel scsi-result-rework
        git checkout 6835516ab21df9c34f6104b5ff01442c47a0854c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/scsi/aha1542.c: In function 'aha1542_test_port':
   drivers/scsi/aha1542.c:207:5: warning: variable 'inquiry_result' set but not used [-Wunused-but-set-variable]
     207 |  u8 inquiry_result[4];
         |     ^~~~~~~~~~~~~~
   drivers/scsi/aha1542.c: In function 'aha1542_interrupt':
>> drivers/scsi/aha1542.c:393:29: error: 'SAM_STAT_OK' undeclared (first use in this function); did you mean 'SAM_STAT_GOOD'?
     393 |    set_status_byte(tmp_cmd, SAM_STAT_OK);
         |                             ^~~~~~~~~~~
         |                             SAM_STAT_GOOD
   drivers/scsi/aha1542.c:393:29: note: each undeclared identifier is reported only once for each function it appears in


vim +393 drivers/scsi/aha1542.c

   362	
   363			tmp_cmd = aha1542->int_cmds[mbo];
   364	
   365			if (!tmp_cmd || !tmp_cmd->scsi_done) {
   366				spin_unlock_irqrestore(sh->host_lock, flags);
   367				shost_printk(KERN_WARNING, sh, "Unexpected interrupt\n");
   368				shost_printk(KERN_WARNING, sh, "tarstat=%x, hastat=%x idlun=%x ccb#=%d\n", ccb[mbo].tarstat,
   369				       ccb[mbo].hastat, ccb[mbo].idlun, mbo);
   370				return IRQ_HANDLED;
   371			}
   372			my_done = tmp_cmd->scsi_done;
   373			aha1542_free_cmd(tmp_cmd);
   374			/*
   375			 * Fetch the sense data, and tuck it away, in the required slot.  The
   376			 * Adaptec automatically fetches it, and there is no guarantee that
   377			 * we will still have it in the cdb when we come back
   378			 */
   379			if (ccb[mbo].tarstat == 2)
   380				memcpy(tmp_cmd->sense_buffer, &ccb[mbo].cdb[ccb[mbo].cdblen],
   381				       SCSI_SENSE_BUFFERSIZE);
   382	
   383	
   384			/* is there mail :-) */
   385	
   386			/* more error checking left out here */
   387			if (mbistatus != 1) {
   388				/* This is surely wrong, but I don't know what's right */
   389				set_status_byte(tmp_cmd, ccb[mbo].tarstat);
   390				set_host_byte(tmp_cmd, makecode(ccb[mbo].hastat));
   391			} else {
   392				set_host_byte(tmp_cmd, DID_OK);
 > 393				set_status_byte(tmp_cmd, SAM_STAT_OK);
   394			}
   395	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34689 bytes --]