All of lore.kernel.org
 help / color / mirror / Atom feed
* [hare-scsi-devel:scsi-result-rework 83/146] drivers/scsi/qlogicpti.c:1186:3: error: expected '}' before 'else'
@ 2021-04-22  1:05 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-22  1:05 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 7757 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result-rework
head:   19720ea7b22b443a182646eef7edc36e32e7b515
commit: 94c6207c7e0cafe0587c3cf133c28a0ae63cf856 [83/146] qlogicpti: return host byte from qlogicpti_return_status()
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=94c6207c7e0cafe0587c3cf133c28a0ae63cf856
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel scsi-result-rework
        git checkout 94c6207c7e0cafe0587c3cf133c28a0ae63cf856
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/scsi/qlogicpti.c:846:13: warning: no previous prototype for 'qlogicpti_info' [-Wmissing-prototypes]
     846 | const char *qlogicpti_info(struct Scsi_Host *host)
         |             ^~~~~~~~~~~~~~
   drivers/scsi/qlogicpti.c: In function 'qlogicpti_intr_handler':
>> drivers/scsi/qlogicpti.c:1186:3: error: expected '}' before 'else'
    1186 |   else
         |   ^~~~


vim +1186 drivers/scsi/qlogicpti.c

^1da177e4c3f41 Linus Torvalds  2005-04-16  1130  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1131  static struct scsi_cmnd *qlogicpti_intr_handler(struct qlogicpti *qpti)
^1da177e4c3f41 Linus Torvalds  2005-04-16  1132  {
^1da177e4c3f41 Linus Torvalds  2005-04-16  1133  	struct scsi_cmnd *Cmnd, *done_queue = NULL;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1134  	struct Status_Entry *sts;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1135  	u_int in_ptr, out_ptr;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1136  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1137  	if (!(sbus_readw(qpti->qregs + SBUS_STAT) & SBUS_STAT_RINT))
^1da177e4c3f41 Linus Torvalds  2005-04-16  1138  		return NULL;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1139  		
^1da177e4c3f41 Linus Torvalds  2005-04-16  1140  	in_ptr = sbus_readw(qpti->qregs + MBOX5);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1141  	sbus_writew(HCCTRL_CRIRQ, qpti->qregs + HCCTRL);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1142  	if (sbus_readw(qpti->qregs + SBUS_SEMAPHORE) & SBUS_SEMAPHORE_LCK) {
^1da177e4c3f41 Linus Torvalds  2005-04-16  1143  		switch (sbus_readw(qpti->qregs + MBOX0)) {
^1da177e4c3f41 Linus Torvalds  2005-04-16  1144  		case ASYNC_SCSI_BUS_RESET:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1145  		case EXECUTION_TIMEOUT_RESET:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1146  			qpti->send_marker = 1;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1147  			break;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1148  		case INVALID_COMMAND:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1149  		case HOST_INTERFACE_ERROR:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1150  		case COMMAND_ERROR:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1151  		case COMMAND_PARAM_ERROR:
^1da177e4c3f41 Linus Torvalds  2005-04-16  1152  			break;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1153  		};
^1da177e4c3f41 Linus Torvalds  2005-04-16  1154  		sbus_writew(0, qpti->qregs + SBUS_SEMAPHORE);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1155  	}
^1da177e4c3f41 Linus Torvalds  2005-04-16  1156  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1157  	/* This looks like a network driver! */
^1da177e4c3f41 Linus Torvalds  2005-04-16  1158  	out_ptr = qpti->res_out_ptr;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1159  	while (out_ptr != in_ptr) {
^1da177e4c3f41 Linus Torvalds  2005-04-16  1160  		u_int cmd_slot;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1161  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1162  		sts = (struct Status_Entry *) &qpti->res_cpu[out_ptr];
^1da177e4c3f41 Linus Torvalds  2005-04-16  1163  		out_ptr = NEXT_RES_PTR(out_ptr);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1164  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1165  		/* We store an index in the handle, not the pointer in
^1da177e4c3f41 Linus Torvalds  2005-04-16  1166  		 * some form.  This avoids problems due to the fact
^1da177e4c3f41 Linus Torvalds  2005-04-16  1167  		 * that the handle provided is only 32-bits. -DaveM
^1da177e4c3f41 Linus Torvalds  2005-04-16  1168  		 */
^1da177e4c3f41 Linus Torvalds  2005-04-16  1169  		cmd_slot = sts->handle;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1170  		Cmnd = qpti->cmd_slots[cmd_slot];
^1da177e4c3f41 Linus Torvalds  2005-04-16  1171  		qpti->cmd_slots[cmd_slot] = NULL;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1172  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1173  		if (sts->completion_status == CS_RESET_OCCURRED ||
^1da177e4c3f41 Linus Torvalds  2005-04-16  1174  		    sts->completion_status == CS_ABORTED ||
^1da177e4c3f41 Linus Torvalds  2005-04-16  1175  		    (sts->status_flags & STF_BUS_RESET))
^1da177e4c3f41 Linus Torvalds  2005-04-16  1176  			qpti->send_marker = 1;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1177  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1178  		if (sts->state_flags & SF_GOT_SENSE)
^1da177e4c3f41 Linus Torvalds  2005-04-16  1179  			memcpy(Cmnd->sense_buffer, sts->req_sense_data,
b80ca4f7ee36c2 FUJITA Tomonori 2008-01-13  1180  			       SCSI_SENSE_BUFFERSIZE);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1181  
94c6207c7e0caf Hannes Reinecke 2020-11-30  1182  		if (sts->hdr.entry_type == ENTRY_STATUS) {
94c6207c7e0caf Hannes Reinecke 2020-11-30  1183  			set_status_byte(Cmnd, sts->scsi_status);
94c6207c7e0caf Hannes Reinecke 2020-11-30  1184  			set_host_byte(Cmnd,
94c6207c7e0caf Hannes Reinecke 2020-11-30  1185  				qlogicpti_return_status(sts, qpti->qpti_id));
^1da177e4c3f41 Linus Torvalds  2005-04-16 @1186  		else
94c6207c7e0caf Hannes Reinecke 2020-11-30  1187  			set_host_byte(Cmnd, DID_ERROR);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1188  
dfb104ff5d8215 Boaz Harrosh    2007-09-09  1189  		if (scsi_bufflen(Cmnd))
5dc2536bb8d8ad David S. Miller 2008-08-27  1190  			dma_unmap_sg(&qpti->op->dev,
dfb104ff5d8215 Boaz Harrosh    2007-09-09  1191  				     scsi_sglist(Cmnd), scsi_sg_count(Cmnd),
^1da177e4c3f41 Linus Torvalds  2005-04-16  1192  				     Cmnd->sc_data_direction);
dfb104ff5d8215 Boaz Harrosh    2007-09-09  1193  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1194  		qpti->cmd_count[Cmnd->device->id]--;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1195  		sbus_writew(out_ptr, qpti->qregs + MBOX5);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1196  		Cmnd->host_scribble = (unsigned char *) done_queue;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1197  		done_queue = Cmnd;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1198  	}
^1da177e4c3f41 Linus Torvalds  2005-04-16  1199  	qpti->res_out_ptr = out_ptr;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1200  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1201  	return done_queue;
^1da177e4c3f41 Linus Torvalds  2005-04-16  1202  }
^1da177e4c3f41 Linus Torvalds  2005-04-16  1203  

:::::: The code at line 1186 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68906 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-04-22  1:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22  1:05 [hare-scsi-devel:scsi-result-rework 83/146] drivers/scsi/qlogicpti.c:1186:3: error: expected '}' before 'else' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.