From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next] netdevsim: Only use sampling truncation length when valid
Date: Thu, 22 Apr 2021 09:26:34 -0700 [thread overview]
Message-ID: <20210422092634.18f23f8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YIGikZ2xZhH7ZRZc@shredder.lan>
On Thu, 22 Apr 2021 19:21:37 +0300 Ido Schimmel wrote:
> > > + md->trunc_size = psample->trunc_size ? psample->trunc_size : len;
> >
> > nit: ... = psample->trunc_size ? : len; ?
>
> Yea, I don't find this form too readable and always prefer the one I
> used when it fits in a single line :)
Fair enough.
next prev parent reply other threads:[~2021-04-22 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 13:50 [PATCH net-next] netdevsim: Only use sampling truncation length when valid Ido Schimmel
2021-04-22 16:14 ` Jakub Kicinski
2021-04-22 16:21 ` Ido Schimmel
2021-04-22 16:26 ` Jakub Kicinski [this message]
2021-04-22 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422092634.18f23f8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.