[xlnx:master 11850/12130] drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock'; did you mean 'regulator_put'?

* [xlnx:master 11850/12130] drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock'; did you mean 'regulator_put'?
@ 2021-04-22  6:20 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-22  6:20 UTC (permalink / raw)
  To: Raviteja Narayanam; +Cc: kbuild-all, linux-arm-kernel, Michal Simek

[-- Attachment #1: Type: text/plain, Size: 4730 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx master
head:   0605a36e057480f3a83ae401e7ff59739da78e82
commit: a6aea4afc0f41390d36b593f455902b6fdd75685 [11850/12130] regulator: da9121: Use core regulator lock
config: nds32-randconfig-r021-20210421 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/a6aea4afc0f41390d36b593f455902b6fdd75685
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx master
        git checkout a6aea4afc0f41390d36b593f455902b6fdd75685
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/regulator/da9121-regulator.c: In function 'da9121_handle_notifier':
>> drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock'; did you mean 'regulator_put'? [-Werror=implicit-function-declaration]
     748 |   regulator_lock(rdev);
         |   ^~~~~~~~~~~~~~
         |   regulator_put
>> drivers/regulator/da9121-regulator.c:750:3: error: implicit declaration of function 'regulator_unlock'; did you mean 'regulator_enable'? [-Werror=implicit-function-declaration]
     750 |   regulator_unlock(rdev);
         |   ^~~~~~~~~~~~~~~~
         |   regulator_enable
   cc1: some warnings being treated as errors

vim +748 drivers/regulator/da9121-regulator.c

   676	
   677	static inline int da9121_handle_notifier(
   678			struct da9121 *chip, struct regulator_dev *rdev,
   679			unsigned int event_bank, unsigned int event, unsigned int ebit)
   680	{
   681		enum { R0 = 0, R1, R2, REG_MAX_NUM };
   682		unsigned long notification = 0;
   683		int ret = 0;
   684	
   685		if (event & ebit) {
   686			switch (event_bank) {
   687			case DA9121_REG_SYS_EVENT_0:
   688				switch (event & ebit) {
   689				case DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT:
   690					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT;
   691					notification |= REGULATOR_EVENT_OVER_TEMP |
   692							REGULATOR_EVENT_DISABLE;
   693					break;
   694				case DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN:
   695					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN;
   696					notification |= REGULATOR_EVENT_OVER_TEMP;
   697					break;
   698				default:
   699					dev_warn(chip->dev,
   700						 "Unhandled event in bank0 0x%02x\n",
   701						 event & ebit);
   702					ret = -EINVAL;
   703					break;
   704				}
   705				break;
   706			case DA9121_REG_SYS_EVENT_1:
   707				switch (event & ebit) {
   708				case DA9121_MASK_SYS_EVENT_1_E_OV1:
   709					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OV1;
   710					notification |= REGULATOR_EVENT_REGULATION_OUT;
   711					break;
   712				case DA9121_MASK_SYS_EVENT_1_E_UV1:
   713					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_UV1;
   714					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   715					break;
   716				case DA9121_MASK_SYS_EVENT_1_E_OC1:
   717					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OC1;
   718					notification |= REGULATOR_EVENT_OVER_CURRENT;
   719					break;
   720				case DA9xxx_MASK_SYS_EVENT_1_E_OV2:
   721					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OV2;
   722					notification |= REGULATOR_EVENT_REGULATION_OUT;
   723					break;
   724				case DA9xxx_MASK_SYS_EVENT_1_E_UV2:
   725					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_UV2;
   726					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   727					break;
   728				case DA9xxx_MASK_SYS_EVENT_1_E_OC2:
   729					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OC2;
   730					notification |= REGULATOR_EVENT_OVER_CURRENT;
   731					break;
   732				default:
   733					dev_warn(chip->dev,
   734						 "Unhandled event in bank1 0x%02x\n",
   735						 event & ebit);
   736					ret = -EINVAL;
   737					break;
   738				}
   739				break;
   740			default:
   741				dev_warn(chip->dev,
   742					 "Unhandled event bank 0x%02x\n", event_bank);
   743				ret = -EINVAL;
   744				goto error;
   745				break;
   746			}
   747	
 > 748			regulator_lock(rdev);
   749			regulator_notifier_call_chain(rdev, notification, NULL);
 > 750			regulator_unlock(rdev);
   751		}
   752	
   753	error:
   754		return ret;
   755	}
   756	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33483 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread