* [hare-scsi-devel:scsi-result-rework 142/146] drivers/scsi/scsi_debug.c:3929:26: error: expected '; ' before 'return'
@ 2021-04-22 13:57 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-22 13:57 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 17522 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result-rework
head: 19720ea7b22b443a182646eef7edc36e32e7b515
commit: b2b01f896bd09566ce5697c7d12ee0d8dc382077 [142/146] scsi_debug: add status_good_result() to clear status
config: mips-randconfig-r016-20210421 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=b2b01f896bd09566ce5697c7d12ee0d8dc382077
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel scsi-result-rework
git checkout b2b01f896bd09566ce5697c7d12ee0d8dc382077
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
2903 | return scp->result;
| ~~~^~~~~~~~
drivers/scsi/scsi_debug.c:2888:20: note: declared here
2888 | static inline void check_device_access_params
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2907:13: error: 'return' with a value, in function returning void [-Werror=return-type]
2907 | return scp->result;
| ~~~^~~~~~~~
drivers/scsi/scsi_debug.c:2888:20: note: declared here
2888 | static inline void check_device_access_params
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2910:10: error: 'return' with a value, in function returning void [-Werror=return-type]
2910 | return check_zbc_access_params(scp, lba, num, write);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2888:20: note: declared here
2888 | static inline void check_device_access_params
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2913:9: error: 'return' with a value, in function returning void [-Werror=return-type]
2913 | return 0;
| ^
drivers/scsi/scsi_debug.c:2888:20: note: declared here
2888 | static inline void check_device_access_params
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c: In function 'p_fill_from_dev_buffer':
drivers/scsi/scsi_debug.c:2922:39: error: invalid storage class for function 'devip2sip'
2922 | static inline struct sdeb_store_info *devip2sip(struct sdebug_dev_info *devip,
| ^~~~~~~~~
drivers/scsi/scsi_debug.c:2933:12: error: invalid storage class for function 'do_device_access'
2933 | static int do_device_access(struct sdeb_store_info *sip, struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2976:12: error: invalid storage class for function 'do_dout_fetch'
2976 | static int do_dout_fetch(struct scsi_cmnd *scp, u32 num, u8 *doutp)
| ^~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:2991:13: error: invalid storage class for function 'comp_write_worker'
2991 | static bool comp_write_worker(struct sdeb_store_info *sip, u64 lba, u32 num,
| ^~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3021:15: error: invalid storage class for function 'dif_compute_csum'
3021 | static __be16 dif_compute_csum(const void *buf, int len)
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3033:12: error: invalid storage class for function 'dif_verify'
3033 | static int dif_verify(struct t10_pi_tuple *sdt, const void *data,
| ^~~~~~~~~~
drivers/scsi/scsi_debug.c:3060:13: error: invalid storage class for function 'dif_copy_prot'
3060 | static void dif_copy_prot(struct scsi_cmnd *scp, sector_t sector,
| ^~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3106:12: error: invalid storage class for function 'prot_verify_read'
3106 | static int prot_verify_read(struct scsi_cmnd *scp, sector_t start_sec,
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3138:12: error: invalid storage class for function 'resp_read_dt0'
3138 | static int resp_read_dt0(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3271:13: error: invalid storage class for function 'dump_sector'
3271 | static void dump_sector(unsigned char *buf, int len)
| ^~~~~~~~~~~
drivers/scsi/scsi_debug.c:3293:12: error: invalid storage class for function 'prot_verify_write'
3293 | static int prot_verify_write(struct scsi_cmnd *SCpnt, sector_t start_sec,
| ^~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3365:22: error: invalid storage class for function 'lba_to_map_index'
3365 | static unsigned long lba_to_map_index(sector_t lba)
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3373:17: error: invalid storage class for function 'map_index_to_lba'
3373 | static sector_t map_index_to_lba(unsigned long index)
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3382:21: error: invalid storage class for function 'map_state'
3382 | static unsigned int map_state(struct sdeb_store_info *sip, sector_t lba,
| ^~~~~~~~~
drivers/scsi/scsi_debug.c:3403:13: error: invalid storage class for function 'map_region'
3403 | static void map_region(struct sdeb_store_info *sip, sector_t lba,
| ^~~~~~~~~~
drivers/scsi/scsi_debug.c:3418:13: error: invalid storage class for function 'unmap_region'
3418 | static void unmap_region(struct sdeb_store_info *sip, sector_t lba,
| ^~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3447:12: error: invalid storage class for function 'resp_write_dt0'
3447 | static int resp_write_dt0(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3573:12: error: invalid storage class for function 'resp_write_scat'
3573 | static int resp_write_scat(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3744:12: error: invalid storage class for function 'resp_write_same'
3744 | static int resp_write_same(struct scsi_cmnd *scp, u64 lba, u32 num,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c: In function 'resp_write_same':
drivers/scsi/scsi_debug.c:3762:7: error: implicit declaration of function 'scsi_result_is_god'; did you mean 'scsi_result_is_good'? [-Werror=implicit-function-declaration]
3762 | if (!scsi_result_is_god(scp)) {
| ^~~~~~~~~~~~~~~~~~
| scsi_result_is_good
drivers/scsi/scsi_debug.c: In function 'p_fill_from_dev_buffer':
drivers/scsi/scsi_debug.c:3809:12: error: invalid storage class for function 'resp_write_same_10'
3809 | static int resp_write_same_10(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3834:12: error: invalid storage class for function 'resp_write_same_16'
3834 | static int resp_write_same_16(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3865:12: error: invalid storage class for function 'resp_write_buffer'
3865 | static int resp_write_buffer(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:3912:12: error: invalid storage class for function 'resp_comp_write'
3912 | static int resp_comp_write(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c: In function 'resp_comp_write':
>> drivers/scsi/scsi_debug.c:3929:26: error: expected ';' before 'return'
3929 | status_good_result(scp)
| ^
| ;
3930 | return 0; /* degenerate case, not an error */
| ~~~~~~
drivers/scsi/scsi_debug.c: In function 'p_fill_from_dev_buffer':
drivers/scsi/scsi_debug.c:3983:12: error: invalid storage class for function 'resp_unmap'
3983 | static int resp_unmap(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~
drivers/scsi/scsi_debug.c:4041:12: error: invalid storage class for function 'resp_get_lba_status'
4041 | static int resp_get_lba_status(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c: In function 'resp_get_lba_status':
drivers/scsi/scsi_debug.c:4047:6: warning: unused variable 'ret' [-Wunused-variable]
4047 | int ret;
| ^~~
drivers/scsi/scsi_debug.c: In function 'p_fill_from_dev_buffer':
drivers/scsi/scsi_debug.c:4086:12: error: invalid storage class for function 'resp_sync_cache'
4086 | static int resp_sync_cache(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4119:12: error: invalid storage class for function 'resp_pre_fetch'
4119 | static int resp_pre_fetch(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4174:12: error: invalid storage class for function 'resp_report_luns'
4174 | static int resp_report_luns(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c: In function 'resp_report_luns':
drivers/scsi/scsi_debug.c:4187:15: warning: variable 'res' set but not used [-Wunused-but-set-variable]
4187 | int k, j, n, res;
| ^~~
drivers/scsi/scsi_debug.c: In function 'p_fill_from_dev_buffer':
drivers/scsi/scsi_debug.c:4268:12: error: invalid storage class for function 'resp_verify'
4268 | static int resp_verify(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~~
drivers/scsi/scsi_debug.c:4348:12: error: invalid storage class for function 'resp_report_zones'
4348 | static int resp_report_zones(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4479:13: error: invalid storage class for function 'zbc_open_all'
4479 | static void zbc_open_all(struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4490:12: error: invalid storage class for function 'resp_open_zone'
4490 | static int resp_open_zone(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4559:13: error: invalid storage class for function 'zbc_close_all'
4559 | static void zbc_close_all(struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4567:12: error: invalid storage class for function 'resp_close_zone'
4567 | static int resp_close_zone(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4616:13: error: invalid storage class for function 'zbc_finish_zone'
4616 | static void zbc_finish_zone(struct sdebug_dev_info *devip,
| ^~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4632:13: error: invalid storage class for function 'zbc_finish_all'
4632 | static void zbc_finish_all(struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4640:12: error: invalid storage class for function 'resp_finish_zone'
4640 | static int resp_finish_zone(struct scsi_cmnd *scp,
| ^~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4689:13: error: invalid storage class for function 'zbc_rwp_zone'
4689 | static void zbc_rwp_zone(struct sdebug_dev_info *devip,
| ^~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4709:13: error: invalid storage class for function 'zbc_rwp_all'
4709 | static void zbc_rwp_all(struct sdebug_dev_info *devip)
| ^~~~~~~~~~~
drivers/scsi/scsi_debug.c:4717:12: error: invalid storage class for function 'resp_rwp_zone'
4717 | static int resp_rwp_zone(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4764:29: error: invalid storage class for function 'get_queue'
4764 | static struct sdebug_queue *get_queue(struct scsi_cmnd *cmnd)
| ^~~~~~~~~
drivers/scsi/scsi_debug.c:4778:12: error: invalid storage class for function 'get_tag'
4778 | static u32 get_tag(struct scsi_cmnd *cmnd)
| ^~~~~~~
drivers/scsi/scsi_debug.c:4784:13: error: invalid storage class for function 'sdebug_q_cmd_complete'
4784 | static void sdebug_q_cmd_complete(struct sdebug_defer *sd_dp)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4858:29: error: invalid storage class for function 'sdebug_q_cmd_hrt_complete'
4858 | static enum hrtimer_restart sdebug_q_cmd_hrt_complete(struct hrtimer *timer)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4867:13: error: invalid storage class for function 'sdebug_q_cmd_wq_complete'
4867 | static void sdebug_q_cmd_wq_complete(struct work_struct *work)
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4877:12: error: invalid storage class for function 'sdebug_device_create_zones'
4877 | static int sdebug_device_create_zones(struct sdebug_dev_info *devip)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4963:32: error: invalid storage class for function 'sdebug_device_create'
4963 | static struct sdebug_dev_info *sdebug_device_create(
| ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:4999:32: error: invalid storage class for function 'find_build_dev_info'
4999 | static struct sdebug_dev_info *find_build_dev_info(struct scsi_device *sdev)
| ^~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:5039:12: error: invalid storage class for function 'scsi_debug_slave_alloc'
5039 | static int scsi_debug_slave_alloc(struct scsi_device *sdp)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:5047:12: error: invalid storage class for function 'scsi_debug_slave_configure'
5047 | static int scsi_debug_slave_configure(struct scsi_device *sdp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/scsi_debug.c:5069:13: error: invalid storage class for function 'scsi_debug_slave_destroy'
5069 | static void scsi_debug_slave_destroy(struct scsi_device *sdp)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +3929 drivers/scsi/scsi_debug.c
3911
3912 static int resp_comp_write(struct scsi_cmnd *scp,
3913 struct sdebug_dev_info *devip)
3914 {
3915 u8 *cmd = scp->cmnd;
3916 u8 *arr;
3917 struct sdeb_store_info *sip = devip2sip(devip, true);
3918 rwlock_t *macc_lckp = &sip->macc_lck;
3919 u64 lba;
3920 u32 dnum;
3921 u32 lb_size = sdebug_sector_size;
3922 u8 num;
3923 int ret;
3924 int retval = 0;
3925
3926 lba = get_unaligned_be64(cmd + 2);
3927 num = cmd[13]; /* 1 to a maximum of 255 logical blocks */
3928 if (0 == num) {
> 3929 status_good_result(scp)
3930 return 0; /* degenerate case, not an error */
3931 }
3932 if (sdebug_dif == T10_PI_TYPE2_PROTECTION &&
3933 (cmd[1] & 0xe0)) {
3934 mk_sense_invalid_opcode(scp);
3935 return scp->result;
3936 }
3937 if ((sdebug_dif == T10_PI_TYPE1_PROTECTION ||
3938 sdebug_dif == T10_PI_TYPE3_PROTECTION) &&
3939 (cmd[1] & 0xe0) == 0)
3940 sdev_printk(KERN_ERR, scp->device, "Unprotected WR "
3941 "to DIF device\n");
3942 check_device_access_params(scp, lba, num, false);
3943 if (!scsi_result_is_good(scp))
3944 return scp->result;
3945 dnum = 2 * num;
3946 arr = kcalloc(lb_size, dnum, GFP_ATOMIC);
3947 if (NULL == arr) {
3948 mk_sense_buffer(scp, ILLEGAL_REQUEST, INSUFF_RES_ASC,
3949 INSUFF_RES_ASCQ);
3950 return scp->result;
3951 }
3952
3953 write_lock(macc_lckp);
3954
3955 ret = do_dout_fetch(scp, dnum, arr);
3956 if (ret == -1) {
3957 set_host_byte(scp, DID_ERROR);
3958 retval = scp->result;
3959 goto cleanup;
3960 } else if (sdebug_verbose && (ret < (dnum * lb_size)))
3961 sdev_printk(KERN_INFO, scp->device, "%s: compare_write: cdb "
3962 "indicated=%u, IO sent=%d bytes\n", my_name,
3963 dnum * lb_size, ret);
3964 if (!comp_write_worker(sip, lba, num, arr, false)) {
3965 mk_sense_buffer(scp, MISCOMPARE, MISCOMPARE_VERIFY_ASC, 0);
3966 retval = scp->result;
3967 goto cleanup;
3968 }
3969 if (scsi_debug_lbp())
3970 map_region(sip, lba, num);
3971 cleanup:
3972 write_unlock(macc_lckp);
3973 kfree(arr);
3974 return retval;
3975 }
3976
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34689 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-22 13:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 13:57 [hare-scsi-devel:scsi-result-rework 142/146] drivers/scsi/scsi_debug.c:3929:26: error: expected '; ' before 'return' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.