* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
@ 2021-04-02 18:14 Fabrice Fontaine
2021-04-22 21:02 ` Thomas Petazzoni
2021-04-26 14:33 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-04-02 18:14 UTC (permalink / raw)
To: buildroot
Fix static build with uclibc which is raised since bump to version
2020-12-R3 in commit 14522a8f9d272204763c49a21ebce5653430c612
Fixes:
- http://autobuild.buildroot.org/results/69dcb7ac99e63fca342e4d52d9311d1ee1931911
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/kismet/kismet.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
index 5445db0b1f..3a171af7b2 100644
--- a/package/kismet/kismet.mk
+++ b/package/kismet/kismet.mk
@@ -18,6 +18,9 @@ KISMET_DEPENDENCIES = \
KISMET_LICENSE = GPL-2.0+
KISMET_LICENSE_FILES = LICENSE
KISMET_SELINUX_MODULES = kismet
+# Needed because tarball configure has not been rebuilt after
+# https://github.com/kismetwireless/kismet/commit/e70968bcbca86dd448d619c40cdeaae8b7dcee98
+KISMET_AUTORECONF = YES
KISMET_CONF_OPTS = --disable-debuglibs
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
2021-04-02 18:14 [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc Fabrice Fontaine
@ 2021-04-22 21:02 ` Thomas Petazzoni
2021-04-26 14:33 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2021-04-22 21:02 UTC (permalink / raw)
To: buildroot
On Fri, 2 Apr 2021 20:14:58 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix static build with uclibc which is raised since bump to version
> 2020-12-R3 in commit 14522a8f9d272204763c49a21ebce5653430c612
>
> Fixes:
> - http://autobuild.buildroot.org/results/69dcb7ac99e63fca342e4d52d9311d1ee1931911
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/kismet/kismet.mk | 3 +++
> 1 file changed, 3 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
2021-04-02 18:14 [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc Fabrice Fontaine
2021-04-22 21:02 ` Thomas Petazzoni
@ 2021-04-26 14:33 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-04-26 14:33 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix static build with uclibc which is raised since bump to version
> 2020-12-R3 in commit 14522a8f9d272204763c49a21ebce5653430c612
> Fixes:
> - http://autobuild.buildroot.org/results/69dcb7ac99e63fca342e4d52d9311d1ee1931911
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
2020-11-24 22:15 Fabrice Fontaine
2020-12-15 20:42 ` Arnout Vandecappelle
@ 2020-12-21 14:18 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-12-21 14:18 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fixes:
> - http://autobuild.buildroot.org/results/b859eb3850c0beb23e18010dc2f07cd0f5c14440
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
2020-11-24 22:15 Fabrice Fontaine
@ 2020-12-15 20:42 ` Arnout Vandecappelle
2020-12-21 14:18 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2020-12-15 20:42 UTC (permalink / raw)
To: buildroot
On 24/11/2020 23:15, Fabrice Fontaine wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/b859eb3850c0beb23e18010dc2f07cd0f5c14440
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
> ---
> ...don-t-override-LDFLAGS-with-CPPFLAGS.patch | 44 +++++++++++++++++++
> package/kismet/kismet.mk | 2 +
> 2 files changed, 46 insertions(+)
> create mode 100644 package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
>
> diff --git a/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch b/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
> new file mode 100644
> index 0000000000..f185333475
> --- /dev/null
> +++ b/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
> @@ -0,0 +1,44 @@
> +From e70968bcbca86dd448d619c40cdeaae8b7dcee98 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Tue, 24 Nov 2020 23:01:55 +0100
> +Subject: [PATCH] configure.ac: don't override LDFLAGS with CPPFLAGS
> +
> +Don't override LDFLAGS with CPPFLAGS to avoid a build failure when
> +building statically with uclibc due to -static keyword being lost:
> +
> +/home/buildroot/autobuild/run/instance-3/output-1/host/bin/xtensa-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o kismet_cap_linux_wifi ../interface_control.c.o ../wifi_ht_channels.c.o linux_wireless_control.c.o linux_netlink_control.c.o linux_nexmon_control.c.o linux_wireless_rfkill.c.o capture_linux_wifi.c.o ../libkismetdatasource.a -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/lib -lpcap -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/home/buildroot/autobuild/run/instance-3/output-1/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/.libs -lnl-genl-3 -lnl-3 -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/lib -lpthread -lnl-genl-3 -lnl-3 -lpthread -lpthread -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysr
> oot/usr/lib -lprotobuf-c -lm
In the future, please try to avoid such long lines. git send-email splits them,
which makes the patch hard to apply. You can simply sed
/home/buildroot/autobuild/run/instance-3/output-1 to output.
Regards,
Arnout
> +/home/buildroot/autobuild/run/instance-3/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/run/instance-3/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/libgcc.a(unwind-dw2-fde-dip.o): in function `_Unwind_Find_registered_FDE':
> +/home/buildroot/autobuild/run/instance-3/output-1/build/host-gcc-final-9.3.0/build/xtensa-buildroot-linux-uclibc/libgcc/../../../libgcc/unwind-dw2-fde.c:1040: undefined reference to `dl_iterate_phdr'
> +collect2: error: ld returned 1 exit status
> +
> +To fix this build failure, just drop OCPPFLAGS and OLDFLAGS which are
> +not used anymore
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/b859eb3850c0beb23e18010dc2f07cd0f5c14440
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: https://github.com/kismetwireless/kismet/pull/326]
> +---
> + configure.ac | 5 -----
> + 1 file changed, 5 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index aab47fb0..4df37a29 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -619,11 +619,6 @@ else
> + AC_MSG_RESULT([no])
> + fi
> +
> +-OCPPFLAGS=$CPPFLAGS
> +-CPPFLAGS="$CPPFLAGS"
> +-OLDFLAGS=$LDFLAGS
> +-LDFLAGS="$CPPFLAGS"
> +-
> + # Do we need libm for math functions?
> + AC_MSG_CHECKING([for libm math function in std libs])
> + OCFL="$CFLAGS"
> +--
> +2.29.2
> +
> diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
> index 54d014021f..0a4ae00f08 100644
> --- a/package/kismet/kismet.mk
> +++ b/package/kismet/kismet.mk
> @@ -17,6 +17,8 @@ KISMET_DEPENDENCIES = \
> zlib
> KISMET_LICENSE = GPL-2.0+
> KISMET_LICENSE_FILES = LICENSE
> +# We're patching configure.ac
> +KISMET_AUTORECONF = YES
> KISMET_CONF_OPTS = --disable-debuglibs
>
> KISMET_CXXFLAGS = $(TARGET_CXXFLAGS)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc
@ 2020-11-24 22:15 Fabrice Fontaine
2020-12-15 20:42 ` Arnout Vandecappelle
2020-12-21 14:18 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2020-11-24 22:15 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/b859eb3850c0beb23e18010dc2f07cd0f5c14440
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...don-t-override-LDFLAGS-with-CPPFLAGS.patch | 44 +++++++++++++++++++
package/kismet/kismet.mk | 2 +
2 files changed, 46 insertions(+)
create mode 100644 package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
diff --git a/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch b/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
new file mode 100644
index 0000000000..f185333475
--- /dev/null
+++ b/package/kismet/0001-configure.ac-don-t-override-LDFLAGS-with-CPPFLAGS.patch
@@ -0,0 +1,44 @@
+From e70968bcbca86dd448d619c40cdeaae8b7dcee98 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Tue, 24 Nov 2020 23:01:55 +0100
+Subject: [PATCH] configure.ac: don't override LDFLAGS with CPPFLAGS
+
+Don't override LDFLAGS with CPPFLAGS to avoid a build failure when
+building statically with uclibc due to -static keyword being lost:
+
+/home/buildroot/autobuild/run/instance-3/output-1/host/bin/xtensa-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o kismet_cap_linux_wifi ../interface_control.c.o ../wifi_ht_channels.c.o linux_wireless_control.c.o linux_netlink_control.c.o linux_nexmon_control.c.o linux_wireless_rfkill.c.o capture_linux_wifi.c.o ../libkismetdatasource.a -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/lib -lpcap -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/home/buildroot/autobuild/run/instance-3/output-1/host/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/.libs -lnl-genl-3 -lnl-3 -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/lib -lpthread -lnl-genl-3 -lnl-3 -lpthread -lpthread -L/home/buildroot/autobuild/run/instance-3/output-1/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/lib -lprotobuf-c -lm
+/home/buildroot/autobuild/run/instance-3/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/run/instance-3/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/libgcc.a(unwind-dw2-fde-dip.o): in function `_Unwind_Find_registered_FDE':
+/home/buildroot/autobuild/run/instance-3/output-1/build/host-gcc-final-9.3.0/build/xtensa-buildroot-linux-uclibc/libgcc/../../../libgcc/unwind-dw2-fde.c:1040: undefined reference to `dl_iterate_phdr'
+collect2: error: ld returned 1 exit status
+
+To fix this build failure, just drop OCPPFLAGS and OLDFLAGS which are
+not used anymore
+
+Fixes:
+ - http://autobuild.buildroot.org/results/b859eb3850c0beb23e18010dc2f07cd0f5c14440
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/kismetwireless/kismet/pull/326]
+---
+ configure.ac | 5 -----
+ 1 file changed, 5 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index aab47fb0..4df37a29 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -619,11 +619,6 @@ else
+ AC_MSG_RESULT([no])
+ fi
+
+-OCPPFLAGS=$CPPFLAGS
+-CPPFLAGS="$CPPFLAGS"
+-OLDFLAGS=$LDFLAGS
+-LDFLAGS="$CPPFLAGS"
+-
+ # Do we need libm for math functions?
+ AC_MSG_CHECKING([for libm math function in std libs])
+ OCFL="$CFLAGS"
+--
+2.29.2
+
diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
index 54d014021f..0a4ae00f08 100644
--- a/package/kismet/kismet.mk
+++ b/package/kismet/kismet.mk
@@ -17,6 +17,8 @@ KISMET_DEPENDENCIES = \
zlib
KISMET_LICENSE = GPL-2.0+
KISMET_LICENSE_FILES = LICENSE
+# We're patching configure.ac
+KISMET_AUTORECONF = YES
KISMET_CONF_OPTS = --disable-debuglibs
KISMET_CXXFLAGS = $(TARGET_CXXFLAGS)
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-26 14:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 18:14 [Buildroot] [PATCH 1/1] package/kismet: fix static build with uclibc Fabrice Fontaine
2021-04-22 21:02 ` Thomas Petazzoni
2021-04-26 14:33 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2020-11-24 22:15 Fabrice Fontaine
2020-12-15 20:42 ` Arnout Vandecappelle
2020-12-21 14:18 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.