Re: [PATCH net-next 2/3] once: replace uses of __section(".data.once") with DO_ONCE_LITE(_IF)?

From: kernel test robot <lkp@intel.com>
To: Tanner Love <tannerlove.kernel@gmail.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, davem@davemloft.net,
	Tanner Love <tannerlove@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH net-next 2/3] once: replace uses of __section(".data.once") with DO_ONCE_LITE(_IF)?
Date: Fri, 23 Apr 2021 05:23:00 +0800	[thread overview]
Message-ID: <202104230511.lg9BxfyN-lkp@intel.com> (raw)
In-Reply-To: <20210422194738.2175542-3-tannerlove.kernel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5229 bytes --]

Hi Tanner,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tanner-Love/net-update-netdev_rx_csum_fault-print-dump-only-once/20210423-034958
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5d869070569a23aa909c6e7e9d010fc438a492ef
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/eaeb33f0f85f70fc4e5fbae1e2344e9c6867c840
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tanner-Love/net-update-netdev_rx_csum_fault-print-dump-only-once/20210423-034958
        git checkout eaeb33f0f85f70fc4e5fbae1e2344e9c6867c840
        # save the attached .config to linux build tree
        make W=1 W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/once.h:6,
                    from include/asm-generic/bug.h:7,
                    from arch/x86/include/asm/bug.h:93,
                    from include/linux/bug.h:5,
                    from include/linux/page-flags.h:10,
                    from kernel/bounds.c:10:
   include/linux/jump_label.h: In function 'static_key_slow_inc':
>> include/linux/jump_label.h:81:35: error: implicit declaration of function 'WARN' [-Werror=implicit-function-declaration]
      81 | #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized,        \
         |                                   ^~~~
   include/linux/jump_label.h:278:2: note: in expansion of macro 'STATIC_KEY_CHECK_USE'
     278 |  STATIC_KEY_CHECK_USE(key);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/once.h:6,
                    from include/asm-generic/bug.h:7,
                    from arch/x86/include/asm/bug.h:93,
                    from include/linux/bug.h:5,
                    from include/linux/page-flags.h:10,
                    from kernel/bounds.c:10:
   include/linux/jump_label.h: In function 'static_key_enable':
>> include/linux/jump_label.h:309:3: error: implicit declaration of function 'WARN_ON_ONCE' [-Werror=implicit-function-declaration]
     309 |   WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
         |   ^~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/once.h:6,
                    from include/asm-generic/bug.h:7,
                    from arch/x86/include/asm/bug.h:93,
                    from include/linux/bug.h:5,
                    from include/linux/page-flags.h:10,
                    from kernel/bounds.c:10:
   include/linux/jump_label.h: In function 'static_key_slow_inc':
>> include/linux/jump_label.h:81:35: error: implicit declaration of function 'WARN' [-Werror=implicit-function-declaration]
      81 | #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized,        \
         |                                   ^~~~
   include/linux/jump_label.h:278:2: note: in expansion of macro 'STATIC_KEY_CHECK_USE'
     278 |  STATIC_KEY_CHECK_USE(key);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/once.h:6,
                    from include/asm-generic/bug.h:7,
                    from arch/x86/include/asm/bug.h:93,
                    from include/linux/bug.h:5,
                    from include/linux/page-flags.h:10,
                    from kernel/bounds.c:10:
   include/linux/jump_label.h: In function 'static_key_enable':
>> include/linux/jump_label.h:309:3: error: implicit declaration of function 'WARN_ON_ONCE' [-Werror=implicit-function-declaration]
     309 |   WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
         |   ^~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:116: kernel/bounds.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1235: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:215: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/WARN_ON_ONCE +309 include/linux/jump_label.h

b202952075f626 Gleb Natapov    2011-11-27  303  
e33886b38cc82a Peter Zijlstra  2015-07-24  304  static inline void static_key_enable(struct static_key *key)
e33886b38cc82a Peter Zijlstra  2015-07-24  305  {
5cdda5117e125e Borislav Petkov 2017-10-18  306  	STATIC_KEY_CHECK_USE(key);
e33886b38cc82a Peter Zijlstra  2015-07-24  307  
1dbb6704de91b1 Paolo Bonzini   2017-08-01  308  	if (atomic_read(&key->enabled) != 0) {
1dbb6704de91b1 Paolo Bonzini   2017-08-01 @309  		WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
1dbb6704de91b1 Paolo Bonzini   2017-08-01  310  		return;
1dbb6704de91b1 Paolo Bonzini   2017-08-01  311  	}
1dbb6704de91b1 Paolo Bonzini   2017-08-01  312  	atomic_set(&key->enabled, 1);
e33886b38cc82a Peter Zijlstra  2015-07-24  313  }
e33886b38cc82a Peter Zijlstra  2015-07-24  314  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7357 bytes --]