* [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
@ 2021-04-23 14:09 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-23 14:09 UTC (permalink / raw)
To: amd-gfx
Cc: Harry Wentland, stable, nicholas.kazlauskas, alexander.deucher,
Roman.Li, hersenxs.wu, danny.wang
[Why]
This hasn't been well tested and leads to complete system hangs on DCN1
based systems, possibly others.
The system hang can be reproduced by gesturing the video on the YouTube
Android app on ChromeOS into full screen.
[How]
Reject atomic commits with non-zero drm_plane_state.src_x or src_y values.
v2:
- Add code comment describing the reason we're rejecting non-zero
src_x and src_y
- Drop gerrit Change-Id
- Add stable CC
- Based on amd-staging-drm-next
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Cc: stable@vger.kernel.org
Cc: nicholas.kazlauskas@amd.com
Cc: amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com
Cc: Roman.Li@amd.com
Cc: hersenxs.wu@amd.com
Cc: danny.wang@amd.com
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index be1769d29742..b12469043e6b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct drm_plane_state *state,
scaling_info->src_rect.x = state->src_x >> 16;
scaling_info->src_rect.y = state->src_y >> 16;
+ /*
+ * For reasons we don't (yet) fully understand a non-zero
+ * src_y coordinate into an NV12 buffer can cause a
+ * system hang. To avoid hangs (and maybe be overly cautious)
+ * let's reject both non-zero src_x and src_y.
+ *
+ * We currently know of only one use-case to reproduce a
+ * scenario with non-zero src_x and src_y for NV12, which
+ * is to gesture the YouTube Android app into full screen
+ * on ChromeOS.
+ */
+ if (state->fb &&
+ state->fb->format->format == DRM_FORMAT_NV12 &&
+ (scaling_info->src_rect.x != 0 ||
+ scaling_info->src_rect.y != 0))
+ return -EINVAL;
+
scaling_info->src_rect.width = state->src_w >> 16;
if (scaling_info->src_rect.width == 0)
return -EINVAL;
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
@ 2021-04-23 14:09 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-23 14:09 UTC (permalink / raw)
To: amd-gfx
Cc: danny.wang, Roman.Li, stable, hersenxs.wu, alexander.deucher,
Harry Wentland, nicholas.kazlauskas
[Why]
This hasn't been well tested and leads to complete system hangs on DCN1
based systems, possibly others.
The system hang can be reproduced by gesturing the video on the YouTube
Android app on ChromeOS into full screen.
[How]
Reject atomic commits with non-zero drm_plane_state.src_x or src_y values.
v2:
- Add code comment describing the reason we're rejecting non-zero
src_x and src_y
- Drop gerrit Change-Id
- Add stable CC
- Based on amd-staging-drm-next
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Cc: stable@vger.kernel.org
Cc: nicholas.kazlauskas@amd.com
Cc: amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com
Cc: Roman.Li@amd.com
Cc: hersenxs.wu@amd.com
Cc: danny.wang@amd.com
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index be1769d29742..b12469043e6b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct drm_plane_state *state,
scaling_info->src_rect.x = state->src_x >> 16;
scaling_info->src_rect.y = state->src_y >> 16;
+ /*
+ * For reasons we don't (yet) fully understand a non-zero
+ * src_y coordinate into an NV12 buffer can cause a
+ * system hang. To avoid hangs (and maybe be overly cautious)
+ * let's reject both non-zero src_x and src_y.
+ *
+ * We currently know of only one use-case to reproduce a
+ * scenario with non-zero src_x and src_y for NV12, which
+ * is to gesture the YouTube Android app into full screen
+ * on ChromeOS.
+ */
+ if (state->fb &&
+ state->fb->format->format == DRM_FORMAT_NV12 &&
+ (scaling_info->src_rect.x != 0 ||
+ scaling_info->src_rect.y != 0))
+ return -EINVAL;
+
scaling_info->src_rect.width = state->src_w >> 16;
if (scaling_info->src_rect.width == 0)
return -EINVAL;
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
2021-04-23 14:09 ` Harry Wentland
@ 2021-04-23 14:18 ` Christian König
-1 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2021-04-23 14:18 UTC (permalink / raw)
To: Harry Wentland, amd-gfx
Cc: danny.wang, Roman.Li, stable, hersenxs.wu, alexander.deucher,
nicholas.kazlauskas
Good that this has been found. Just a curious guess, but have you guys
checked if the src_x and src_y are a multiple of 2?
Might cause problems to try to access a subsampled surface if the
coordinates doesn't make much sense.
Anyway patch is Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
Am 23.04.21 um 16:09 schrieb Harry Wentland:
> [Why]
> This hasn't been well tested and leads to complete system hangs on DCN1
> based systems, possibly others.
>
> The system hang can be reproduced by gesturing the video on the YouTube
> Android app on ChromeOS into full screen.
>
> [How]
> Reject atomic commits with non-zero drm_plane_state.src_x or src_y values.
>
> v2:
> - Add code comment describing the reason we're rejecting non-zero
> src_x and src_y
> - Drop gerrit Change-Id
> - Add stable CC
> - Based on amd-staging-drm-next
>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> Cc: stable@vger.kernel.org
> Cc: nicholas.kazlauskas@amd.com
> Cc: amd-gfx@lists.freedesktop.org
> Cc: alexander.deucher@amd.com
> Cc: Roman.Li@amd.com
> Cc: hersenxs.wu@amd.com
> Cc: danny.wang@amd.com
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index be1769d29742..b12469043e6b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct drm_plane_state *state,
> scaling_info->src_rect.x = state->src_x >> 16;
> scaling_info->src_rect.y = state->src_y >> 16;
>
> + /*
> + * For reasons we don't (yet) fully understand a non-zero
> + * src_y coordinate into an NV12 buffer can cause a
> + * system hang. To avoid hangs (and maybe be overly cautious)
> + * let's reject both non-zero src_x and src_y.
> + *
> + * We currently know of only one use-case to reproduce a
> + * scenario with non-zero src_x and src_y for NV12, which
> + * is to gesture the YouTube Android app into full screen
> + * on ChromeOS.
> + */
> + if (state->fb &&
> + state->fb->format->format == DRM_FORMAT_NV12 &&
> + (scaling_info->src_rect.x != 0 ||
> + scaling_info->src_rect.y != 0))
> + return -EINVAL;
> +
> scaling_info->src_rect.width = state->src_w >> 16;
> if (scaling_info->src_rect.width == 0)
> return -EINVAL;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
@ 2021-04-23 14:18 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2021-04-23 14:18 UTC (permalink / raw)
To: Harry Wentland, amd-gfx
Cc: Roman.Li, stable, hersenxs.wu, alexander.deucher, danny.wang,
nicholas.kazlauskas
Good that this has been found. Just a curious guess, but have you guys
checked if the src_x and src_y are a multiple of 2?
Might cause problems to try to access a subsampled surface if the
coordinates doesn't make much sense.
Anyway patch is Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
Am 23.04.21 um 16:09 schrieb Harry Wentland:
> [Why]
> This hasn't been well tested and leads to complete system hangs on DCN1
> based systems, possibly others.
>
> The system hang can be reproduced by gesturing the video on the YouTube
> Android app on ChromeOS into full screen.
>
> [How]
> Reject atomic commits with non-zero drm_plane_state.src_x or src_y values.
>
> v2:
> - Add code comment describing the reason we're rejecting non-zero
> src_x and src_y
> - Drop gerrit Change-Id
> - Add stable CC
> - Based on amd-staging-drm-next
>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> Cc: stable@vger.kernel.org
> Cc: nicholas.kazlauskas@amd.com
> Cc: amd-gfx@lists.freedesktop.org
> Cc: alexander.deucher@amd.com
> Cc: Roman.Li@amd.com
> Cc: hersenxs.wu@amd.com
> Cc: danny.wang@amd.com
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index be1769d29742..b12469043e6b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct drm_plane_state *state,
> scaling_info->src_rect.x = state->src_x >> 16;
> scaling_info->src_rect.y = state->src_y >> 16;
>
> + /*
> + * For reasons we don't (yet) fully understand a non-zero
> + * src_y coordinate into an NV12 buffer can cause a
> + * system hang. To avoid hangs (and maybe be overly cautious)
> + * let's reject both non-zero src_x and src_y.
> + *
> + * We currently know of only one use-case to reproduce a
> + * scenario with non-zero src_x and src_y for NV12, which
> + * is to gesture the YouTube Android app into full screen
> + * on ChromeOS.
> + */
> + if (state->fb &&
> + state->fb->format->format == DRM_FORMAT_NV12 &&
> + (scaling_info->src_rect.x != 0 ||
> + scaling_info->src_rect.y != 0))
> + return -EINVAL;
> +
> scaling_info->src_rect.width = state->src_w >> 16;
> if (scaling_info->src_rect.width == 0)
> return -EINVAL;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
2021-04-23 14:18 ` Christian König
@ 2021-04-23 14:25 ` Harry Wentland
-1 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-23 14:25 UTC (permalink / raw)
To: Christian König, amd-gfx
Cc: danny.wang, Roman.Li, stable, hersenxs.wu, alexander.deucher,
nicholas.kazlauskas
On 2021-04-23 10:18 a.m., Christian König wrote:
> Good that this has been found. Just a curious guess, but have you guys
> checked if the src_x and src_y are a multiple of 2?
>
That was one of my first guesses but I still observed the hang after
forcing src_x and src_y to be multiples of 2.
> Might cause problems to try to access a subsampled surface if the
> coordinates doesn't make much sense.
>
> Anyway patch is Acked-by: Christian König <christian.koenig@amd.com>
>
Thanks,
Harry
> Regards,
> Christian.
>
> Am 23.04.21 um 16:09 schrieb Harry Wentland:
>> [Why]
>> This hasn't been well tested and leads to complete system hangs on DCN1
>> based systems, possibly others.
>>
>> The system hang can be reproduced by gesturing the video on the YouTube
>> Android app on ChromeOS into full screen.
>>
>> [How]
>> Reject atomic commits with non-zero drm_plane_state.src_x or src_y
>> values.
>>
>> v2:
>> - Add code comment describing the reason we're rejecting non-zero
>> src_x and src_y
>> - Drop gerrit Change-Id
>> - Add stable CC
>> - Based on amd-staging-drm-next
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> Cc: stable@vger.kernel.org
>> Cc: nicholas.kazlauskas@amd.com
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: alexander.deucher@amd.com
>> Cc: Roman.Li@amd.com
>> Cc: hersenxs.wu@amd.com
>> Cc: danny.wang@amd.com
>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>> ---
>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index be1769d29742..b12469043e6b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct
>> drm_plane_state *state,
>> scaling_info->src_rect.x = state->src_x >> 16;
>> scaling_info->src_rect.y = state->src_y >> 16;
>> + /*
>> + * For reasons we don't (yet) fully understand a non-zero
>> + * src_y coordinate into an NV12 buffer can cause a
>> + * system hang. To avoid hangs (and maybe be overly cautious)
>> + * let's reject both non-zero src_x and src_y.
>> + *
>> + * We currently know of only one use-case to reproduce a
>> + * scenario with non-zero src_x and src_y for NV12, which
>> + * is to gesture the YouTube Android app into full screen
>> + * on ChromeOS.
>> + */
>> + if (state->fb &&
>> + state->fb->format->format == DRM_FORMAT_NV12 &&
>> + (scaling_info->src_rect.x != 0 ||
>> + scaling_info->src_rect.y != 0))
>> + return -EINVAL;
>> +
>> scaling_info->src_rect.width = state->src_w >> 16;
>> if (scaling_info->src_rect.width == 0)
>> return -EINVAL;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes
@ 2021-04-23 14:25 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-23 14:25 UTC (permalink / raw)
To: Christian König, amd-gfx
Cc: Roman.Li, stable, hersenxs.wu, alexander.deucher, danny.wang,
nicholas.kazlauskas
On 2021-04-23 10:18 a.m., Christian König wrote:
> Good that this has been found. Just a curious guess, but have you guys
> checked if the src_x and src_y are a multiple of 2?
>
That was one of my first guesses but I still observed the hang after
forcing src_x and src_y to be multiples of 2.
> Might cause problems to try to access a subsampled surface if the
> coordinates doesn't make much sense.
>
> Anyway patch is Acked-by: Christian König <christian.koenig@amd.com>
>
Thanks,
Harry
> Regards,
> Christian.
>
> Am 23.04.21 um 16:09 schrieb Harry Wentland:
>> [Why]
>> This hasn't been well tested and leads to complete system hangs on DCN1
>> based systems, possibly others.
>>
>> The system hang can be reproduced by gesturing the video on the YouTube
>> Android app on ChromeOS into full screen.
>>
>> [How]
>> Reject atomic commits with non-zero drm_plane_state.src_x or src_y
>> values.
>>
>> v2:
>> - Add code comment describing the reason we're rejecting non-zero
>> src_x and src_y
>> - Drop gerrit Change-Id
>> - Add stable CC
>> - Based on amd-staging-drm-next
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> Cc: stable@vger.kernel.org
>> Cc: nicholas.kazlauskas@amd.com
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: alexander.deucher@amd.com
>> Cc: Roman.Li@amd.com
>> Cc: hersenxs.wu@amd.com
>> Cc: danny.wang@amd.com
>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>> ---
>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index be1769d29742..b12469043e6b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -4089,6 +4089,23 @@ static int fill_dc_scaling_info(const struct
>> drm_plane_state *state,
>> scaling_info->src_rect.x = state->src_x >> 16;
>> scaling_info->src_rect.y = state->src_y >> 16;
>> + /*
>> + * For reasons we don't (yet) fully understand a non-zero
>> + * src_y coordinate into an NV12 buffer can cause a
>> + * system hang. To avoid hangs (and maybe be overly cautious)
>> + * let's reject both non-zero src_x and src_y.
>> + *
>> + * We currently know of only one use-case to reproduce a
>> + * scenario with non-zero src_x and src_y for NV12, which
>> + * is to gesture the YouTube Android app into full screen
>> + * on ChromeOS.
>> + */
>> + if (state->fb &&
>> + state->fb->format->format == DRM_FORMAT_NV12 &&
>> + (scaling_info->src_rect.x != 0 ||
>> + scaling_info->src_rect.y != 0))
>> + return -EINVAL;
>> +
>> scaling_info->src_rect.width = state->src_w >> 16;
>> if (scaling_info->src_rect.width == 0)
>> return -EINVAL;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-23 14:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 14:09 [PATCH v2] drm/amd/display: Reject non-zero src_y and src_x for video planes Harry Wentland
2021-04-23 14:09 ` Harry Wentland
2021-04-23 14:18 ` Christian König
2021-04-23 14:18 ` Christian König
2021-04-23 14:25 ` Harry Wentland
2021-04-23 14:25 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.