[dunfell][PATCH] gstreamer1.0-plugins-good: on wayland qt5 needs qtwayland

[dunfell][PATCH] gstreamer1.0-plugins-good: on wayland qt5 needs qtwayland

[kai_uwe.broulik]

The code in ext/qt/meson.build looks for the Qt5WaylandClient pkg-config file.
Without this module, qmlglsink will not work with Wayland.
This can be tested by checking whether or not HAVE_QT_WAYLAND has
been added to the cflags in the autogenerated ninja file.

Writen by:
Carlos Rafael Giani
https://lists.openembedded.org/g/openembedded-core/message/143574

(From OE-Core rev: ba2e0f647894b51d2f365b1d2eee7b673ddf8b7e)

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 41bba2b226ff5332561a644a2fd4a2c8b8d7d967)
Signed-off-by: Kai Uwe Broulik <kai_uwe.broulik@mbition.io>
---
 .../gstreamer/gstreamer1.0-plugins-good_1.16.3.bb            | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
index 168bff4137..a5adf81f3b 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
@@ -34,6 +34,9 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
 X11ENABLEOPTS = "-Dximagesrc=enabled -Dximagesrc-xshm=enabled -Dximagesrc-xfixes=enabled -Dximagesrc-xdamage=enabled"
 X11DISABLEOPTS = "-Dximagesrc=disabled -Dximagesrc-xshm=disabled -Dximagesrc-xfixes=disabled -Dximagesrc-xdamage=disabled"
 
+QT5WAYLANDDEPENDS = "${@bb.utils.contains("DISTRO_FEATURES", "wayland", "qtwayland", "", d)}"
+
+PACKAGECONFIG[asm]        = "-Dasm=enabled,-Dasm=disabled,nasm-native"
 PACKAGECONFIG[bz2]        = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
 PACKAGECONFIG[cairo]      = "-Dcairo=enabled,-Dcairo=disabled,cairo"
 PACKAGECONFIG[dv1394]     = "-Ddv1394=enabled,-Ddv1394=disabled,libiec61883 libavc1394 libraw1394"
@@ -48,7 +51,7 @@ PACKAGECONFIG[libpng]     = "-Dpng=enabled,-Dpng=disabled,libpng"
 PACKAGECONFIG[libv4l2]    = "-Dv4l2-libv4l2=enabled,-Dv4l2-libv4l2=disabled,v4l-utils"
 PACKAGECONFIG[mpg123]     = "-Dmpg123=enabled,-Dmpg123=disabled,mpg123"
 PACKAGECONFIG[pulseaudio] = "-Dpulse=enabled,-Dpulse=disabled,pulseaudio"
-PACKAGECONFIG[qt5]        = "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative qtbase-native"
+PACKAGECONFIG[qt5]        = "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative qtbase-native ${QT5WAYLANDDEPENDS}"
 PACKAGECONFIG[soup]       = "-Dsoup=enabled,-Dsoup=disabled,libsoup-2.4"
 PACKAGECONFIG[speex]      = "-Dspeex=enabled,-Dspeex=disabled,speex"
 PACKAGECONFIG[taglib]     = "-Dtaglib=enabled,-Dtaglib=disabled,taglib"
-- 
2.24.0

Re: [OE-core] [dunfell][PATCH] gstreamer1.0-plugins-good: on wayland qt5 needs qtwayland

[Steve Sakoman]

On Fri, Apr 23, 2021 at 4:26 AM Kai Uwe Broulik via
lists.openembedded.org
<kai_uwe.broulik=mbition.io@lists.openembedded.org> wrote:
>
> The code in ext/qt/meson.build looks for the Qt5WaylandClient pkg-config file.
> Without this module, qmlglsink will not work with Wayland.
> This can be tested by checking whether or not HAVE_QT_WAYLAND has
> been added to the cflags in the autogenerated ninja file.
>
> Writen by:
> Carlos Rafael Giani
> https://lists.openembedded.org/g/openembedded-core/message/143574
>
> (From OE-Core rev: ba2e0f647894b51d2f365b1d2eee7b673ddf8b7e)
>
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 41bba2b226ff5332561a644a2fd4a2c8b8d7d967)
> Signed-off-by: Kai Uwe Broulik <kai_uwe.broulik@mbition.io>
> ---
>  .../gstreamer/gstreamer1.0-plugins-good_1.16.3.bb            | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
> index 168bff4137..a5adf81f3b 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb
> @@ -34,6 +34,9 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
>  X11ENABLEOPTS = "-Dximagesrc=enabled -Dximagesrc-xshm=enabled -Dximagesrc-xfixes=enabled -Dximagesrc-xdamage=enabled"
>  X11DISABLEOPTS = "-Dximagesrc=disabled -Dximagesrc-xshm=disabled -Dximagesrc-xfixes=disabled -Dximagesrc-xdamage=disabled"
>
> +QT5WAYLANDDEPENDS = "${@bb.utils.contains("DISTRO_FEATURES", "wayland", "qtwayland", "", d)}"
> +
> +PACKAGECONFIG[asm]        = "-Dasm=enabled,-Dasm=disabled,nasm-native"

Fails on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/3358/steps/11/logs/errors

stdio: ERROR: gstreamer1.0-plugins-good-1.16.3-r0 do_configure: QA
Issue: gstreamer1.0-plugins-good: configure was passed unrecognised
options: asm [unknown-configure-option]
stdio: ERROR: gstreamer1.0-plugins-good-1.16.3-r0 do_configure: Fatal
QA errors found, failing task.
stdio: ERROR: Logfile of failure stored in:
/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/gstreamer1.0-plugins-good/1.16.3-r0/temp/log.do_configure.1203818
stdio: ERROR: Task
(/home/pokybuild/yocto-worker/beaglebone/build/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.3.bb:do_configure)
failed with exit code '1'
stdio: ERROR: Command . ./oe-init-build-env; bitbake core-image-sato
core-image-sato-dev core-image-sato-sdk core-image-minimal
core-image-minimal-dev core-image-sato-ptest
core-image-sato:do_populate_sdk -k failed with exit code 1, see errors
above. (1619285301.1: 548.0)

Steve

>  PACKAGECONFIG[bz2]        = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
>  PACKAGECONFIG[cairo]      = "-Dcairo=enabled,-Dcairo=disabled,cairo"
>  PACKAGECONFIG[dv1394]     = "-Ddv1394=enabled,-Ddv1394=disabled,libiec61883 libavc1394 libraw1394"
> @@ -48,7 +51,7 @@ PACKAGECONFIG[libpng]     = "-Dpng=enabled,-Dpng=disabled,libpng"
>  PACKAGECONFIG[libv4l2]    = "-Dv4l2-libv4l2=enabled,-Dv4l2-libv4l2=disabled,v4l-utils"
>  PACKAGECONFIG[mpg123]     = "-Dmpg123=enabled,-Dmpg123=disabled,mpg123"
>  PACKAGECONFIG[pulseaudio] = "-Dpulse=enabled,-Dpulse=disabled,pulseaudio"
> -PACKAGECONFIG[qt5]        = "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative qtbase-native"
> +PACKAGECONFIG[qt5]        = "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative qtbase-native ${QT5WAYLANDDEPENDS}"
>  PACKAGECONFIG[soup]       = "-Dsoup=enabled,-Dsoup=disabled,libsoup-2.4"
>  PACKAGECONFIG[speex]      = "-Dspeex=enabled,-Dspeex=disabled,speex"
>  PACKAGECONFIG[taglib]     = "-Dtaglib=enabled,-Dtaglib=disabled,taglib"
> --
> 2.24.0
>
>
> 
>