* [PATCH] pwm: Introduce single-PWM of_xlate function
@ 2021-04-23 21:30 Bjorn Andersson
2021-04-23 21:37 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2021-04-23 21:30 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Lee Jones; +Cc: linux-pwm, linux-kernel
The existing pxa driver and the upcoming addition of PWM support in the
TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and
thereby a need for a of_xlate function with the period as its single
argument.
Introduce a common helper function in the core that can be used as
of_xlate by such drivers and migrate the pxa driver to use this.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/pwm/core.c | 24 ++++++++++++++++++++++++
drivers/pwm/pwm-pxa.c | 16 +---------------
2 files changed, 25 insertions(+), 15 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index c4d5c0667137..25ed23cdf0d3 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -176,6 +176,30 @@ of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
return pwm;
}
+struct pwm_device *
+of_pwm_single_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
+{
+ struct pwm_device *pwm;
+
+ /* sanity check driver is single PWM */
+ if (pc->of_pwm_n_cells != 1)
+ return ERR_PTR(-EINVAL);
+
+ /* validate that one cell is specified */
+ if (args->args_count != 1)
+ return ERR_PTR(-EINVAL);
+
+ pwm = pwm_request_from_chip(pc, 0, NULL);
+ if (IS_ERR(pwm))
+ return pwm;
+
+ pwm->args.period = args->args[0];
+ pwm->args.polarity = PWM_POLARITY_NORMAL;
+
+ return pwm;
+}
+EXPORT_SYMBOL_GPL(of_pwm_single_xlate);
+
static void of_pwmchip_add(struct pwm_chip *chip)
{
if (!chip->dev || !chip->dev->of_node)
diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
index cfb683827d32..8cd82fb54483 100644
--- a/drivers/pwm/pwm-pxa.c
+++ b/drivers/pwm/pwm-pxa.c
@@ -148,20 +148,6 @@ static const struct platform_device_id *pxa_pwm_get_id_dt(struct device *dev)
return id ? id->data : NULL;
}
-static struct pwm_device *
-pxa_pwm_of_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
-{
- struct pwm_device *pwm;
-
- pwm = pwm_request_from_chip(pc, 0, NULL);
- if (IS_ERR(pwm))
- return pwm;
-
- pwm->args.period = args->args[0];
-
- return pwm;
-}
-
static int pwm_probe(struct platform_device *pdev)
{
const struct platform_device_id *id = platform_get_device_id(pdev);
@@ -187,7 +173,7 @@ static int pwm_probe(struct platform_device *pdev)
pwm->chip.npwm = (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1;
if (IS_ENABLED(CONFIG_OF)) {
- pwm->chip.of_xlate = pxa_pwm_of_xlate;
+ pwm->chip.of_xlate = of_pwm_single_xlate;
pwm->chip.of_pwm_n_cells = 1;
}
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: Introduce single-PWM of_xlate function
2021-04-23 21:30 [PATCH] pwm: Introduce single-PWM of_xlate function Bjorn Andersson
@ 2021-04-23 21:37 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2021-04-23 21:37 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Lee Jones; +Cc: linux-pwm, lkml
On Fri, Apr 23, 2021 at 4:30 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> The existing pxa driver and the upcoming addition of PWM support in the
> TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and
> thereby a need for a of_xlate function with the period as its single
> argument.
>
> Introduce a common helper function in the core that can be used as
> of_xlate by such drivers and migrate the pxa driver to use this.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pwm/core.c | 24 ++++++++++++++++++++++++
> drivers/pwm/pwm-pxa.c | 16 +---------------
> 2 files changed, 25 insertions(+), 15 deletions(-)
Please disregard this (v1), I apparently left the include file change
in the index and didn't see this until I had posted the patch. This is
corrected in v2.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-23 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 21:30 [PATCH] pwm: Introduce single-PWM of_xlate function Bjorn Andersson
2021-04-23 21:37 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.