All of lore.kernel.org
 help / color / mirror / Atom feed
* mm/cma.c:209:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
@ 2021-04-24  3:43 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-24  3:43 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5832 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Barry Song <song.bao.hua@hisilicon.com>
CC: Nathan Chancellor <natechancellor@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Mike Kravetz <mike.kravetz@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e77a830c8297c088f80e337cf888af7d014a16d7
commit: 18e98e56f4407b8c766b6f6d9f2850fd2a081e4d mm: cma: fix the name of CMA areas
date:   8 months ago
:::::: branch date: 6 hours ago
:::::: commit date: 8 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


vim +209 mm/cma.c

a254129e8686bf Joonsoo Kim      2014-08-06  159  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  160  /**
de9e14eebf33a6 Marek Szyprowski 2014-10-13  161   * cma_init_reserved_mem() - create custom contiguous area from reserved memory
de9e14eebf33a6 Marek Szyprowski 2014-10-13  162   * @base: Base address of the reserved area
de9e14eebf33a6 Marek Szyprowski 2014-10-13  163   * @size: Size of the reserved area (in bytes),
de9e14eebf33a6 Marek Szyprowski 2014-10-13  164   * @order_per_bit: Order of pages represented by one bit on bitmap.
e8b098fc5747a7 Mike Rapoport    2018-04-05  165   * @name: The name of the area. If this parameter is NULL, the name of
e8b098fc5747a7 Mike Rapoport    2018-04-05  166   *        the area will be set to "cmaN", where N is a running counter of
e8b098fc5747a7 Mike Rapoport    2018-04-05  167   *        used areas.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  168   * @res_cma: Pointer to store the created cma region.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  169   *
de9e14eebf33a6 Marek Szyprowski 2014-10-13  170   * This function creates custom contiguous area from already reserved memory.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  171   */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  172  int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
ac173824959ade Sasha Levin      2015-04-14  173  				 unsigned int order_per_bit,
f318dd083c8128 Laura Abbott     2017-04-18  174  				 const char *name,
ac173824959ade Sasha Levin      2015-04-14  175  				 struct cma **res_cma)
de9e14eebf33a6 Marek Szyprowski 2014-10-13  176  {
de9e14eebf33a6 Marek Szyprowski 2014-10-13  177  	struct cma *cma;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  178  	phys_addr_t alignment;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  179  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  180  	/* Sanity checks */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  181  	if (cma_area_count == ARRAY_SIZE(cma_areas)) {
de9e14eebf33a6 Marek Szyprowski 2014-10-13  182  		pr_err("Not enough slots for CMA reserved regions!\n");
de9e14eebf33a6 Marek Szyprowski 2014-10-13  183  		return -ENOSPC;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  184  	}
de9e14eebf33a6 Marek Szyprowski 2014-10-13  185  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  186  	if (!size || !memblock_is_region_reserved(base, size))
de9e14eebf33a6 Marek Szyprowski 2014-10-13  187  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  188  
0f96ae2928a547 Shailendra Verma 2015-06-24  189  	/* ensure minimal alignment required by mm core */
badbda53e50508 Stephen Rothwell 2016-05-27  190  	alignment = PAGE_SIZE <<
badbda53e50508 Stephen Rothwell 2016-05-27  191  			max_t(unsigned long, MAX_ORDER - 1, pageblock_order);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  192  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  193  	/* alignment should be aligned with order_per_bit */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  194  	if (!IS_ALIGNED(alignment >> PAGE_SHIFT, 1 << order_per_bit))
de9e14eebf33a6 Marek Szyprowski 2014-10-13  195  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  196  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  197  	if (ALIGN(base, alignment) != base || ALIGN(size, alignment) != size)
de9e14eebf33a6 Marek Szyprowski 2014-10-13  198  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  199  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  200  	/*
de9e14eebf33a6 Marek Szyprowski 2014-10-13  201  	 * Each reserved area must be initialised later, when more kernel
de9e14eebf33a6 Marek Szyprowski 2014-10-13  202  	 * subsystems (like slab allocator) are available.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  203  	 */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  204  	cma = &cma_areas[cma_area_count];
18e98e56f4407b Barry Song       2020-08-11  205  
18e98e56f4407b Barry Song       2020-08-11  206  	if (name)
18e98e56f4407b Barry Song       2020-08-11  207  		snprintf(cma->name, CMA_MAX_NAME, name);
18e98e56f4407b Barry Song       2020-08-11  208  	else
18e98e56f4407b Barry Song       2020-08-11 @209  		snprintf(cma->name, CMA_MAX_NAME,  "cma%d\n", cma_area_count);
18e98e56f4407b Barry Song       2020-08-11  210  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  211  	cma->base_pfn = PFN_DOWN(base);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  212  	cma->count = size >> PAGE_SHIFT;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  213  	cma->order_per_bit = order_per_bit;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  214  	*res_cma = cma;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  215  	cma_area_count++;
94737a85f332ae George G. Davis  2015-02-11  216  	totalcma_pages += (size / PAGE_SIZE);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  217  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  218  	return 0;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  219  }
de9e14eebf33a6 Marek Szyprowski 2014-10-13  220  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
* mm/cma.c:209:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
@ 2021-07-16  1:43 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-16  1:43 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 6100 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Barry Song <song.bao.hua@hisilicon.com>
CC: Nathan Chancellor <natechancellor@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Mike Kravetz <mike.kravetz@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e9338abf0e186336022293d2e454c106761f262b
commit: 18e98e56f4407b8c766b6f6d9f2850fd2a081e4d mm: cma: fix the name of CMA areas
date:   11 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 11 months ago
compiler: aarch64-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)
>> mm/cma.c:209:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
     snprintf(cma->name, CMA_MAX_NAME,  "cma%dn", cma_area_count);
     ^

vim +209 mm/cma.c

a254129e8686bf Joonsoo Kim      2014-08-06  159  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  160  /**
de9e14eebf33a6 Marek Szyprowski 2014-10-13  161   * cma_init_reserved_mem() - create custom contiguous area from reserved memory
de9e14eebf33a6 Marek Szyprowski 2014-10-13  162   * @base: Base address of the reserved area
de9e14eebf33a6 Marek Szyprowski 2014-10-13  163   * @size: Size of the reserved area (in bytes),
de9e14eebf33a6 Marek Szyprowski 2014-10-13  164   * @order_per_bit: Order of pages represented by one bit on bitmap.
e8b098fc5747a7 Mike Rapoport    2018-04-05  165   * @name: The name of the area. If this parameter is NULL, the name of
e8b098fc5747a7 Mike Rapoport    2018-04-05  166   *        the area will be set to "cmaN", where N is a running counter of
e8b098fc5747a7 Mike Rapoport    2018-04-05  167   *        used areas.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  168   * @res_cma: Pointer to store the created cma region.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  169   *
de9e14eebf33a6 Marek Szyprowski 2014-10-13  170   * This function creates custom contiguous area from already reserved memory.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  171   */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  172  int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
ac173824959ade Sasha Levin      2015-04-14  173  				 unsigned int order_per_bit,
f318dd083c8128 Laura Abbott     2017-04-18  174  				 const char *name,
ac173824959ade Sasha Levin      2015-04-14  175  				 struct cma **res_cma)
de9e14eebf33a6 Marek Szyprowski 2014-10-13  176  {
de9e14eebf33a6 Marek Szyprowski 2014-10-13  177  	struct cma *cma;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  178  	phys_addr_t alignment;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  179  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  180  	/* Sanity checks */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  181  	if (cma_area_count == ARRAY_SIZE(cma_areas)) {
de9e14eebf33a6 Marek Szyprowski 2014-10-13  182  		pr_err("Not enough slots for CMA reserved regions!\n");
de9e14eebf33a6 Marek Szyprowski 2014-10-13  183  		return -ENOSPC;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  184  	}
de9e14eebf33a6 Marek Szyprowski 2014-10-13  185  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  186  	if (!size || !memblock_is_region_reserved(base, size))
de9e14eebf33a6 Marek Szyprowski 2014-10-13  187  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  188  
0f96ae2928a547 Shailendra Verma 2015-06-24  189  	/* ensure minimal alignment required by mm core */
badbda53e50508 Stephen Rothwell 2016-05-27  190  	alignment = PAGE_SIZE <<
badbda53e50508 Stephen Rothwell 2016-05-27  191  			max_t(unsigned long, MAX_ORDER - 1, pageblock_order);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  192  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  193  	/* alignment should be aligned with order_per_bit */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  194  	if (!IS_ALIGNED(alignment >> PAGE_SHIFT, 1 << order_per_bit))
de9e14eebf33a6 Marek Szyprowski 2014-10-13  195  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  196  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  197  	if (ALIGN(base, alignment) != base || ALIGN(size, alignment) != size)
de9e14eebf33a6 Marek Szyprowski 2014-10-13  198  		return -EINVAL;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  199  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  200  	/*
de9e14eebf33a6 Marek Szyprowski 2014-10-13  201  	 * Each reserved area must be initialised later, when more kernel
de9e14eebf33a6 Marek Szyprowski 2014-10-13  202  	 * subsystems (like slab allocator) are available.
de9e14eebf33a6 Marek Szyprowski 2014-10-13  203  	 */
de9e14eebf33a6 Marek Szyprowski 2014-10-13  204  	cma = &cma_areas[cma_area_count];
18e98e56f4407b Barry Song       2020-08-11  205  
18e98e56f4407b Barry Song       2020-08-11  206  	if (name)
18e98e56f4407b Barry Song       2020-08-11  207  		snprintf(cma->name, CMA_MAX_NAME, name);
18e98e56f4407b Barry Song       2020-08-11  208  	else
18e98e56f4407b Barry Song       2020-08-11 @209  		snprintf(cma->name, CMA_MAX_NAME,  "cma%d\n", cma_area_count);
18e98e56f4407b Barry Song       2020-08-11  210  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  211  	cma->base_pfn = PFN_DOWN(base);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  212  	cma->count = size >> PAGE_SHIFT;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  213  	cma->order_per_bit = order_per_bit;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  214  	*res_cma = cma;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  215  	cma_area_count++;
94737a85f332ae George G. Davis  2015-02-11  216  	totalcma_pages += (size / PAGE_SIZE);
de9e14eebf33a6 Marek Szyprowski 2014-10-13  217  
de9e14eebf33a6 Marek Szyprowski 2014-10-13  218  	return 0;
de9e14eebf33a6 Marek Szyprowski 2014-10-13  219  }
de9e14eebf33a6 Marek Szyprowski 2014-10-13  220  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-16  1:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24  3:43 mm/cma.c:209:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] kernel test robot
2021-07-16  1:43 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.