* [linux-next:master 5822/14867] net/netfilter/nf_flow_table_ip.c:312 nf_flow_offload_ip_hook() error: uninitialized symbol 'ret'.
@ 2021-04-25 1:22 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-25 1:22 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8530 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Pablo Neira Ayuso <pablo@netfilter.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e3d35712f85ac84fb06234848f6c043ab418cf8b
commit: 7a27f6ab41356ecba47ec2bec6d635704c169779 [5822/14867] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device
:::::: branch date: 2 days ago
:::::: commit date: 4 weeks ago
config: i386-randconfig-m021-20210425 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/netfilter/nf_flow_table_ip.c:312 nf_flow_offload_ip_hook() error: uninitialized symbol 'ret'.
net/netfilter/nf_flow_table_ip.c:546 nf_flow_offload_ipv6_hook() error: uninitialized symbol 'ret'.
Old smatch warnings:
net/netfilter/nf_flow_table_ip.c:92 nf_flow_snat_ip() error: uninitialized symbol 'addr'.
net/netfilter/nf_flow_table_ip.c:92 nf_flow_snat_ip() error: uninitialized symbol 'new_addr'.
net/netfilter/nf_flow_table_ip.c:115 nf_flow_dnat_ip() error: uninitialized symbol 'addr'.
net/netfilter/nf_flow_table_ip.c:115 nf_flow_dnat_ip() error: uninitialized symbol 'new_addr'.
vim +/ret +312 net/netfilter/nf_flow_table_ip.c
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 227
7d208687176292 Felix Fietkau 2018-02-26 228 unsigned int
7d208687176292 Felix Fietkau 2018-02-26 229 nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb,
7d208687176292 Felix Fietkau 2018-02-26 230 const struct nf_hook_state *state)
7d208687176292 Felix Fietkau 2018-02-26 231 {
7d208687176292 Felix Fietkau 2018-02-26 232 struct flow_offload_tuple_rhash *tuplehash;
7d208687176292 Felix Fietkau 2018-02-26 233 struct nf_flowtable *flow_table = priv;
7d208687176292 Felix Fietkau 2018-02-26 234 struct flow_offload_tuple tuple = {};
7d208687176292 Felix Fietkau 2018-02-26 235 enum flow_offload_tuple_dir dir;
7d208687176292 Felix Fietkau 2018-02-26 236 struct flow_offload *flow;
7d208687176292 Felix Fietkau 2018-02-26 237 struct net_device *outdev;
2a79fd3908acd8 Jason A. Donenfeld 2018-05-30 238 struct rtable *rt;
b6f27d322a0a7b Felix Fietkau 2018-02-26 239 unsigned int thoff;
7d208687176292 Felix Fietkau 2018-02-26 240 struct iphdr *iph;
7d208687176292 Felix Fietkau 2018-02-26 241 __be32 nexthop;
2fc11745c3ffa3 Pablo Neira Ayuso 2021-03-17 242 u32 hdrsize;
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 243 int ret;
7d208687176292 Felix Fietkau 2018-02-26 244
7d208687176292 Felix Fietkau 2018-02-26 245 if (skb->protocol != htons(ETH_P_IP))
7d208687176292 Felix Fietkau 2018-02-26 246 return NF_ACCEPT;
7d208687176292 Felix Fietkau 2018-02-26 247
2fc11745c3ffa3 Pablo Neira Ayuso 2021-03-17 248 if (nf_flow_tuple_ip(skb, state->in, &tuple, &hdrsize) < 0)
7d208687176292 Felix Fietkau 2018-02-26 249 return NF_ACCEPT;
7d208687176292 Felix Fietkau 2018-02-26 250
7d208687176292 Felix Fietkau 2018-02-26 251 tuplehash = flow_offload_lookup(flow_table, &tuple);
7d208687176292 Felix Fietkau 2018-02-26 252 if (tuplehash == NULL)
7d208687176292 Felix Fietkau 2018-02-26 253 return NF_ACCEPT;
7d208687176292 Felix Fietkau 2018-02-26 254
7d208687176292 Felix Fietkau 2018-02-26 255 dir = tuplehash->tuple.dir;
7d208687176292 Felix Fietkau 2018-02-26 256 flow = container_of(tuplehash, struct flow_offload, tuplehash[dir]);
7d208687176292 Felix Fietkau 2018-02-26 257
e75b3e1c9bc5b9 Florian Westphal 2019-05-21 258 if (unlikely(nf_flow_exceeds_mtu(skb, flow->tuplehash[dir].tuple.mtu)))
7d208687176292 Felix Fietkau 2018-02-26 259 return NF_ACCEPT;
7d208687176292 Felix Fietkau 2018-02-26 260
2fc11745c3ffa3 Pablo Neira Ayuso 2021-03-17 261 iph = ip_hdr(skb);
2fc11745c3ffa3 Pablo Neira Ayuso 2021-03-17 262 thoff = iph->ihl * 4;
2fc11745c3ffa3 Pablo Neira Ayuso 2021-03-17 263 if (nf_flow_state_check(flow, iph->protocol, skb, thoff))
b6f27d322a0a7b Felix Fietkau 2018-02-26 264 return NF_ACCEPT;
b6f27d322a0a7b Felix Fietkau 2018-02-26 265
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 266 if (tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_NEIGH ||
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 267 tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_XFRM) {
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 268 rt = (struct rtable *)tuplehash->tuple.dst_cache;
e5075c0badaaac Pablo Neira Ayuso 2021-03-17 269 if (!dst_check(&rt->dst, 0)) {
589b474a4b7ce4 Florian Westphal 2019-07-30 270 flow_offload_teardown(flow);
589b474a4b7ce4 Florian Westphal 2019-07-30 271 return NF_ACCEPT;
589b474a4b7ce4 Florian Westphal 2019-07-30 272 }
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 273 }
589b474a4b7ce4 Florian Westphal 2019-07-30 274
2babb46c8c825e Pablo Neira Ayuso 2021-03-17 275 if (skb_try_make_writable(skb, thoff + hdrsize))
2babb46c8c825e Pablo Neira Ayuso 2021-03-17 276 return NF_DROP;
2babb46c8c825e Pablo Neira Ayuso 2021-03-17 277
1b9cd7690a1ef6 Pablo Neira Ayuso 2021-03-17 278 flow_offload_refresh(flow_table, flow);
1b9cd7690a1ef6 Pablo Neira Ayuso 2021-03-17 279
2babb46c8c825e Pablo Neira Ayuso 2021-03-17 280 iph = ip_hdr(skb);
f4401262b927b8 Pablo Neira Ayuso 2021-03-17 281 nf_flow_nat_ip(flow, skb, thoff, dir, iph);
7d208687176292 Felix Fietkau 2018-02-26 282
7d208687176292 Felix Fietkau 2018-02-26 283 ip_decrease_ttl(iph);
de20900fbe1c4f Florian Westphal 2019-08-27 284 skb->tstamp = 0;
7d208687176292 Felix Fietkau 2018-02-26 285
53c2b2899af7e6 Pablo Neira Ayuso 2020-03-24 286 if (flow_table->flags & NF_FLOWTABLE_COUNTER)
53c2b2899af7e6 Pablo Neira Ayuso 2020-03-24 287 nf_ct_acct_update(flow->ct, tuplehash->tuple.dir, skb->len);
53c2b2899af7e6 Pablo Neira Ayuso 2020-03-24 288
5139c0c007250c Pablo Neira Ayuso 2021-03-24 289 if (unlikely(tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_XFRM)) {
589b474a4b7ce4 Florian Westphal 2019-07-30 290 memset(skb->cb, 0, sizeof(struct inet_skb_parm));
589b474a4b7ce4 Florian Westphal 2019-07-30 291 IPCB(skb)->iif = skb->dev->ifindex;
589b474a4b7ce4 Florian Westphal 2019-07-30 292 IPCB(skb)->flags = IPSKB_FORWARDED;
589b474a4b7ce4 Florian Westphal 2019-07-30 293 return nf_flow_xmit_xfrm(skb, state, &rt->dst);
589b474a4b7ce4 Florian Westphal 2019-07-30 294 }
589b474a4b7ce4 Florian Westphal 2019-07-30 295
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 296 switch (tuplehash->tuple.xmit_type) {
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 297 case FLOW_OFFLOAD_XMIT_NEIGH:
5139c0c007250c Pablo Neira Ayuso 2021-03-24 298 outdev = rt->dst.dev;
7d208687176292 Felix Fietkau 2018-02-26 299 skb->dev = outdev;
7d208687176292 Felix Fietkau 2018-02-26 300 nexthop = rt_nexthop(rt, flow->tuplehash[!dir].tuple.src_v4.s_addr);
2a79fd3908acd8 Jason A. Donenfeld 2018-05-30 301 skb_dst_set_noref(skb, &rt->dst);
7d208687176292 Felix Fietkau 2018-02-26 302 neigh_xmit(NEIGH_ARP_TABLE, outdev, &nexthop, skb);
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 303 ret = NF_STOLEN;
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 304 break;
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 305 case FLOW_OFFLOAD_XMIT_DIRECT:
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 306 ret = nf_flow_queue_xmit(state->net, skb, tuplehash, ETH_P_IP);
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 307 if (ret == NF_DROP)
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 308 flow_offload_teardown(flow);
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 309 break;
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 310 }
7d208687176292 Felix Fietkau 2018-02-26 311
7a27f6ab41356e Pablo Neira Ayuso 2021-03-24 @312 return ret;
7d208687176292 Felix Fietkau 2018-02-26 313 }
7d208687176292 Felix Fietkau 2018-02-26 314 EXPORT_SYMBOL_GPL(nf_flow_offload_ip_hook);
a908fdec3dda29 Felix Fietkau 2018-02-26 315
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37054 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-25 1:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 1:22 [linux-next:master 5822/14867] net/netfilter/nf_flow_table_ip.c:312 nf_flow_offload_ip_hook() error: uninitialized symbol 'ret' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.