* [PATCH] cxgb4: Remove redundant assignment to ret
@ 2021-04-25 10:37 Jiapeng Chong
2021-04-26 4:26 ` Raju Rangoju
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-25 10:37 UTC (permalink / raw)
To: rajur; +Cc: davem, kuba, netdev, linux-kernel, Jiapeng Chong
Variable ret is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Cleans up the following clang-analyzer warning:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3830:2: warning: Value stored
to 'ret' is never read [clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index 80882cf..b9d2d58 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -3827,8 +3827,8 @@ int t4_load_phy_fw(struct adapter *adap, int win,
FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_PHYFW) |
FW_PARAMS_PARAM_Y_V(adap->params.portvec) |
FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD));
- ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1,
- ¶m, &val, 30000);
+ t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1,
+ ¶m, &val, 30000);
/* If we have version number support, then check to see that the new
* firmware got loaded properly.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb4: Remove redundant assignment to ret
2021-04-25 10:37 [PATCH] cxgb4: Remove redundant assignment to ret Jiapeng Chong
@ 2021-04-26 4:26 ` Raju Rangoju
0 siblings, 0 replies; 2+ messages in thread
From: Raju Rangoju @ 2021-04-26 4:26 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: davem, kuba, netdev, linux-kernel
On Sunday, April 04/25/21, 2021 at 18:37:03 +0800, Jiapeng Chong wrote:
> Variable ret is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3830:2: warning: Value stored
> to 'ret' is never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> index 80882cf..b9d2d58 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> @@ -3827,8 +3827,8 @@ int t4_load_phy_fw(struct adapter *adap, int win,
> FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_PHYFW) |
> FW_PARAMS_PARAM_Y_V(adap->params.portvec) |
> FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD));
> - ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1,
> - ¶m, &val, 30000);
Thanks for reporting this. However, the return value of
t4_set_params_timeout() needs to be handled and can not be ignored. Will
send a patch to fix the issue soon.
> + t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1,
> + ¶m, &val, 30000);
>
> /* If we have version number support, then check to see that the new
> * firmware got loaded properly.
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 4:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 10:37 [PATCH] cxgb4: Remove redundant assignment to ret Jiapeng Chong
2021-04-26 4:26 ` Raju Rangoju
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.