* [Buildroot] [PATCH 1/2] Revert "package/domoticz: drop boost date-time dependency" @ 2021-04-26 19:00 Fabrice Fontaine 2021-04-26 19:00 ` [Buildroot] [PATCH 2/2] package/boost: select boost atomic Fabrice Fontaine 0 siblings, 1 reply; 2+ messages in thread From: Fabrice Fontaine @ 2021-04-26 19:00 UTC (permalink / raw) To: buildroot This reverts commit 4b4d98e2c5165c3121e670192970fc909cae6d8a as Boost::date_time is still used by domoticz (in pmain/Scheduler.cpp and push/BasePush.cpp) Fixes: - http://autobuild.buildroot.org/results/493a2e93fe6121f118293a268f986ee51009b7e8 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/domoticz/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in index f9672056ee..83ae2035b2 100644 --- a/package/domoticz/Config.in +++ b/package/domoticz/Config.in @@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_DATE_TIME select BR2_PACKAGE_BOOST_SYSTEM select BR2_PACKAGE_BOOST_THREAD select BR2_PACKAGE_CEREAL -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 2/2] package/boost: select boost atomic 2021-04-26 19:00 [Buildroot] [PATCH 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine @ 2021-04-26 19:00 ` Fabrice Fontaine 0 siblings, 0 replies; 2+ messages in thread From: Fabrice Fontaine @ 2021-04-26 19:00 UTC (permalink / raw) To: buildroot domoticz does not use Boost::atomic but cmake is so "smart" that it (wrongly) assumes that Boost::thread depends on Boost:date_time and Boost::atomic since boost version 1.54: set(_Boost_THREAD_DEPENDENCIES chrono date_time atomic) Extracted from: - https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindBoost.cmake#L1113 As we can't patch every cmake on the field, just select boost atomic It should be noted that build failures are only raised since commit 8a46b41b4a5d1c2f5ebefd7fc23fec7e8ba0598c as this commit drop the patch that was decreasing cmake version but also removing: target_link_libraries(domoticz Boost::thread Boost::system) Fixes: - http://autobuild.buildroot.org/results/4306c0a725ed9a34bd55550df428866db6e4f052 - http://autobuild.buildroot.org/results/2478e7a2ec1c63dcc2b36d29a39004468b230211 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/domoticz/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in index 83ae2035b2..26e79c18b7 100644 --- a/package/domoticz/Config.in +++ b/package/domoticz/Config.in @@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_ATOMIC select BR2_PACKAGE_BOOST_DATE_TIME select BR2_PACKAGE_BOOST_SYSTEM select BR2_PACKAGE_BOOST_THREAD -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 19:00 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-26 19:00 [Buildroot] [PATCH 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine 2021-04-26 19:00 ` [Buildroot] [PATCH 2/2] package/boost: select boost atomic Fabrice Fontaine
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.