* [PATCH] wil6210: remove erroneous wiphy locking
@ 2021-04-26 19:29 Johannes Berg
2021-06-15 14:06 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2021-04-26 19:29 UTC (permalink / raw)
To: linux-wireless; +Cc: Harald Arnesen, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
We already hold the wiphy lock in all cases when we get
here, so this would deadlock, remove the erroneous locking.
Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/ath/wil6210/cfg80211.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c
index 6746fd206d2a..1ff2679963f0 100644
--- a/drivers/net/wireless/ath/wil6210/cfg80211.c
+++ b/drivers/net/wireless/ath/wil6210/cfg80211.c
@@ -2842,9 +2842,7 @@ void wil_p2p_wdev_free(struct wil6210_priv *wil)
wil->radio_wdev = wil->main_ndev->ieee80211_ptr;
mutex_unlock(&wil->vif_mutex);
if (p2p_wdev) {
- wiphy_lock(wil->wiphy);
cfg80211_unregister_wdev(p2p_wdev);
- wiphy_unlock(wil->wiphy);
kfree(p2p_wdev);
}
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wil6210: remove erroneous wiphy locking
2021-04-26 19:29 [PATCH] wil6210: remove erroneous wiphy locking Johannes Berg
@ 2021-06-15 14:06 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-06-15 14:06 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Harald Arnesen, Johannes Berg
Johannes Berg <johannes@sipsolutions.net> wrote:
> We already hold the wiphy lock in all cases when we get
> here, so this would deadlock, remove the erroneous locking.
>
> Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
8f78caa2264e wil6210: remove erroneous wiphy locking
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210426212929.83f1de07c2cd.I630a2a00eff185ba0452324b3d3f645e01128a95@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-15 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 19:29 [PATCH] wil6210: remove erroneous wiphy locking Johannes Berg
2021-06-15 14:06 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.